From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7349A4553F; Mon, 1 Jul 2024 22:17:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41C934026B; Mon, 1 Jul 2024 22:17:49 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 5E6E74021E for ; Mon, 1 Jul 2024 22:17:48 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7067a2e9607so2796011b3a.3 for ; Mon, 01 Jul 2024 13:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719865067; x=1720469867; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9amR7ehFCcmwQkNgr0tO6p6TOzOMVRbd6YwyQHgJQxI=; b=OIxqgfLr2o4+oNkkN6kd9+K4W5qsJBJYOrBLUqzBXN3UM+/wT/qlPGArYg55Bs17CF 9FLha1+kO4cM58GsM1JRXkXIijq4vgN5g/vATLxcVpVbiDLW6TAVo98O2EXXKazIjEtA kSIlPFLYtHC4ocYUFo6y8HJQehQlWKjGUR38k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719865067; x=1720469867; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9amR7ehFCcmwQkNgr0tO6p6TOzOMVRbd6YwyQHgJQxI=; b=EXjNg1X3sxKz7UA+8ejHRPKo97qfZrbDrltk/2Fszjqy/QZX4UZMyjpP34ispIvS0m xeo1Qy5Cu8maeXT5zaKfmp6x/U/DLoHwWyz0XJhFrOZyHbT8XrhAMyISrSifDZSQ2zXc VO/3gBexpPQaBzGaDY91i5VZf01qAHF+xA5O2ICGkyCOQM1i4x77dQn/71Rf+B70f72i 3vUc0NPy3xNjF3wxHBZziOM7JZu1oaVj+WY0QgWY3ijU5BZuCFgqPORVSVha4IX1v9eB CTeMPs78fIhdGLgPOfNsvqr9y0G1tLqSkbKEBkSynV388JMY963koT4SoeO5mc2pT6E0 ud3g== X-Forwarded-Encrypted: i=1; AJvYcCX3axcgWwOTnBuBe0EHjMF/eFNSDqXe2eFjZw9PKXJKcM7XeQUtF4o9KZ86C/BA5MYYAx5qg2Q9dUit+gE= X-Gm-Message-State: AOJu0Yy5IooQ/L/xKeNqAvNbEOsLHie4Snna0/UrAvfXR+WoiaFQ6jcD fvxG74jBUoqLbfFRSDszkndTgeTULZgzlDEXo+xq80CN+qGglcBNSusaGdBaXO7avScETp7C/nM /ROVSuW/ku0McRwrDQfvkMW6XRBTYGibHOe1JVw== X-Google-Smtp-Source: AGHT+IGlsDdV2Uo9EY/Ts98b3w0gy+7gWv4wLwuS7B8TCWZ19yUSvW9lkpat/kKVX7ZTVC2/lu15PBrvjfnTxbxl+ZE= X-Received: by 2002:a05:6a00:179d:b0:705:b0aa:a6bf with SMTP id d2e1a72fcca58-70aaad2bd89mr8644932b3a.2.1719865067421; Mon, 01 Jul 2024 13:17:47 -0700 (PDT) MIME-Version: 1.0 References: <20240617194638.12926-2-dmarx@iol.unh.edu> <20240628161930.15915-1-dmarx@iol.unh.edu> In-Reply-To: <20240628161930.15915-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Mon, 1 Jul 2024 16:17:35 -0400 Message-ID: Subject: Re: [PATCH v4 1/3] dts: add functions to testpmd shell To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hey Dean, Thanks for the new series. One thing I noted for the series as a whole is that there are a few small errors being thrown by the formatting script. One of the errors is on a method I wrote and gave you so I apologize for that, it looks like I changed a parameter to a method but didn't switch what I passed in when I called it. Outside of the formatting issues I just had a few small comments, otherwise it looks good to me. I did also update some of the methods used in this series in my dynamic queue suite, but the functionality should still be the same as what you have here so I'm unsure if it is worth pulling in my other changes or keeping what you have and resolving it at the time of merge. On Fri, Jun 28, 2024 at 12:20=E2=80=AFPM Dean Marx wrot= e: > > added set promisc, set verbose, and port stop > commands to testpmd shell. > > Signed-off-by: Dean Marx > --- > + def set_verbose(self, level: int, verify: bool =3D True): > + """Set debug verbosity level. > + > + Args: > + level: 0 - silent except for error > + 1 - fully verbose except for Tx packets > + 2 - fully verbose except for Rx packets > + >2 - fully verbose We should probably indent these 3 lines like they are in the VLAN test suit= e. > + verify: if :data:`True` an additional command will be sent t= o verify that verbose level > + is properly set. Defaults to :data:`True`. > + > + Raises: > + InteractiveCommandExecutionError: If `verify` is :data:`True= ` and verbose level > + is not correctly set. > + """ > + verbose_output =3D self.send_command(f"set verbose {level}") > + if verify: > + if "Change verbose level" not in verbose_output: > + self._logger.debug(f"Failed to set verbose level to {lev= el}: \n{verbose_output}") > + raise InteractiveCommandExecutionError( > + f"Testpmd failed to set verbose level to {level}." > + ) > + > def close(self) -> None: > """Overrides :meth:`~.interactive_shell.close`.""" > self.send_command("quit", "") > -- > 2.44.0 >