From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FF64456F3; Tue, 30 Jul 2024 23:34:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F6B540609; Tue, 30 Jul 2024 23:34:50 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id D7E8640267 for ; Tue, 30 Jul 2024 23:34:00 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2cd2f89825fso3322104a91.1 for ; Tue, 30 Jul 2024 14:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1722375240; x=1722980040; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wk1H/fr4ye5E5NyW1YQsP+axoDg/nUTTX9SgGl5YnGg=; b=N3J0e8ExDvyRdTBJ6gGaK/OHLFfDVDggdFcFBUEmUBZz7AgkZvy1WJaWfyDoPWRrd0 QFEDxLq9iVF7wDQKdcoXQ3j2Y1lzMhPcFSmWsVb4ERMDoJWY0n+0OgHjzfdzkRmK2NQG 1OQJpnlXnwep2Ae4F1bzpcpWj36Bmacn3ooeo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722375240; x=1722980040; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wk1H/fr4ye5E5NyW1YQsP+axoDg/nUTTX9SgGl5YnGg=; b=gom2+tyPPgLDQwCBiP6A1vUyZsWdGzwnEfmTx28q825T03iaKrtwTKw67CUwcKSDI4 rSjdKbKd9+sUAWy8HnnQmj2gXCb60PshqtlElGm1GJdpTnhRNdnfm9rh0PcMV3X9BS+y zeWLrpQizWIMx7L9Y9I9ieN/p3BSVkqTdT2h1nIdDJOwOnNUPX6AiSHg44y2ibkigsEB EICgk4Tb2Nz+PwgyHV0aZe+5uZ3SBC+2ooT/9p/Jna2TEROu0+QcEO6/Xsu+L/MhP+BK 8mmcKniNW33kg4s7Ah1ziz/8jQ2ttleVUbzUKYv0TMOjIOMTtGEi2AbJ8v21LfCKueqI fcgw== X-Gm-Message-State: AOJu0YxRHt/hg129t2dz/vAzEFfIaO29RpqhuFoSNhr8URKiqCSuXSIK eE6jj/Tiy9W5XRKyHgFRRr5Ilnp4XvzqjpxlFfnSowJzqw0t3YWLAKP5/G2uCew8h8eA6CvLCzi I5EkYkgurgKQtITU9dYyTNZVcORrCIZxkewU2Gg== X-Google-Smtp-Source: AGHT+IEm+KkVKV9lBp8Ao6Wrp/ijurtEpKLxImdu6dLwnn6voUM6q5ZoWAMLRQ5LlNjeOOb0f/7jLnKBSlVCktgAepc= X-Received: by 2002:a17:90b:ec5:b0:2cc:ff56:5be1 with SMTP id 98e67ed59e1d1-2cf7e1bbe58mr10237342a91.7.1722375239883; Tue, 30 Jul 2024 14:33:59 -0700 (PDT) MIME-Version: 1.0 References: <20240729203955.267942-1-jspewock@iol.unh.edu> <20240730133459.21907-1-jspewock@iol.unh.edu> <20240730133459.21907-2-jspewock@iol.unh.edu> In-Reply-To: <20240730133459.21907-2-jspewock@iol.unh.edu> From: Jeremy Spewock Date: Tue, 30 Jul 2024 17:33:48 -0400 Message-ID: Subject: Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output To: yoan.picchi@foss.arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, Luca.Vizzarro@arm.com, juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 30, 2024 at 9:37=E2=80=AFAM wrote: > > class TestPmdDevice: > @@ -577,6 +577,128 @@ class TestPmdPortStats(TextParser): > tx_bps: int =3D field(metadata=3DTextParser.find_int(r"Tx-bps:\s+(\d= +)")) > > > +class VerboseOLFlag(Flag): > + """Flag representing the OL flags of a packet from Testpmd verbose o= utput.""" > + > + #: > + RTE_MBUF_F_RX_RSS_HASH =3D auto() > + > + #: > + RTE_MBUF_F_RX_L4_CKSUM_GOOD =3D auto() > + #: > + RTE_MBUF_F_RX_L4_CKSUM_BAD =3D auto() > + #: > + RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN =3D auto() > + > + #: > + RTE_MBUF_F_RX_IP_CKSUM_GOOD =3D auto() > + #: > + RTE_MBUF_F_RX_IP_CKSUM_BAD =3D auto() > + #: > + RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN =3D auto() > + > + #: > + RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD =3D auto() > + #: > + RTE_MBUF_F_RX_OUTER_L4_CKSUM_BAD =3D auto() > + #: > + RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN =3D auto() > + After reading more of the API and using this patch to write a test suite, I believe there is more expansion of these OL flags that should take place. For starters, there are the Tx OL flags that, while not seeming to be very useful for the current test suites we are writing, wouldn't hurt to also include as they seem to be fairly different. Additionally, there are some other less common RX OL flags that should be included here just to cover all options. I will work on adding these into the next version. >