Re: [PATCH v6 1/3] dts: add functions to testpmd shell

[Jeremy Spewock <jspewock@iol.unh.edu>]

On Wed, Jul 10, 2024 at 12:01 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> added set promisc, set verbose, and port stop
> commands to testpmd shell.
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
>  dts/framework/remote_session/testpmd_shell.py | 194 +++++++++++++++++-
>  1 file changed, 193 insertions(+), 1 deletion(-)
<snip>
> -    def close(self) -> None:
<snip>
> +    def _close(self) -> None:

This looks like something that might have snuck into this diff from
the context manager series. This method is still called close() on
main, so it's probably better to switch the name back here to match in
the meantime.

>          """Overrides :meth:`~.interactive_shell.close`."""
>          self.send_command("quit", "")
>          return super().close()
> --
> 2.44.0
>