From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1947455F7; Thu, 11 Jul 2024 15:59:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92A0842F35; Thu, 11 Jul 2024 15:59:27 +0200 (CEST) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 1F85742F27 for ; Thu, 11 Jul 2024 15:59:26 +0200 (CEST) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2c9baecc80fso734129a91.1 for ; Thu, 11 Jul 2024 06:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1720706365; x=1721311165; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bGw21JsEBCIghqvWkzZ0R13sQeU9yIJp9l2zLSOG10I=; b=B3+Zhvnmvr08roBGjovwlBWBAQfpTgQbe9yubyBaD0AVSjALhCZ5CgaQsZ8t2PQsFg +Ogqy8UvswH50BQa601ocI94NJ8kkinuAzcvJWRu4TEBwo06DjasBT0F1OJ2ez8SGm9j AV+g5RMXRGb3SC7ZphtonLW8CaTLJMY9qZUrk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720706365; x=1721311165; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bGw21JsEBCIghqvWkzZ0R13sQeU9yIJp9l2zLSOG10I=; b=uF2rOJCvkR5QEDI/oNjOcU1G1gsrnmdtzSmNvAu8HLmv6A201dcde/Q9x3LksC8xrt IBdQIVAL51QLeviRVsOeLuc+e1nlupV6DJ2lQPmBAOXl25NDoE62XTmI7zDRCCIi4OgH sqtWQ0qYp55ZRMfvq/LOh4bCBDVABvED5kaJiZbjjixnXTEHsUeZafxn2+Mo8IbRSDHr EkElFfpYIB7mEHNzzTiTipJZlDkKnsBG0PuSowIqBzPY//2s6S2AKGn5DbUrTGbAU4q7 /2drHnySANr6p2eSaoudpC4o3zEIxZEzBGZkKrijrNulhrPQKz2KpibI8e20CK5WfNUM oPVw== X-Forwarded-Encrypted: i=1; AJvYcCVT9YVBmPN8kLV2ELAWLinGcusYLEcl/nKn8aZLtJZCZ5L8L+wN8n/L9lNJT0t0RENYk1peARqchGvHnwg= X-Gm-Message-State: AOJu0YzoMzn+P1JSHaZf++6rTkDGhqUNovPx1xMby0ygSX8MtqF60eNx 7LQVCqLYqcYt6fT0NuBusR0xPwPxiVTz6k02ntXEHthZ5oCbOSWwhOyx94EGDsEhAGqtF0JN8Tj z1lkxzZGwpBaA6+01ZI5ABI3walY9ZVDU6lSsPg== X-Google-Smtp-Source: AGHT+IHGijoY9Bn90/eNexVqgks2tT6trc6XXwq9hJvRgOi9F85EOhJEhOYk/ffPfG8h4bS6fFu7sgrBIOJiVfhZjkE= X-Received: by 2002:a17:90b:180e:b0:2c4:e333:35e5 with SMTP id 98e67ed59e1d1-2ca35d43471mr7105246a91.36.1720706365172; Thu, 11 Jul 2024 06:59:25 -0700 (PDT) MIME-Version: 1.0 References: <20240617194638.12926-2-dmarx@iol.unh.edu> <20240710160136.9908-1-dmarx@iol.unh.edu> In-Reply-To: <20240710160136.9908-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Thu, 11 Jul 2024 09:59:13 -0400 Message-ID: Subject: Re: [PATCH v6 1/3] dts: add functions to testpmd shell To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 10, 2024 at 12:01=E2=80=AFPM Dean Marx wrot= e: > > added set promisc, set verbose, and port stop > commands to testpmd shell. > > Signed-off-by: Dean Marx > --- > dts/framework/remote_session/testpmd_shell.py | 194 +++++++++++++++++- > 1 file changed, 193 insertions(+), 1 deletion(-) > - def close(self) -> None: > + def _close(self) -> None: This looks like something that might have snuck into this diff from the context manager series. This method is still called close() on main, so it's probably better to switch the name back here to match in the meantime. > """Overrides :meth:`~.interactive_shell.close`.""" > self.send_command("quit", "") > return super().close() > -- > 2.44.0 >