From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66D4F45A12; Mon, 23 Sep 2024 21:26:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54D1040395; Mon, 23 Sep 2024 21:26:30 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 4DE5740395 for ; Mon, 23 Sep 2024 21:26:29 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2d86f713557so3081499a91.2 for ; Mon, 23 Sep 2024 12:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1727119588; x=1727724388; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PvYL4mHvvnQzYJxfsNA0SHM7uRAw9MYGM4ka5Q1S5jA=; b=hTxIODW11KAE3v9KmfrBlgBKoPSmX7y4nVWE/LdRODGu5xtS92BstbyuAxI97EklOf sIbcHZQwuFEmWC7v33f3Cx73lw1PsRcMZ+DwF1u6x3IezxIF3Z+ESS1Brs7tIsCina89 tcJy33V5bAyjbsQtlAWcensxMgWTbu75yGXyE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727119588; x=1727724388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PvYL4mHvvnQzYJxfsNA0SHM7uRAw9MYGM4ka5Q1S5jA=; b=ftIseUCJgJ/2jeUzD5zXdyYCVu9e3PlBvFhz+9IWKo8hJw6X6X+sB5xrbYo8PSC/9a 7T3HRTAXBxfOOXMZkz8dwGVe26RxTgSnHDBH9cVqesPagsINio/BB2P9/scZOlur4O7r lFtUsN1WmRiltQEkgOvOeYhjfS4ZEMB33pFADixHiRGDVaPnD8BOpQhqa7NYGurbUdRE vCQ3b3pTO8b4uqs6B5Wbmqnw3jaGiuYhrZVZ6FJrhX56xUCdFST+ZBYbaRGcL2+K39E5 ntYJpCcLt2a5h8B69g1o1YNt4ChjB0RHkkvT4o3eqNrN2UcM7i2H0wcjaA3XQiqiF83V LAIA== X-Forwarded-Encrypted: i=1; AJvYcCWvVqyXcDTavwAzR7a0pj9LXSRLN782mFaIu8N2SFeP/uVUMlrvXmQ4UgzlZpYvXbN7/0Y=@dpdk.org X-Gm-Message-State: AOJu0YxWZKZZEa3eBPgNMiQjJbFFVeplN9heGQ1rG0HAXllDB95pD6Nd URIvA90OOVO+RipjzQmSyJryF2o4q5rPbrWOmlWXc8I+AAEVWGAal2GjGV4UTmzBgAsItHWCGAj WWWvttl5MFMO9Q0tPp063lAWY0h5UATsE6YiY/w== X-Google-Smtp-Source: AGHT+IFTG+3GEDBI8s64JJYHby2QEzUp0lGuEVj4ifuhDSfi0Qsrz6uKBKcyLPcGEK6iSonC39At65EY9hFCUMSTFmA= X-Received: by 2002:a17:90a:cf18:b0:2d3:b8d6:d041 with SMTP id 98e67ed59e1d1-2dd80c95adfmr14336876a91.32.1727119588458; Mon, 23 Sep 2024 12:26:28 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240923150210.57269-1-juraj.linkes@pantheon.tech> <20240923150210.57269-6-juraj.linkes@pantheon.tech> In-Reply-To: <20240923150210.57269-6-juraj.linkes@pantheon.tech> From: Jeremy Spewock Date: Mon, 23 Sep 2024 15:26:16 -0400 Message-ID: Subject: Re: [PATCH v4 06/11] dts: add NIC capability support To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, alex.chapman@arm.com, probb@iol.unh.edu, npratte@iol.unh.edu, dmarx@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 23, 2024 at 11:02=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > Some test cases or suites may be testing a NIC feature that is not > supported on all NICs, so add support for marking test cases or suites > as requiring NIC capabilities. > > The marking is done with a decorator, which populates the internal > required_capabilities attribute of TestProtocol. The NIC capability > itself is a wrapper around the NicCapability defined in testpmd_shell. > The reason is Enums cannot be extended and the class implements the > methods of its abstract base superclass. > > The decorator API is designed to be simple to use. The arguments passed > to it are all from the testpmd shell. Everything else (even the actual > capability object creation) is done internally. > > Signed-off-by: Juraj Linke=C5=A1 > Reviewed-by: Dean Marx Thank you for addressing all my comments! Reviewed-by: Jeremy Spewock