DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1] dts: fix testpmd port device error handling mode
@ 2024-08-23  7:45 Juraj Linkeš
  2024-09-02 13:46 ` Luca Vizzarro
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Juraj Linkeš @ 2024-08-23  7:45 UTC (permalink / raw)
  To: thomas, Honnappa.Nagarahalli, paul.szczepanek, Luca.Vizzarro,
	alex.chapman, probb, jspewock, npratte, dmarx
  Cc: dev, Juraj Linkeš

Make device_error_handling_mode of testpmd port optional as it may not
be present, e.g. in VM ports.

Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell")

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 dts/framework/remote_session/testpmd_shell.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index 43e9f56517..c3df44e7ab 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -464,8 +464,8 @@ class TestPmdPort(TextParser):
         metadata=DeviceCapabilitiesFlag.make_parser(),
     )
     #:
-    device_error_handling_mode: DeviceErrorHandlingMode = field(
-        metadata=DeviceErrorHandlingMode.make_parser()
+    device_error_handling_mode: DeviceErrorHandlingMode | None = field(
+        default=None, metadata=DeviceErrorHandlingMode.make_parser()
     )
     #:
     device_private_info: str | None = field(
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] dts: fix testpmd port device error handling mode
  2024-08-23  7:45 [PATCH v1] dts: fix testpmd port device error handling mode Juraj Linkeš
@ 2024-09-02 13:46 ` Luca Vizzarro
  2024-09-05 16:10 ` Jeremy Spewock
  2024-09-09 15:51 ` Juraj Linkeš
  2 siblings, 0 replies; 4+ messages in thread
From: Luca Vizzarro @ 2024-09-02 13:46 UTC (permalink / raw)
  To: Juraj Linkeš,
	thomas, Honnappa.Nagarahalli, paul.szczepanek, alex.chapman,
	probb, jspewock, npratte, dmarx
  Cc: dev

Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] dts: fix testpmd port device error handling mode
  2024-08-23  7:45 [PATCH v1] dts: fix testpmd port device error handling mode Juraj Linkeš
  2024-09-02 13:46 ` Luca Vizzarro
@ 2024-09-05 16:10 ` Jeremy Spewock
  2024-09-09 15:51 ` Juraj Linkeš
  2 siblings, 0 replies; 4+ messages in thread
From: Jeremy Spewock @ 2024-09-05 16:10 UTC (permalink / raw)
  To: Juraj Linkeš
  Cc: thomas, Honnappa.Nagarahalli, paul.szczepanek, Luca.Vizzarro,
	alex.chapman, probb, npratte, dmarx, dev

Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] dts: fix testpmd port device error handling mode
  2024-08-23  7:45 [PATCH v1] dts: fix testpmd port device error handling mode Juraj Linkeš
  2024-09-02 13:46 ` Luca Vizzarro
  2024-09-05 16:10 ` Jeremy Spewock
@ 2024-09-09 15:51 ` Juraj Linkeš
  2 siblings, 0 replies; 4+ messages in thread
From: Juraj Linkeš @ 2024-09-09 15:51 UTC (permalink / raw)
  To: thomas, Honnappa.Nagarahalli, paul.szczepanek, Luca.Vizzarro,
	alex.chapman, probb, jspewock, npratte, dmarx
  Cc: dev

Applied to next-dts, thanks.

On 23. 8. 2024 9:45, Juraj Linkeš wrote:
> Make device_error_handling_mode of testpmd port optional as it may not
> be present, e.g. in VM ports.
> 
> Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell")
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>   dts/framework/remote_session/testpmd_shell.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
> index 43e9f56517..c3df44e7ab 100644
> --- a/dts/framework/remote_session/testpmd_shell.py
> +++ b/dts/framework/remote_session/testpmd_shell.py
> @@ -464,8 +464,8 @@ class TestPmdPort(TextParser):
>           metadata=DeviceCapabilitiesFlag.make_parser(),
>       )
>       #:
> -    device_error_handling_mode: DeviceErrorHandlingMode = field(
> -        metadata=DeviceErrorHandlingMode.make_parser()
> +    device_error_handling_mode: DeviceErrorHandlingMode | None = field(
> +        default=None, metadata=DeviceErrorHandlingMode.make_parser()
>       )
>       #:
>       device_private_info: str | None = field(


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-09 15:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-23  7:45 [PATCH v1] dts: fix testpmd port device error handling mode Juraj Linkeš
2024-09-02 13:46 ` Luca Vizzarro
2024-09-05 16:10 ` Jeremy Spewock
2024-09-09 15:51 ` Juraj Linkeš

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).