From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23E99454B7; Wed, 26 Jun 2024 17:49:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3EA6402CF; Wed, 26 Jun 2024 17:49:38 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 62C4D402CC for ; Wed, 26 Jun 2024 17:49:38 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-713fa1aea36so3395341a12.1 for ; Wed, 26 Jun 2024 08:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719416977; x=1720021777; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HotKoThGWyhCh5jJN3sBdLnjgL+JFBb6Vh91ofSHYSc=; b=Am90fq0U84CCzATCjIkb8BFkaH57Qi8vyMbGXwj5XJQ72q4L8Knfv3Di+jolIbV8ti Z1rLQw6qJt8s0rs3XMRg6DbETEg0NgFt5maQzDkBAZq6dXoWxCJGrvf7haHF6GlANbad BVeILscUht6AW8IK68sTgMUlE8RDDhwhCt1vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719416977; x=1720021777; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HotKoThGWyhCh5jJN3sBdLnjgL+JFBb6Vh91ofSHYSc=; b=kunVCPB/qPQrbtc1Wpps/OnGb7eC6dz0dc4hKRGxjo5lkUwfXDn0syIdj2utXO8iz1 4fhZQezRBI5M4O9MaKWTovRZ7Y1LUrecxpZB7okXuxrsfe1gn4O3p34tqtoJtDTvWZaG Orxt5BkqB+1Bi8z1NMhRFWWQRgseCmEZCVf3xKwZb2zjR4o0BSwG35VMaXZ8jeNXXnIT Aebk4ucCO+6bzP4DcpEVHnVBtahFD1RBbZYPeucDNnfN9N+7pysjxmE59SZcMrfKDRRh oPGxqLWrrqq7CbwzNhuRcAlgqSkhisTmVcRP2oQLC2Ogt4otMpHC79egk6V6fIP7nJVi FOTw== X-Forwarded-Encrypted: i=1; AJvYcCXWEaUmSLu/xNPeKJyXUCn21Q+rfhBWayY+vOFrUyYTdptEB6FfjlFRJ0gTguA8hYqXHUpUA8XNR59INSg= X-Gm-Message-State: AOJu0YxSm0iGSeeuOAQQ+2loFP2oqX0XDY5/F2uUvHFEpjcp8glJrHwh rcsJ37UFNyJz9KE0rTrYKZBHqOTzUPuTE0/qUX6I1esJxE56yJCZj+G39QkXTCImMeRuXeQtfJo sB+sx9wpU+4sw8QkorZE4LtrZPTis3ylEGnelFQ== X-Google-Smtp-Source: AGHT+IHpRMXvxKJng1IuVtDojnN09v8/Yd4JyR+K63M03lAgmEpE2qp9CdbfY5Bao10lbLTX4MZPMe0E7vuBpKQ7dds= X-Received: by 2002:a05:6a20:c403:b0:1bd:25a6:842f with SMTP id adf61e73a8af0-1bd25a68565mr3865409637.41.1719416977366; Wed, 26 Jun 2024 08:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20240621172059.8194-2-npratte@iol.unh.edu> <20240621172059.8194-4-npratte@iol.unh.edu> In-Reply-To: <20240621172059.8194-4-npratte@iol.unh.edu> From: Jeremy Spewock Date: Wed, 26 Jun 2024 11:49:25 -0400 Message-ID: Subject: Re: [PATCH 1/3] dts: add boolean to adjust addresses To: Nicholas Pratte Cc: juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, yoan.picchi@foss.arm.com, dmarx@iol.unh.edu, luca.vizzarro@arm.com, bruce.richardson@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is funny because I actually ended up trying to solve the same problem when writing the dynamic queue test suite. We ended up taking different approaches, so we should probably have a discussion about the best way to handle this. Now that we have a few use cases for why this fix is needed, it will probably make the discussion easier since there is less speculation. On Fri, Jun 21, 2024 at 1:22=E2=80=AFPM Nicholas Pratte wrote: > > Various test cases in the mac filter test suite called for granular > manipulation of destination mac addresses to properly test mac address > filtering functionality. To compensate, there is now an > adjust_addresses boolean which the user can toggle if they wish to send > their own addressing; the boolean is true by default. > > Bugzilla ID: 1454 > Signed-off-by: Nicholas Pratte > --- > dts/framework/test_suite.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > index 694b2eba65..5044d5f9bb 100644 > --- a/dts/framework/test_suite.py > +++ b/dts/framework/test_suite.py > @@ -185,6 +185,7 @@ def send_packet_and_capture( > packet: Packet, > filter_config: PacketFilteringConfig =3D PacketFilteringConfig()= , > duration: float =3D 1, > + adjust_addresses: bool =3D True, This should probably get added to the Args section of this doc-string since it's a public method. > ) -> list[Packet]: > """Send and receive `packet` using the associated TG. > > @@ -199,7 +200,8 @@ def send_packet_and_capture( > Returns: > A list of received packets. > """ > - packet =3D self._adjust_addresses(packet) > + if adjust_addresses: > + packet =3D self._adjust_addresses(packet) > return self.tg_node.send_packet_and_capture( > packet, > self._tg_port_egress, > -- > 2.44.0 >