From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6177A45656; Fri, 19 Jul 2024 17:37:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AF0040EA5; Fri, 19 Jul 2024 17:37:26 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 2D2BB410D2 for ; Fri, 19 Jul 2024 17:37:25 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2cb55ff1007so1046809a91.0 for ; Fri, 19 Jul 2024 08:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721403444; x=1722008244; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5kGfYWiSiFwTxBgpsCZfQtwSwTKB2bJyyS507f3KjL0=; b=cx884J2RZUzyadrk161JgMXnt1GBrZvVeeGCFCClalFHK0D8TSx0cTixnm3/nkO4Hx hAbhEbuAd7VDZ6V7mlUqp1hje41XlWK74y/pwshzG6FBHmI6Hz/W7jMQ1vE6yMQHKDTx v4GGPjVr/PUu3hrFiAgjClkUVfgEB7/vuIzUk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721403444; x=1722008244; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5kGfYWiSiFwTxBgpsCZfQtwSwTKB2bJyyS507f3KjL0=; b=mD74DagCPjMdMyblm+90iTbtI2qQquYkcVbuKEQN1k2h0Ax8WGxzNqB4LF9Zozj9ZV Lewm4aJ6XyZWWBqFB6EzV5RQcNXx3pwrBRy/w472Y4IIBRALoWqfwSq6vez3d9lHY2Os dXonfmL5I3f998Oj1DBSxnPDDvVnpdgu7TC7VrHTD6BhbU03/iTFCpcxoGmjx2E0+zAg a/h+HiEIMqpfA4Z4lKm4gwR2qzwGn4o9/x/czefH2cth9PaQNMd1dGGsymxcIsQlVPCa lXYRmxnlnZAkkCBm+zeckOowOZp0oYaqWosFcpDffM/DIEcVw8fASaHcTTKsQRRcKrdT QqPQ== X-Forwarded-Encrypted: i=1; AJvYcCXFbrr93kT4n2oylCwXjtrpaZ/lOkoRS8+jeshB88HmuXrwnAkEgmVKHt4sT1zZ7ntElvrsn6ka6UKk/ZM= X-Gm-Message-State: AOJu0YwOeaeVWuhMB7hpVd4LYHXEm6zyS97kONMt24sWjOY39OsTK3uv O+Ot7oqhKfw45l+S7pWtRcfyCm7q2YjJ3d/5rzGKSTBkwdf0qcT9m04zic8gq3vC+WVrOJ+tAQN suCEAtnnlxpIJWpDht7CCLXdCPJMveieQRTV+9w== X-Google-Smtp-Source: AGHT+IEAG/3qTv/A8quE0bMLujKlr2Pt5THSgqsS/EWGSk5D7m+WnsLTuOYHsr9nrL3NXKBenhOC8mMnP0/PEcvz5fc= X-Received: by 2002:a17:90a:5d17:b0:2c8:da73:af7d with SMTP id 98e67ed59e1d1-2cd15e8d381mr353080a91.3.1721403444290; Fri, 19 Jul 2024 08:37:24 -0700 (PDT) MIME-Version: 1.0 References: <20240702192422.2480-2-npratte@iol.unh.edu> <20240702192422.2480-3-npratte@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Fri, 19 Jul 2024 11:37:12 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] dts: add boolean to adjust addresses To: Nicholas Pratte Cc: Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, dmarx@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 11, 2024 at 3:31=E2=80=AFPM Jeremy Spewock wrote: > > I think this change makes sense, and I mentioned this on Dean's patch > that has the same change in it but I think we should have more > discussion about which route to take with this addressing problem. It > is definitely something that we have to address since it is required > for a suite like this or any suite that operates with multiple queues > to ensure traffic is handled by the different queues. If we end up > going the boolean parameter route however, then I think this solution > looks great and it passes by my standards. > > There was one comment that I had about adding something super small to > the doc-string, but other than that the code all looked good to me. > We did end up having a discussion about this on slack and it seemed there was a slight favor towards using the method of only changing it if the user hasn't set it themselves. If you have any other thoughts on it though definitely feel free to share them!