From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B6384590E; Thu, 5 Sep 2024 17:26:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68AC242EA9; Thu, 5 Sep 2024 17:26:46 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 3B2F542E5F for ; Thu, 5 Sep 2024 17:26:45 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7c1324be8easo1513482a12.1 for ; Thu, 05 Sep 2024 08:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725550004; x=1726154804; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6CzX8To+51tYMeOdex0NgTxeX6tLCfm9su6cHSzVmAc=; b=P6xdB2geurD4RQow1VRiHdj+ndoE13k2wZhmaBEzW6ANpBXgHhDQXtIQa6lhXTVjsx WC+pPc9l+7f8yQ06M4uya/G3X8dKnUk0qahysI/wbBhM1WGv4KHrJlOhqEtWD4TL1Hyi aDA5Xar1J9NVgyd6dZQztWDtIiJ0bpjqUWy5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550004; x=1726154804; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6CzX8To+51tYMeOdex0NgTxeX6tLCfm9su6cHSzVmAc=; b=pF8zphzF2jNzivW0+zUC363PtsMNUmfzg7Kabv6IELHRSBTx1u2iN0eVvbn3NGoE+e /Z3OHQzWOBrKCsIyBd4q8wj6Fa+U7Jn+PSYvGhTvlkgFY6SJxTMKj2LtDEIYSBG5Itnj 5scvEjLMqaLtIo6PymcYzxM+hLaA1Re2Hp4s9JQ44X+KYI1Gja2ljCxuDCEtJGTwDUzc Sc2SiusTr4vnTAFAXcsDk2apmzs2alxaTQsHsgl4GFir4ZJAknLiyQJDPKnj2MjYF0Va ZpKCvqEdZ8K3CqqNQak9ViVu3KqxhTzmLy+tjF2/6dw5GODpjXVEOtIx4eOSrsgWaKzo K7/g== X-Forwarded-Encrypted: i=1; AJvYcCUiMh7eg1GX6yyeYU+vx+CGaWrltTsxNahCpIVeIhX5uFpi6MQN1T/RxD2TIVmsYRyO3SM=@dpdk.org X-Gm-Message-State: AOJu0Yw46WuTSfJR7ylsVt2AYcz+ZCz9iKSkZbSsr16hVk4XLsTgFVG+ JhULodW5hbpgPfkFWFfzqgj7hFaT4tW+fiYephXU3ruQ/+/wjSB6INOC+IzIKS4xze+UhmVtVAG u4ua6zZhAl3oZxJJfgt3NmCX2PwpFOyJGLVbREbWtgx7GKhEE1sg= X-Google-Smtp-Source: AGHT+IGoYLpStXd1UdXVOZMAgN8BUdT66jV40nmT1aLdrk1iwtqTCOHEHzi+qKQooGQYrBJFNuqx6Bpvv9yhpszNaY4= X-Received: by 2002:a17:90a:e2cf:b0:2da:8edf:ddc with SMTP id 98e67ed59e1d1-2da8f2ef51emr9639915a91.19.1725550004073; Thu, 05 Sep 2024 08:26:44 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-5-juraj.linkes@pantheon.tech> In-Reply-To: From: Jeremy Spewock Date: Thu, 5 Sep 2024 11:26:21 -0400 Message-ID: Subject: Re: [PATCH v3 04/12] dts: add mechanism to skip test cases or suites To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 5, 2024 at 5:23=E2=80=AFAM Juraj Linke=C5=A1 wrote: > >> + def _mark_results(self, result) -> None: > > > > Is it worth adding the type annotation for `result` here and to the > > other places where this is implemented? I guess it doesn't matter that > > much since it is a private method. > > > > I didn't add it precisely because it's a private method and it's pretty > self explanatory. Makes sense. > > >> + """Mark the result as well as the child result as `result`. > > > > Are these methods even marking their own result or only their > > children? It seems like it's only really updating the children > > recursively and its result would have already been updated before this > > was called. > > > > It's supposed to be just their result which is actually the result of > the children in all but the TestCaseResult classes. Conceptually, each Right, of course. Sorry, I was thinking too literally about this isolated method, with the context that that's how the result of the level itself is decided, this makes way more sense. > results level should contains these: > 1. the result of setup > 2. the result of teardown > 3. the result of the level itself (outside of setup and teardown) > > The result of the level itself is what's supposed to be set here. The > thing is we're making the child results for non-test cases and the > result of the test cases for test cases. Maybe I only need to update the > docstring. You probably don't even need to update the doc-string, this seems more like a mistake on my part :). > > >> > >> The blocking of child results should be done in overloaded m= ethods. > >> """ > > > >> >