From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD4F144104; Wed, 29 May 2024 22:40:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CECBA40649; Wed, 29 May 2024 22:40:39 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 51820402B0 for ; Wed, 29 May 2024 22:40:38 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-681953ad4f2so130032a12.2 for ; Wed, 29 May 2024 13:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717015237; x=1717620037; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x+AXcBOsPq2XCxox6Wh8x3ksMBjTdZlExpam4r1A4Fg=; b=LQhcNUMiM0Gc/C2Ov78xdBHK6ICnP0N6rhTxwx3ri3S4M6IpXaBpwlt4R/N0kC4QZ8 EeOzpO15KL+AXGSfT2wAGgJ9iUX7U2ylcumS9WGUELUVyK/kshT4KMyo8JdWKS5MqJf9 ixTd/2HYZ+jc9VU+2J6jIJg4v5q6Uo+6Xoyz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717015237; x=1717620037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x+AXcBOsPq2XCxox6Wh8x3ksMBjTdZlExpam4r1A4Fg=; b=ba9dgS71wqzh/WVV6fRL4zeVB0xJpZ9Y1dYlv4JFjBZRw1myYqdbqE30OfKWAEt465 7nhz8t69Y/Hrx00Rgh7nz4Lkpx29YpI8BWFNtQQen+0jG59QWVLCPzdEtt2o9GW3GiZc QUyWMOqXsVvKPVfXs++8vvDtE/eDirygVlqYXM0pj0D9Rq5wtS9X9zTTJt19yvHdimKp goLtQKJ6kyh02E7HwXWvldUi1LnXH4koPWqNMrgawU6U2G9BaKGl9SzWvpyp+AlmOG9i GLbdKtS1e0Sdsq4/OK4nyWzQYJOOrSHIiCR7kS6bnkWyUYwk4oq/9m7XzgYUB0uZGZcl ldeQ== X-Forwarded-Encrypted: i=1; AJvYcCX3SlpYRIfPVAChGJ2Itlb+LLi08DHe4HXxLp6pAl43lSUGMx7JYdk+9kDVhelv4uZzOjQ8gUC7Xjl1u1Q= X-Gm-Message-State: AOJu0YyUOOixU6WIL5vEXYXI1MrisBCwq1JB68+ii5coxPQUDxDr3g/W ItCWS+rR+l4Mykb1Px+QNgw8fvd72LKg96ds7qw3TDZbCMzfOVHLfkNjZh7QjN+e1eQMuMnklwI 9kVcaRDj1xK9MiS8QRRGvaXHwmRNFlwItWlnMUw== X-Google-Smtp-Source: AGHT+IFrsebsV/+znzjIJHZFbqL90GKNe/FCfQm+sADOGveJJfE0OwFZKPp9esWWf5ecQTE1WKv3ohzUxZW6bTir+PE= X-Received: by 2002:a17:90a:fe82:b0:2c1:5e90:1ee4 with SMTP id 98e67ed59e1d1-2c1abc6f88cmr202117a91.36.1717015237484; Wed, 29 May 2024 13:40:37 -0700 (PDT) MIME-Version: 1.0 References: <20240514201436.2496-1-jspewock@iol.unh.edu> <20240514201436.2496-5-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Wed, 29 May 2024 16:40:26 -0400 Message-ID: Subject: Re: [PATCH v1 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter To: Luca Vizzarro Cc: yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, wathsala.vithanage@arm.com, thomas@monjalon.net, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 20, 2024 at 1:56=E2=80=AFPM Luca Vizzarro wrote: > > On 14/05/2024 21:14, jspewock@iol.unh.edu wrote: > > + # adjust the MTU of the SUT ports > > + testpmd.set_port_mtu(0, 9000) > > + testpmd.set_port_mtu(1, 9000) > > should you perhaps do this for every port in the testpmd shell instead? > > for port_id in range(testpmd.number_of_ports): > testpmd.set_port_mtu(port_id, 9000) This is a good thought. I was sort of falling back on the current assumption that we can only support 2 ports per server in test suites, but there is nothing that ensures these ports are the first and second in trestpmd. I think it is probably safer to just modify the MTU of all ports that testpmd knows of since we just blindly pick the ingress and egress ports we want to use. I didn't want to at first since the ideal would be that we have minimal side effects in testing suites so we wouldn't want to just change the MTU of all ports, but if there comes a time when this matters in the future (the only one I could really think of is implementing parallel testing) then we can just limit what ports are in the scope of testpmd. > > > testpmd.stop() > > + # reset the MTU of the SUT ports > > + testpmd.set_port_mtu(0, 1500) > > + testpmd.set_port_mtu(1, 1500) > > As above >