From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 839994403B; Wed, 15 May 2024 21:23:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35495402BE; Wed, 15 May 2024 21:23:34 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 631984021D for ; Wed, 15 May 2024 21:23:32 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-65894e58b8aso169983a12.0 for ; Wed, 15 May 2024 12:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1715801011; x=1716405811; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cDBjChBpZuZEnKG29wL+PjP9qpNhYzpVKOeH6KYouUY=; b=ioTIRKw/ebQkhP/0RjRQ4k17F7VgmE7azoHffQ+iSMapZJXVyIU9ax4ZvVN8wLTsJ4 xJDX9QGFuC3pr8dK4w7UDN/nqNF96vm1mwUN7g9n6/T8Y03v2MZxwEAKHABfTnG04cXM 3r+AF7ZyWb3xKMXfx8ZTK4fqvAFPovToydipc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715801011; x=1716405811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cDBjChBpZuZEnKG29wL+PjP9qpNhYzpVKOeH6KYouUY=; b=b8O51VdiRWOYDU4OuJ1NSBU0x6tdeSzSB1ecdO7PC6mqLv8bIrRtr0p0SitUBz+UV9 T5xi1MFkyykMJdPKcCfHZ7ur4LcDHHvKJo+ZeBTslpNNtiXMZgmdGJWnx0BNdQnTQdje O/xO+kubwFiUT/KvuXHG0NEyUTP5ALWofC4XVRh7YzC4m6/uCgFPfyEUKcdUCfDjyJ77 fKJQt175MEElI5IVmCNt7+gDtE534VM0vxjnzo02+XJiR4ePvDMivQr++rZ3RUdZn663 5Va5unzzbd9hHcRIEV0Bf8K6J1TQCwgzn1GqhaBTVW7TpMBQi83G1FrvQMUuaX5iK76C lZgQ== X-Forwarded-Encrypted: i=1; AJvYcCXjR4HzKfcavZ6OlQ27VfwhM+xUxAOAGf9nbT10q8lavThKTzX++qjM+yGtG9PbwOPxGsxjlQ1auNbjzF8= X-Gm-Message-State: AOJu0YymbZ5oFVsqtgTwn43W4FSgre+Lzlb9EsKW3euIGYNSS5DX8FKd xfUDP8F9iKG+Y511sOLghwzHJLIcRhUCXFSRWEwFvnPoQzUr6X+vRxI56Vn81AmU9wW0hEyEr4y qBho+Ba5nBriPg9vJvCp7LLkRGUw5XqsTtiFkuQ== X-Google-Smtp-Source: AGHT+IFr0ragXhDlmXtvwmhxCEJKweqQuxGnGEcsE8O6TBZlZlXQ1hshBpGnlEQ6BhWbYA75du2BmuaF8L5UEyKitR0= X-Received: by 2002:a17:90b:3118:b0:2b2:c2dd:9cb0 with SMTP id 98e67ed59e1d1-2b6ccd85e94mr13285899a91.43.1715801011458; Wed, 15 May 2024 12:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20240312172558.11844-1-jspewock@iol.unh.edu> <20240501161623.26672-1-jspewock@iol.unh.edu> <20240501161623.26672-4-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Wed, 15 May 2024 15:23:20 -0400 Message-ID: Subject: Re: [PATCH v2 3/3] dts: Improve logging for interactive shells To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, probb@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 13, 2024 at 11:03=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > Good idea. And again, with the one minor point below, > Reviewed-by: Juraj Linke=C5=A1 > > > diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/fr= amework/remote_session/interactive_shell.py > > index 0b0ccdb545..eb9c9b6843 100644 > > --- a/dts/framework/remote_session/interactive_shell.py > > +++ b/dts/framework/remote_session/interactive_shell.py > > > @@ -91,7 +92,7 @@ def __init__( > > self._stdout =3D self._ssh_channel.makefile("r") > > self._ssh_channel.settimeout(timeout) > > self._ssh_channel.set_combine_stderr(True) # combines stdout = and stderr streams > > - self._logger =3D logger > > + self._logger =3D get_dts_logger(f"{interactive_session._node_c= onfig.name}.{name}") > > We should make interactive_session._node_config public since we're > referencing it outside the class. good point, I'll make this change as well. > > > self._timeout =3D timeout > > self._app_args =3D app_args > > self._start_application(get_privileged_command)