From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4F59457A1; Mon, 12 Aug 2024 17:30:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A07240B99; Mon, 12 Aug 2024 17:29:58 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id BC2544065F for ; Mon, 12 Aug 2024 17:29:57 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7c3e0a3c444so1083885a12.1 for ; Mon, 12 Aug 2024 08:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1723476597; x=1724081397; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gJbrmXoWxxM99/ZBkR/y6Hmnr1bNCDrmsmoErrsX5gw=; b=TeHguVnFVg0LnH3WaihAL5V7SP7fuQRaFGTyySFxNZxFf0IfGlCAokHD8QuJSL/joe VOt4NlFOIA0J9cXRwPfzMgJMQw9b1cyKUihR14Nc018xkLaqwrRiV/TGzITSFVeBTpkg 05u2pxBiqMkQJu6kCt8yTYyBJKc7QlaZZVkew= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723476597; x=1724081397; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gJbrmXoWxxM99/ZBkR/y6Hmnr1bNCDrmsmoErrsX5gw=; b=FtXwo30hFSVdrTroXJopbOimvwvOvMjVkacfMDVy9FVtLB/pxYVJK5qC9d2D34JVz+ NQ4qdvVWO1YD3pvEersWqDz6kCRx/YGQ/TRSMXNlrgC/drs02yGVKedjYsEEMzgxzH28 cpl11TyVBRnFP5CiLqSPHyLGfkbg0/8yP/6RKKzA5WwB9KZhNbLp1ZB7wX8kzV1Jj/KU 5UrgspO9rOk7PxP33V5+B7/rAc1zLfJBjEXqqyx90iAo1VzQegkEY6LCqmZvoCoaN+1I e0bt1mMrXF2qz08155Y/sTqDA9nzLtnArFqn3FjxVJjRqYwky93UMhcMpqVwHWzNiinX y5IQ== X-Forwarded-Encrypted: i=1; AJvYcCVobxgWtMz+8Jq8wno/0JAAzRSVoj3cl78+t0KCQJElcrWk+mBCg1Z+hcjxPs8M6LtBcvovY4TygwVBbso= X-Gm-Message-State: AOJu0YzdpYSYA5hEZdm75RWa9cOfMSqLiP9ROWgLe+cy5LPoOjBt+d08 KkmO43cHRcoZysn2I8a40Yyr1jn1rmBWOWjbNahr5SoIgqTV59q6pnFT7YEPPsuhXUjkXxBFTef rDryFBlZdGEuPILBQ3MsN/7prwvlfiKG+Ca52rw== X-Google-Smtp-Source: AGHT+IHiVm9c7yRaPyWE1rW1ein5UIMfyxf7McptECN0fK50F2dghy4DRbGpFLisRYZqpjM6TGn063UMdPVszEONhWk= X-Received: by 2002:a17:90a:420e:b0:2cb:4b31:1c48 with SMTP id 98e67ed59e1d1-2d392aef207mr701802a91.22.1723476596779; Mon, 12 Aug 2024 08:29:56 -0700 (PDT) MIME-Version: 1.0 References: <20240812142355.12532-1-dmarx@iol.unh.edu> In-Reply-To: <20240812142355.12532-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Mon, 12 Aug 2024 11:29:45 -0400 Message-ID: Subject: Re: [PATCH v1] dts: add verify argument to set forward mode To: Dean Marx Cc: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 12, 2024 at 10:23=E2=80=AFAM Dean Marx wrot= e: > > Add optional verify argument to the set_forward_mode > method in testpmd shell. > > Signed-off-by: Dean Marx The patch all looks good to me, but it might be beneficial to add a "fixes" tag as well as a "bugzilla ID" tag to the commit body. The DPDK contribution guidelines explains how to format the tags [1] and also which order they should appear in [2]. [1] https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related= -issues [2] https://doc.dpdk.org/guides/contributing/patches.html#tag-order > 2.44.0 >