From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DB4343EC3; Tue, 16 Jul 2024 17:07:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF74440BA6; Tue, 16 Jul 2024 17:07:50 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 45C25406B4 for ; Tue, 16 Jul 2024 17:07:50 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fb3b7d0d56so30758095ad.1 for ; Tue, 16 Jul 2024 08:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721142469; x=1721747269; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dRVu17JWJ9X9lCYymBx7ct7dLVdCFlS4RTlS2YK7L08=; b=cCmxDlLa7eHJ/F+CTpOWsQUOBhTl3ROzTOqX042NRc0YDFry261+3wMCd0YM2DaPYw C66UNYL0dm/qttAzpz2VFTF1tRd6xueOIDFYOeRARVz+TKFTNm7mhmW680RcNmgDMnUg X8HfBcsZwNLaNatYMoBuhL6NSFTsg0SNIahis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721142469; x=1721747269; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRVu17JWJ9X9lCYymBx7ct7dLVdCFlS4RTlS2YK7L08=; b=Dke5A/s/vlKEXiVgScvs/ZrAiLbw/8sCzq3ZCkHVxsivSeGs+Aj36XT9ZiNudStDop gtp2/ENzY5j9zgdb2WWXAd7YplOoWXpw3lg+vbrS4lUUwEU1Wy0x8hSegCndh+3QeCXW tRuc/axcKyKAJgqYzCwegku0h+1XY/mm/RHJ+3jib5ELWuF46PlbSXXDwe0CDjkrhr2y J80GiEX1ndCY0DmEiP2QpwStPE9xhOyzHDdgkNx+jxXZqr9ICgTfhSr2b0mDXyFNfAjd LXgEESXsi7sR9qHOaiH6+Gb4EWOSrUfT0yer+c952CNioy+FV0SsdO1DWe0G79BxuOuo ZkJw== X-Forwarded-Encrypted: i=1; AJvYcCVYPCaBjQOjaV3cZchcT6MZi1tipd3myqUgtC37dzqn5vhylDKZFiVsiZkvU8NIutmccnzjlYLvLG8EqO0= X-Gm-Message-State: AOJu0Yzhw3jAO8lpuqPH5+kd4oipQcH1EnP+LdpMA1qT0glLu3L7X6b6 sEma9ELZjNW4w5fIBybw7Iik5Sko5rpk8OzNZ4iZnXnPRQhws/s/KaaC3Qy2ZC/lQbVyWzOkTlx q4fnqBLa3HBKnbMbczcIaxD4PfXCql+UJe+j2Ng== X-Google-Smtp-Source: AGHT+IEKbxUTYTBnsVsK2v8Rz5j0LznolaR4xchTW5UYWvvbn8y+hXnDDnFiBtloGcFSp57f8SKLxaWVGCA81B0Cqqk= X-Received: by 2002:a17:90a:17a4:b0:2ca:4a6f:280c with SMTP id 98e67ed59e1d1-2cb37494d85mr1868039a91.41.1721142469020; Tue, 16 Jul 2024 08:07:49 -0700 (PDT) MIME-Version: 1.0 References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-4-npratte@iol.unh.edu> In-Reply-To: <20240705171341.23894-4-npratte@iol.unh.edu> From: Jeremy Spewock Date: Tue, 16 Jul 2024 11:07:37 -0400 Message-ID: Subject: Re: [PATCH v2 1/6] dts: Remove build target config and list of devices To: Nicholas Pratte Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 5, 2024 at 1:15=E2=80=AFPM Nicholas Pratte wrote: > > Remove the list of devices from the schema, as these are unuesed. > Likewise, removed build-target information since these is not currently > used, and it is unlikely to be used in the future. Adjustments to the > dts.rst are made to reflect these changes. > > Bugzilla ID: 1360 > Signed-off-by: Nicholas Pratte > --- > @unique > class Compiler(StrEnum): > r"""The supported compilers of :class:`~framework.testbed_model.node= .Node`\s.""" > @@ -341,28 +325,20 @@ class BuildTargetConfiguration: > The configuration used for building DPDK. > > Attributes: > - arch: The target architecture to build for. > - os: The target os to build for. > - cpu: The target CPU to build for. > compiler: The compiler executable to use. > compiler_wrapper: This string will be put in front of the compil= er when > executing the build. Useful for adding wrapper commands, suc= h as ``ccache``. > name: The name of the compiler. > """ > > - arch: Architecture > - os: OS > - cpu: CPUType > compiler: Compiler > compiler_wrapper: str > - name: str > > @classmethod > def from_dict(cls, d: BuildTargetConfigDict) -> Self: > r"""A convenience method that processes the inputs before creati= ng an instance. > > - `arch`, `os`, `cpu` and `compiler` are converted to :class:`Enum= `\s and > - `name` is constructed from `arch`, `os`, `cpu` and `compiler`. > + `compiler` is converted to :class:`Enum`\s Because it's only the one attribute now this should likely just be "`compiler` is converted to an :class:`Enum`" and because you don't need this \s, I think you can also remove the "r" from the start of the doc-string that makes it a string literal. > > Args: > d: The configuration dictionary. > @@ -371,12 +347,8 @@ def from_dict(cls, d: BuildTargetConfigDict) -> Self= : > The build target configuration instance. > """ > return cls( > - arch=3DArchitecture(d["arch"]), > - os=3DOS(d["os"]), > - cpu=3DCPUType(d["cpu"]), > compiler=3DCompiler(d["compiler"]), > compiler_wrapper=3Dd.get("compiler_wrapper", ""), > - name=3Df"{d['arch']}-{d['os']}-{d['cpu']}-{d['compiler']}", > ) > > >