From: Jeremy Spewock <jspewock@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: probb@iol.unh.edu, juraj.linkes@pantheon.tech,
thomas@monjalon.net, wathsala.vithanage@arm.com,
paul.szczepanek@arm.com, npratte@iol.unh.edu,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
Luca.Vizzarro@arm.com, dev@dpdk.org
Subject: Re: [PATCH v1 2/3] dts: add dual_vlan testing suite
Date: Wed, 31 Jul 2024 09:54:02 -0400 [thread overview]
Message-ID: <CAAA20UStB09kT4BhUYyU=CR-Mia+Wf+Nxv0ORcn7uJH-SF0sqg@mail.gmail.com> (raw)
In-Reply-To: <CAAA20UT86d0CB_F9cJFBkCKj47Z73yU+KQfxUyrLhaRUnFfo-A@mail.gmail.com>
On Thu, Jul 25, 2024 at 9:56 AM Jeremy Spewock <jspewock@iol.unh.edu> wrote:
>
> On Mon, Jul 22, 2024 at 1:38 PM Dean Marx <dmarx@iol.unh.edu> wrote:
> >>
> >> <snip>
> >> + recv = self.send_packet_and_capture(pakt)
> >> + self.verify(len(recv) > 0, "Did not receive and packets when testing VLAN priority.")
> >
> >
> > I'm assuming this should say "any" instead of "and." Other than that, everything looks good to me.
> >
>
> Good catch, I'll fix this in the next version.
Circling back on this, it looks like this is fixed in the current version.
>
> > Reviewed-by: Dean Marx <dmarx@iol.unh.edu>
next prev parent reply other threads:[~2024-07-31 13:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 19:58 [PATCH v1 0/3] dts: add test suite for dual VLANs jspewock
2024-07-15 19:58 ` [PATCH v1 1/3] dts: fix Testpmd function for resetting VLAN insertion jspewock
2024-07-15 19:58 ` [PATCH v1 2/3] dts: add dual_vlan testing suite jspewock
2024-07-22 17:38 ` Dean Marx
2024-07-25 13:56 ` Jeremy Spewock
2024-07-31 13:54 ` Jeremy Spewock [this message]
2024-07-15 19:58 ` [PATCH v1 3/3] dts: add dual_vlan test suite to the yaml schema jspewock
2024-07-16 21:24 ` [PATCH v2 0/2] dts: add test suite for dual VLANs jspewock
2024-07-16 21:24 ` [PATCH v2 1/2] dts: add dual_vlan testing suite jspewock
2024-08-07 19:07 ` Dean Marx
2024-07-16 21:24 ` [PATCH v2 2/2] dts: add dual_vlan test suite to the yaml schema jspewock
2024-07-24 17:13 ` [PATCH v3 0/2] dts: add test suite for dual VLANs jspewock
2024-07-24 17:13 ` [PATCH v3 1/2] dts: add dual_vlan testing suite jspewock
2024-08-13 19:47 ` Dean Marx
2024-09-12 3:46 ` Patrick Robb
2024-07-24 17:13 ` [PATCH v3 2/2] dts: add dual_vlan test suite to the yaml schema jspewock
2024-08-13 19:48 ` Dean Marx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAA20UStB09kT4BhUYyU=CR-Mia+Wf+Nxv0ORcn7uJH-SF0sqg@mail.gmail.com' \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).