From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AA2945701; Wed, 31 Jul 2024 15:54:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC367410F9; Wed, 31 Jul 2024 15:54:15 +0200 (CEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id EF8454065A for ; Wed, 31 Jul 2024 15:54:14 +0200 (CEST) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2cb5e0b020eso4438729a91.2 for ; Wed, 31 Jul 2024 06:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1722434054; x=1723038854; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lHOAPu+I1Kl4ZQAzWLqf2EVF+X7lWfCOald+eBAaXmc=; b=Z4Lo3YYOd4m2f0NwlxXRz7aXWaoMCBsbTemrdB3/9utRVQ9FxtJsfFyffReA5gs4zK JjTsPt8wfpyGDeDyYTh32H7W18tY+7C6shTFmg/YzUoaPOAez7hOt64ltOtkxCxVTPCg xN3Z11ZzEeun+EdQ70yusQl2wDcxwV4vZyVHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722434054; x=1723038854; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lHOAPu+I1Kl4ZQAzWLqf2EVF+X7lWfCOald+eBAaXmc=; b=Gq0iWtLquvBxYgo9AVqbQeV78lSaclpB58LE+EsmLvOnujg5+OH86rq0gjgWpFVm2S aRhzhoKha6nn75HGzMoD5+6gEIt1EXb3zbTnzI7csYJPZmcMo5xaez+EOKW3iQuOgYjX BuOZ8wH6t2Jxi00UgnhNk5hGfZHG+4fY60Fq4/lmwRx/AkINRricNN8mkMngVZDgvb67 egMP9Au7H1beYX8Wt3aweqhcndJYOZCzoHYk+YGUvQI1qf6X6qi8LwZSu/OtRz74vaub Cz5P40a3MzKR7DleLTzJ8aD+6s1VXJhkiUpDbtm31VZG2jq28+wFNTeBr06JbQK3sbhE 6Obg== X-Forwarded-Encrypted: i=1; AJvYcCX0joxtZgOdVl2YxPwiNSD25iCqb6Uu5of6FjgCqBXQTuVEapD2/qc/N4+RjLMJB7U8z3R0agbkIMOO6MA= X-Gm-Message-State: AOJu0YyqulS6ICzOjRBmC/UIvDEwTk+HLdf+BrDzwXiRfFiGLgpSeVTc +mCz5MeDdQgmfDo5FWZegySNDtD0nMI5SfgCrIqj8UEut5jo73uMayOnYlwE+mT4ebzwKT/JZdh kj5sbhQfDP07YXlnm8wa9JU5c6G2vIT4nO6SjQQ== X-Google-Smtp-Source: AGHT+IFCr6hC3chm/ne3Gn8H+n6u4uykCF293j7l2ZkOdO/3/K23zze1WJ75L0Cuz0UiuIqcL9NCBTCMS0ut5xzsJyg= X-Received: by 2002:a17:90a:f188:b0:2c9:6a2d:b116 with SMTP id 98e67ed59e1d1-2cf7e19e1cbmr16152386a91.7.1722434053878; Wed, 31 Jul 2024 06:54:13 -0700 (PDT) MIME-Version: 1.0 References: <20240715195852.254033-1-jspewock@iol.unh.edu> <20240715195852.254033-3-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Wed, 31 Jul 2024 09:54:02 -0400 Message-ID: Subject: Re: [PATCH v1 2/3] dts: add dual_vlan testing suite To: Dean Marx Cc: probb@iol.unh.edu, juraj.linkes@pantheon.tech, thomas@monjalon.net, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, npratte@iol.unh.edu, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, Luca.Vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 25, 2024 at 9:56=E2=80=AFAM Jeremy Spewock wrote: > > On Mon, Jul 22, 2024 at 1:38=E2=80=AFPM Dean Marx wro= te: > >> > >> > >> + recv =3D self.send_packet_and_capture(pakt) > >> + self.verify(len(recv) > 0, "Did not receive and packets when = testing VLAN priority.") > > > > > > I'm assuming this should say "any" instead of "and." Other than that, e= verything looks good to me. > > > > Good catch, I'll fix this in the next version. Circling back on this, it looks like this is fixed in the current version. > > > Reviewed-by: Dean Marx