From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F2A345656; Fri, 19 Jul 2024 17:37:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AD634111C; Fri, 19 Jul 2024 17:37:48 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id A32ED40E5A for ; Fri, 19 Jul 2024 17:37:47 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-6bce380eb96so1334372a12.0 for ; Fri, 19 Jul 2024 08:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721403467; x=1722008267; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lExXbevsXP64jHmCAgHHTK4km7YWybnqbg7D28+aDzQ=; b=VmBVMEyK5TOiwjPc2BmNyzXazfweHjbdOMNXrMLkmG8Yhqk6xjU5xxIQwviTvLES4a y25ZzKeUV0YJPL1Wg1VU9y00ML+LNzTjpHwvZO7MVj90EOFa2e6wNAxWhIzhq5kvBTJF ozF6F2nU0U10AO2qKQ10r53hrIU0PMKBQMWnU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721403467; x=1722008267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lExXbevsXP64jHmCAgHHTK4km7YWybnqbg7D28+aDzQ=; b=gDeuarz29qlhj8qMFmNVaYJS4meFfF8NCmy1Q9o8K9MAWamUt5Ae9Ze0Y1dSAsk0c5 g5ssOVpV8+t/00WaU4uJ5wOMFgmrVJFtLmKaIqW09zQowXXWZa1wFAITkebjfqlay0BI DIFjkPxBlI63rnT2h7Uqv1z7njefVNWHHjYeE4C6IIlSxim6v8s0blSc1fu7kfIgJALt ZvFCHDBJ4c0aYPO8PNJl58WmoYA0WWkO6NEhLcu3ngbGcQEU2aoPfvRy8CNTxReyZtea Skjq6EswCWihkgnld/tRxUXD1EvGvRtgKL6bPq/ZH2kQhJfNkFwE7csD4kYh44peCILo cRLw== X-Forwarded-Encrypted: i=1; AJvYcCVU7wPMLxsGO+iQIoiuYpCbY2+xTfx3rIZrrnHupnz83+Tc9hroIC1epwrqKWJPQJUBrtufx+hnqMA+cHo= X-Gm-Message-State: AOJu0YwNGLSW6HEtjirovBEkHLf/I/Rvi/GwYQnPamnQDGoDQLb6QbFo OuvStqnsnsyDsVL9M8K3OygBcdb8meXadl3oSKNbrkuO8RpT8A7Up0G2ONcB4SEb/714L0koEis AJ6ZaujYe260VTe3IX2wJ8EJpfXXFC3Dns+SUSQ== X-Google-Smtp-Source: AGHT+IHDdZjvomjuY/l19DhwPpJVW5uoghSDsjLzp2MXsH9NCBrWRICX6rDzsPQ7vEBg3sUcuIaAAIOR4N8oAV7yPV4= X-Received: by 2002:a05:6a21:6d96:b0:1c3:a55f:6ba3 with SMTP id adf61e73a8af0-1c3fdd52294mr9749067637.50.1721403466741; Fri, 19 Jul 2024 08:37:46 -0700 (PDT) MIME-Version: 1.0 References: <20240702192422.2480-2-npratte@iol.unh.edu> <20240718190509.4203-1-npratte@iol.unh.edu> <20240718190509.4203-3-npratte@iol.unh.edu> In-Reply-To: <20240718190509.4203-3-npratte@iol.unh.edu> From: Jeremy Spewock Date: Fri, 19 Jul 2024 11:37:35 -0400 Message-ID: Subject: Re: [PATCH v3 2/3] dts: add methods for setting mac and multicast addresses To: Nicholas Pratte Cc: probb@iol.unh.edu, paul.szczepanek@arm.com, luca.vizzarro@arm.com, Honnappa.Nagarahalli@arm.com, dmarx@iol.unh.edu, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 18, 2024 at 3:12=E2=80=AFPM Nicholas Pratte wrote: > > Several new methods have been added to TestPMDShell in order to produce > the mac filter's individual test cases: > - set_mac_addr > - set_multicast_mac_addr > - rx_vlan_add > - rx_vlan_rm > - vlan_filter_set_on > - vlan_filter_set_off > - set_promisc > > set_mac_addr and set_multicast_addr were created for the mac filter test > suite, enabling users to both add or remove mac and multicast > addresses based on a boolean 'add or remove' parameter. The success or > failure of each call can be verified if a user deems it necessary. > > The other methods listed are implemented in other respective test > suites, and their implementations have been copied, but are subject to > change; they are not the focus of this patch. > > Bugzilla ID: 1454 > Signed-off-by: Nicholas Pratte > --- All looks good to me, there were just a few places that I noticed things had been changed in the VLAN suite that should probably get moved into here (like the removal of separate methods for turning filtering on and off, for example). Otherwise: Reviewed-by: Jeremy Spewock