From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B15A45602; Thu, 11 Jul 2024 21:31:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66C2B402B3; Thu, 11 Jul 2024 21:31:42 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 073724026F for ; Thu, 11 Jul 2024 21:31:41 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-70b0e7f6f8bso1135213b3a.3 for ; Thu, 11 Jul 2024 12:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1720726300; x=1721331100; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=q8yxTwllLDtapxd9JTMEYNCK/9N5JvWoGJt3W/TC9kw=; b=VzNqjnVOqtZAbfUJvu+gIBQaa+ps/vopmt3Eu9kCOGtnrjDtqC5+1QTH/rCiOCayQQ PaN/zPbOJD5okz+yz08w00b84O21OEtd7ws3G5mOK+f3daEiANOZ2UPe+uJA+KAGWpUX eTXpPMETS6/XfDS4h3HCzuiT9V2cLOt1xWrTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720726300; x=1721331100; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q8yxTwllLDtapxd9JTMEYNCK/9N5JvWoGJt3W/TC9kw=; b=VF3heuInpPOkaR/8K71xiaYx5u4B5kEHbo7bN4WJhyzN1REny3ReyCJN8kAigPDLS/ cwLJygx1b8NSiQ0oVaYKOpI2w7YahA0PuCCAQS1RY+VwLyVJN3ZqWO4gOf1IgWfe70n5 G1VHu1lKQ8aEqlUXGDsblqHYZcmPWJVii32XCxhNaUPx0MrXjB+dIiSBfuhIbF0mgMPj H+wS3Fu3VyTvU2825TJ5I2Qa4m8oUuwhwN6BeXxZcV+cegzJ0gXqdrEHaaiegRJ6aFnN p/OFnz1PQ6y93F0cwYiEQ4sHmgUk51qY//NuJSlDSrMbYuD9t7XzwleEz6IgbU9Ax5Wa n7qw== X-Forwarded-Encrypted: i=1; AJvYcCXbChFU3xvZYz23SWpqp3B7g6dBxg3netGz7wEOJd8Ench36QK5kHsuSJv/qoYPwU4tf/JMpWjedZoLvdI= X-Gm-Message-State: AOJu0YzN8jF9K0A0As4NjvYvUe4oIqIKeD+XAlRvlWIdVIBNc0R4YUt6 1doCqsRkrff44iWRECMtrZi/SljGljVCRhoqn4B1nnrMInEkdDBOWypVmRLrCmDOBnFXT5eBu7J FMA2OesqEZs4e6jlaP+3COCPqNYYqMnTW9XIpMd1YUjnm73rA X-Google-Smtp-Source: AGHT+IFVZnfuMPpPCMvcUZkYiFDguYnfjfl0I0BeLU5loSkUNSDzjjtqh9Q9zPwU7jP9d2CaqfhamFDOrBgbJsNinUY= X-Received: by 2002:a05:6a21:9997:b0:1c2:92ad:3331 with SMTP id adf61e73a8af0-1c2980f943dmr11630012637.2.1720726299622; Thu, 11 Jul 2024 12:31:39 -0700 (PDT) MIME-Version: 1.0 References: <20240702192422.2480-2-npratte@iol.unh.edu> <20240702192422.2480-3-npratte@iol.unh.edu> In-Reply-To: <20240702192422.2480-3-npratte@iol.unh.edu> From: Jeremy Spewock Date: Thu, 11 Jul 2024 15:31:28 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] dts: add boolean to adjust addresses To: Nicholas Pratte Cc: Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, dmarx@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I think this change makes sense, and I mentioned this on Dean's patch that has the same change in it but I think we should have more discussion about which route to take with this addressing problem. It is definitely something that we have to address since it is required for a suite like this or any suite that operates with multiple queues to ensure traffic is handled by the different queues. If we end up going the boolean parameter route however, then I think this solution looks great and it passes by my standards. There was one comment that I had about adding something super small to the doc-string, but other than that the code all looked good to me. On Tue, Jul 2, 2024 at 3:25=E2=80=AFPM Nicholas Pratte wrote: > > Various test cases in the mac filter test suite called for granular > manipulation of destination mac addresses to properly test mac address > filtering functionality. To compensate, there is now an > adjust_addresses boolean which the user can toggle if they wish to send > their own addressing; the boolean is true by default. > > Bugzilla ID: 1454 > Signed-off-by: Nicholas Pratte > --- > dts/framework/test_suite.py | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > index 694b2eba65..551a587525 100644 > --- a/dts/framework/test_suite.py > +++ b/dts/framework/test_suite.py > @@ -185,6 +185,7 @@ def send_packet_and_capture( > packet: Packet, > filter_config: PacketFilteringConfig =3D PacketFilteringConfig()= , > duration: float =3D 1, > + adjust_addresses: bool =3D True, > ) -> list[Packet]: > """Send and receive `packet` using the associated TG. > > @@ -195,11 +196,15 @@ def send_packet_and_capture( > packet: The packet to send. > filter_config: The filter to use when capturing packets. > duration: Capture traffic for this amount of time after send= ing `packet`. > + adjust_addresses: If :data:'True', adjust addresses of the e= gressing packet with > + a default addressing scheme. If :data:'False', do not ad= just the addresses of > + egressing packet. It might also be worth naming what the default is in the doc-string (by which I mean that the parameter defaults to True, not the default address scheme). > > Returns: > A list of received packets. > """ > - packet =3D self._adjust_addresses(packet) > + if adjust_addresses: > + packet =3D self._adjust_addresses(packet) > return self.tg_node.send_packet_and_capture( > packet, > self._tg_port_egress, > -- > 2.44.0 >