From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 558774571A; Fri, 2 Aug 2024 15:40:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4294242E5C; Fri, 2 Aug 2024 15:40:26 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 5388040E20 for ; Fri, 2 Aug 2024 15:40:25 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2cb56c2c30eso2405223a91.1 for ; Fri, 02 Aug 2024 06:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1722606024; x=1723210824; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lxfavhAafC1bH2txrYkyHYSnAP7Nk+soXH2SOxxpUWg=; b=bDUc2OnWA1jubAx17JWw9GzMHZt6B6+lDufXaKc/O+93YseATO8sayyI0ptqiAicyC u6X4l0rn/25yFSOqUAsFXfeveMA45H/NAS8m1rBV+X37vSDG+V24opwKP4titByvHFSr 3q/OkEG9TmZ1XeTfDyB1eEWoF38OICXu6DQcg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722606024; x=1723210824; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lxfavhAafC1bH2txrYkyHYSnAP7Nk+soXH2SOxxpUWg=; b=gFq6JOOdQ60lA082d97FMPLppw+kYRRrAkpUUrjstl4nMkVcKPBVbtp3v2NYOldbBQ 3PBKPmSNZ3k0gvS08DOKhi6pOKBffXX3hFkwRmiwIM1kD+gmqquteq5VP0lVBOB6DdT8 S/3XNoJaNOiSlFQXTHnGsyTL4+w0pMUft+R+r+2fbdIbLn5QB7aXZWKfbGOO4dgjtF7g R3/ydAG8XOLY98nZz8mngZaY3qx3QJYUrDSYrjdYgUx+J1Td422dpfqgRJYmCBj3Y7yP vD/kn0zDbcwWPEiMKwV5kd0ofZ/LtlE3khyFyOzv6wSzmkdsjt3LWaVDeXY2aoaIw3Eu NWaQ== X-Forwarded-Encrypted: i=1; AJvYcCV3FMx2Up8PkxxHh0S196/QEXnBn2dMgYXK3LtPOjYdJtkBguNSbxl1wRF8AYByv2tZGM5HIuH7oV6AWMs= X-Gm-Message-State: AOJu0YxUgeBr0/bfpiBSMSrmiudTcSrha3RcZsB/r5o/bFyvjJw2Ab29 SOYX6wn4DpME+r02vefN7oWZCwvRjRjdOjc9WuG+xAyOjxIhwk0XY2YswzJPmy49cGIEyF+RT3p YN6uQmAtrNOBwhPkonCCE/JEDCS0BBks8GYIUrA== X-Google-Smtp-Source: AGHT+IEJSttSfLI6fXxXOl9hVS+fQKFnYz9iqa7yg/JE9urZ2dV8o8/QcRn8YkDQiwsgqJ7p/MQcBQ96NbjkEzTwLBg= X-Received: by 2002:a17:90a:4701:b0:2c9:6753:6192 with SMTP id 98e67ed59e1d1-2cffa200b9emr5928190a91.12.1722606024311; Fri, 02 Aug 2024 06:40:24 -0700 (PDT) MIME-Version: 1.0 References: <20240729203955.267942-1-jspewock@iol.unh.edu> <20240730133459.21907-1-jspewock@iol.unh.edu> <20240730133459.21907-2-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Fri, 2 Aug 2024 09:40:12 -0400 Message-ID: Subject: Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output To: Luca Vizzarro Cc: yoan.picchi@foss.arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 1, 2024 at 4:43=E2=80=AFAM Luca Vizzarro wrote: > > On 30/07/2024 22:33, Jeremy Spewock wrote: > > On Tue, Jul 30, 2024 at 9:37=E2=80=AFAM wrote: > > > >> +class VerboseOLFlag(Flag): > >> + """Flag representing the OL flags of a packet from Testpmd verbos= e output.""" > >> + > >> + #: > >> + RTE_MBUF_F_RX_RSS_HASH =3D auto() > >> + > >> + #: > >> + RTE_MBUF_F_RX_L4_CKSUM_GOOD =3D auto() > >> + #: > >> + RTE_MBUF_F_RX_L4_CKSUM_BAD =3D auto() > >> + #: > >> + RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN =3D auto() > >> + > >> + #: > >> + RTE_MBUF_F_RX_IP_CKSUM_GOOD =3D auto() > >> + #: > >> + RTE_MBUF_F_RX_IP_CKSUM_BAD =3D auto() > >> + #: > >> + RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN =3D auto() > >> + > >> + #: > >> + RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD =3D auto() > >> + #: > >> + RTE_MBUF_F_RX_OUTER_L4_CKSUM_BAD =3D auto() > >> + #: > >> + RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN =3D auto() > >> + > > After reading more of the API and using this patch to write a test > > suite, I believe there is more expansion of these OL flags that should > > take place. For starters, there are the Tx OL flags that, while not > > seeming to be very useful for the current test suites we are writing, > > wouldn't hurt to also include as they seem to be fairly different. > > Additionally, there are some other less common RX OL flags that should > > be included here just to cover all options. I will work on adding > > these into the next version. > > If you wanted to cover even more, hw_ptype and sw_ptype look like they > could use a data structure. I reckon a flag like the above would also wor= k. Ack, it's probably worth making those a little more structured as well. >