From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33D5A456A7; Thu, 25 Jul 2024 15:58:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B09F441101; Thu, 25 Jul 2024 15:58:29 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 5E90F40648 for ; Thu, 25 Jul 2024 15:56:51 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2cb4b7fef4aso715037a91.0 for ; Thu, 25 Jul 2024 06:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721915810; x=1722520610; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XHo5D/d13m+k7sY8yfgj+Rqyue8vjprRsCGJyxM7R+E=; b=WiYSk4MNzzBDfRQrCCMu6PM7POd5LpA0pg9hvr01appVImnE+doeUn1nMNwLr/2/+G xF3OWACvEMvVDBXFC0PDr/pe/3c59FQaNh3wNaTtKyvrnmwVuVRcchvnds75bbfYg4Pb Lq816e/E+6E4M9PkOBxZ7SAa+UJqN8K3mpAQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721915810; x=1722520610; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XHo5D/d13m+k7sY8yfgj+Rqyue8vjprRsCGJyxM7R+E=; b=uNysybiDe6BN89hMb+VyRL8o4+dUQ+IOGjDqSb3W72wvJHjYN/Dsid1iSjrB785B2e sHan7v0p39+uuPiT+ygcXAcmDykNp+mlaeVQR/rdR4W6Ubw0VlqQu8Bb2RCBal54O8Yb dqbt5atyYS1O3XAIkMu1m/fJfxcmTy8TnYlUvpto9U1Ycy7ofQP+ZgZh+zIktG8CPzUW C1xW2GNIkFKTiA4/0Zv4OLrEoNauDEpOuzHJlhGJbsG5G/vU/Vvrbv5gpVskJjSeZRNz 6tJataFW3fA7C+w3UNg7OVQp5PlWxbe7Z1IDa4+Vecert8uBUK+D3xn2OA9QmEoBoa04 5lVw== X-Forwarded-Encrypted: i=1; AJvYcCWG9jX0OidH48yW/1NZV3tlV5GGwhME9PNDRS2VCfDvhuA8iChrATux2coqAN6hVws5jxFHNJJONPEXNDY= X-Gm-Message-State: AOJu0YwHpJHw9nYPlYOn+gD0eohQGissCRs9vCZbnbrdJ1A29D911Gqm e9JZA7HIBCBNgjEVblOrHnEyjCN/joGf7cFnvP4NGz2z5NTcpaF+2cMSkyc6tXiteflrRoDiv5J wR10TXI9O8gyIZX6bpT85/xDcCH+MajzVelJxrg== X-Google-Smtp-Source: AGHT+IFbzm+/f2z0N/8Zt5sDTWAt11A9n5M4e8UUcZG7D76FqElQQrKIIj1UnlY3LvvrOGZ+67jHdgzgUZEOrHwhS7A= X-Received: by 2002:a17:90a:ac06:b0:2ca:8baf:abe9 with SMTP id 98e67ed59e1d1-2cf2ec146e1mr1791764a91.40.1721915810120; Thu, 25 Jul 2024 06:56:50 -0700 (PDT) MIME-Version: 1.0 References: <20240715195852.254033-1-jspewock@iol.unh.edu> <20240715195852.254033-3-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Thu, 25 Jul 2024 09:56:38 -0400 Message-ID: Subject: Re: [PATCH v1 2/3] dts: add dual_vlan testing suite To: Dean Marx Cc: probb@iol.unh.edu, juraj.linkes@pantheon.tech, thomas@monjalon.net, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, npratte@iol.unh.edu, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, Luca.Vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 22, 2024 at 1:38=E2=80=AFPM Dean Marx wrote= : >> >> >> + recv =3D self.send_packet_and_capture(pakt) >> + self.verify(len(recv) > 0, "Did not receive and packets when te= sting VLAN priority.") > > > I'm assuming this should say "any" instead of "and." Other than that, eve= rything looks good to me. > Good catch, I'll fix this in the next version. > Reviewed-by: Dean Marx