From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B3AC45460; Fri, 14 Jun 2024 20:28:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7880E41149; Fri, 14 Jun 2024 20:28:03 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 7091E4060B for ; Fri, 14 Jun 2024 20:28:02 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-704261a1f67so1903570b3a.3 for ; Fri, 14 Jun 2024 11:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718389681; x=1718994481; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q4cgdJ6+4m8EzjCxcuBm7xlNZrWCej8m81UTfEISUMI=; b=KevTchLcVkB0IvQX/g0DeLwORZuPIObO0Zeuky/t/1sAAMx6EzlFiJVrJ9vV1kmcgj cBsY6AqTUv7aP5B5yr1bYr58flqyCcW5g9ABZp68kjW9mOq2k+1nnLsf0RKZJ7Ey6mSr 0FyqhFydL2NNT5iU1uXC69LVBTI+MaeSjTXSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718389681; x=1718994481; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q4cgdJ6+4m8EzjCxcuBm7xlNZrWCej8m81UTfEISUMI=; b=ec/jFw2vmk8YpjTczov6YB0Z1H7Qgowh2WHHdjIqiY7vKikw7nMIP84MAJAqy4X/O9 301NEeV8LTyiXtlRZO15TbdYmvzHDfqU+szlUjgIqcMX1kWGx9dLtYQCY/DWWg0b3bBl LiTb131/mK1Mgh6D5iEuSO+Wb/0ovvmndSEjLSrA7KQupYqms7Sb6jSwgnOBEuMFjVyH ukPSKe1Oxn1yGObPcMJVNQoRUoaNx+QcFBvhqp1iuDUoIkYkAo8/pFLY369df3MZ7qes aJX5FFquHT3SIk7G0M3MpGSt1gBGJgbyhklMClbV9Q18/9i86COubUp0LBbM3pl/+Emu Yr8g== X-Forwarded-Encrypted: i=1; AJvYcCU0WnMdHfTJzwfXe/em5q5SYMeqgcIdsGFJYu4d/6hkZ2n9rlWj9Gc78kCyIBpfs/z4ykEd8s/XuOTvTys= X-Gm-Message-State: AOJu0YwHcV0jYJDtjJZa9qSE/IukBN0+O5/BvtJsY9X3mlG7t4vt9uo6 Dt12rS11Nt2zPYqTjqo9g6yO01VdWcicjfps19rs7Ks8G6yGwtb+2VL7LHCBE4tZnHidQCGYoCX ooRVBgT0OV4rA8/8U1OMp5P5hnQvYOUuXjSGxwJPOyo5xSFmR X-Google-Smtp-Source: AGHT+IEv54WvuIZDmAR4IFbCaU2LY3NRSU8vWOOi0OcVuJVi619XPyX4FGTtsNH8is6TR/40cI5RpG2qVWBA8zdQ1YQ= X-Received: by 2002:a05:6a20:cf8b:b0:1b7:bdb3:7bc9 with SMTP id adf61e73a8af0-1bae7f0c22amr3910547637.30.1718389681544; Fri, 14 Jun 2024 11:28:01 -0700 (PDT) MIME-Version: 1.0 References: <20240610193410.17968-2-npratte@iol.unh.edu> In-Reply-To: <20240610193410.17968-2-npratte@iol.unh.edu> From: Jeremy Spewock Date: Fri, 14 Jun 2024 14:27:50 -0400 Message-ID: Subject: Re: [PATCH v1] dts: Testbed And Node Configuration Split To: Nicholas Pratte Cc: luca.vizzarro@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, bruce.richardson@intel.com, yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, Honnappa.Nagarahalli@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I think this is definitely a step in the right direction in terms of how we structure the config files. Something that I think could also be a cool improvement for how we handle configs is just making a `conf/` directory and then taking all of the configuration in each of the yaml files present in the directory and combining them into one config in the framework like we have now. That's definitely a larger undertaking however, this split will save space if users want to specify more than one host or use the same execution configuration between different node configurations and I think that is an improvement on its own. On Mon, Jun 10, 2024 at 3:34=E2=80=AFPM Nicholas Pratte wrote: > > This implementation splits the execution and node configuration > components of the conf.yaml into two separate config files. A > new command line argument is added, allowing the user to specify > both a node configuration file and an execution configuration > file. Be default, these config files are now named node_conf.yaml and > execution_conf.yaml, respectively. > > To assert these changes, the schema calls for one of these objects, > nodes or executions, in each file, but neither config file can have > both. > > To avoid excess refactoring, both config files are merged together > early on in the load_config process. > > Bugzilla ID: 1344 > > Signed-off-by: Nicholas Pratte > --- > diff --git a/dts/testbed_conf.yaml b/dts/testbed_conf.yaml > new file mode 100644 > index 0000000000..af2180eac2 > --- /dev/null > +++ b/dts/testbed_conf.yaml I don't think this file is used anywhere and it looks like another name for the execution_conf.yaml so we likely don't need it. > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2022-2023 The DPDK contributors > +# Copyright 2023 Arm Limited > + > +executions: > + # define one execution environment > + - build_targets: > + - arch: x86_64 > + os: linux > + cpu: native > + # the combination of the following two makes CC=3D"ccache gcc" > + compiler: gcc > + compiler_wrapper: ccache > + perf: false # disable performance testing > + func: true # enable functional testing > + skip_smoke_tests: false # optional > + test_suites: # the following test suites will be run in their entire= ty > + - hello_world > + - os_udp > + # The machine running the DPDK test executable > + system_under_test_node: > + node_name: "SUT 1" > + vdevs: # optional; if removed, vdevs won't be used in the executio= n > + - "crypto_openssl" > + # Traffic generator node to use for this execution environment > + traffic_generator_node: "TG 1" > \ No newline at end of file > -- > 2.44.0 >