From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBF034586E; Mon, 26 Aug 2024 18:56:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7835940698; Mon, 26 Aug 2024 18:56:33 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id BA79D400EF for ; Mon, 26 Aug 2024 18:56:32 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7cd9cfe4748so2759425a12.2 for ; Mon, 26 Aug 2024 09:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724691392; x=1725296192; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KgWvltNxZsjIPkkqT7Z/3ZK8+s/6ErTuVKKrVo1Jr5U=; b=D46iMEiS/nCSoMXrHOfTESjzHM9949ZMnWixU1aBHC6DoayNeVjz6BsPKP+cEgVHqs Eh0hfiww1auLNNBp0ypvVW5n9Y0EqY1x0d8SbHov6CsalPBysJ3NIn6HYxBwsAdg4su0 3iu6kh0oD6NeAdHzdCJKoVZ3Y6bd90QZ1y6uk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724691392; x=1725296192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KgWvltNxZsjIPkkqT7Z/3ZK8+s/6ErTuVKKrVo1Jr5U=; b=ZPRYFB2I0/bXktGK/m9ATgMqhcIDFYyU27pDSi2sRsNrmrDbLqtVLdF9U787NaRIuo 5e4I0i4kRCwOjB8OGGCXa6PstobO3jRWzP4F8TRuUAOGxsxn43tFPQdpOjv1NG2hGWm7 KSe08g7j+lDHpi5RtKEcF79zoY7u4PzwbYEQISb4t0PwnXK/wfBcY2Rd89Hh6VRPdyW7 XnInYt/6udQrUooaCF7ulFHlPC50Aj2QDxrpl5+swie1hPd0IDFLctVjAHjDni86Z7Q+ bslxOENspDxGBvAhCwr+omzMdO3tlabb30TlL0cvX2PrRJRtfYSR4UActqsbEDF0SRdT N6sA== X-Forwarded-Encrypted: i=1; AJvYcCVuhzXunEgogJyXSYPdJANJtjTXU8zwmKEWsWM5jvNuP9xI90TK5+4oYCZEdj42XA7NhMU=@dpdk.org X-Gm-Message-State: AOJu0Ywd4Gs8CUUsuPQHBMF0dJOMfuSIxvXOds7zWxkpdwxt1Dfqp0L+ x3Aq9XJclI5x0MI2Dn/mlJfHSTYQ7T5GJ5G/iyfKNAX0mgFAN2X2KjQQQisErMcHR/1DdhZTlVB 2Q72e38KHUQMTIPp8yPtg6uxTmPP0lFfU3kEWBA== X-Google-Smtp-Source: AGHT+IEP4g/bm5udf5F7bK95bC4wlC3OUoK+4+rg2+J3/KX5T+DBpKu61UUONq9QlkTDgRMSdbUGqpaP1uYJ+jmGs1g= X-Received: by 2002:a17:90b:3852:b0:2d3:db91:ee82 with SMTP id 98e67ed59e1d1-2d646d59aa1mr8771829a91.40.1724691391737; Mon, 26 Aug 2024 09:56:31 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-7-juraj.linkes@pantheon.tech> In-Reply-To: <20240821145315.97974-7-juraj.linkes@pantheon.tech> From: Jeremy Spewock Date: Mon, 26 Aug 2024 12:56:20 -0400 Message-ID: Subject: Re: [PATCH v3 06/12] dst: add basic capability support To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Just one comment about adding something to a doc-string, otherwise looks good to me: Reviewed-by: Jeremy Spewock On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM Juraj Linke=C5=A1 wrote: > diff --git a/dts/framework/test_result.py b/dts/framework/test_result.py > index 306b100bc6..b4b58ef348 100644 > --- a/dts/framework/test_result.py > +++ b/dts/framework/test_result.py > @@ -25,10 +25,12 @@ > > import os.path > from collections.abc import MutableSequence > -from dataclasses import dataclass > +from dataclasses import dataclass, field > from enum import Enum, auto > from typing import Union > > +from framework.testbed_model.capability import Capability > + > from .config import ( > OS, > Architecture, > @@ -63,6 +65,12 @@ class is to hold a subset of test cases (which could b= e all test cases) because > > test_suite_class: type[TestSuite] > test_cases: list[type[TestCase]] > + required_capabilities: set[Capability] =3D field(default_factory=3Ds= et, init=3DFalse) This should probably be added to the Attributes section of the doc-string for the class. When it's there, it might also be useful to explain that this is used by the runner to determine what capabilities need to be searched for to mark the suite for being skipped. The only reason I think that would be useful is it helps differentiate this list of capabilities from the list of required capabilities that every test suite and test case has. > + > + def __post_init__(self): > + """Gather the required capabilities of the test suite and all te= st cases.""" > + for test_object in [self.test_suite_class] + self.test_cases: > + self.required_capabilities.update(test_object.required_capab= ilities) >