From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E5A845626; Mon, 15 Jul 2024 22:22:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FF6640DCE; Mon, 15 Jul 2024 22:22:39 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 366A94065F for ; Mon, 15 Jul 2024 22:22:38 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-706a1711ee5so3173669b3a.0 for ; Mon, 15 Jul 2024 13:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721074957; x=1721679757; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YHcLQ4kaK0sUXHpCAfNm2HaOLoQfn9kVm7TLLsgFbrE=; b=Ai0hSEW58oxO5kW5ppHc8omW+L+iOEc8wXmZ/uvxFYOht1rw5WCrf+h/+YlMI+uzcr n0/ObJYJPwESpprfD1jrFcubCFF66MYWuR+yPMwzMJoQJsbdtn64785C6VG3AdMihRTS Crs3LPUyGHH/vh2NttdoxUrX9p0A9uZL+z2ZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721074957; x=1721679757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YHcLQ4kaK0sUXHpCAfNm2HaOLoQfn9kVm7TLLsgFbrE=; b=sWM+PBE6yU838q+GATwnDIklzhRgPclI9+GVyCQGT6JRt0N8jCqkdTQyXpfpOguO+s BsdpqhIFF8xueTql/hC3OVRf/Bb4kv+bC7iZ/d3vhHr+wrWAfjLsY8mibnpLtflEkKB3 dEa1XNRgDLcq0IodJBgdfsZuHb+VwAlukJD2RYRdNTG4ST9B0t06cAiWkCiYh51vxkhz Oi5KtQbl14u24SSESytplcq/LWhmgchUBhqIxgYs0JTn9TVQocrenCPuO+DcLbCj9cGo cqe+YGrJJc62ZkSqvWVDVdZ6GIqs1OSQdle7eLRtIRw5j48zy5af7Vkitqdk1K8bJvxc PsWA== X-Forwarded-Encrypted: i=1; AJvYcCW1ZuY+3YVKdlRTRjQf8NaFJgnkPbybX07mPD13hqTtEIDLxvzlmYURXodZadgIE6hVSngxY/zcZv5lHrI= X-Gm-Message-State: AOJu0YyHr1vV8MYnHqxPS90TTQdD3F8AIt85jcyRSEjeua+owQo7fdW9 BjZW00BLg7trYI0dDkvIE+sesnOf2BQpPDyndKY8mUTEdXn6w4UVysKgao5R8NzxTEDgNPP9cQV A9Q5Dd3crvK7oKz4PqyvsiPZtpYof7akZAO0J0Q== X-Google-Smtp-Source: AGHT+IGlkWSh1OhXt3BrIqVwcejIDQ3NHolqRo0fuUbJUwbRFjZ4EhjH7FDgJ0QMJV63MaVDdJeUrcLqgd4AvcXGEyo= X-Received: by 2002:a05:6a00:4fcb:b0:706:6f18:839d with SMTP id d2e1a72fcca58-70c1fbdc744mr237942b3a.14.1721074957202; Mon, 15 Jul 2024 13:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20240708191938.32132-1-dmarx@iol.unh.edu> <20240715160021.23352-1-dmarx@iol.unh.edu> In-Reply-To: <20240715160021.23352-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Mon, 15 Jul 2024 16:22:26 -0400 Message-ID: Subject: Re: [PATCH v4 1/3] dts: add multicast set function to shell To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 15, 2024 at 12:00=E2=80=AFPM Dean Marx wrot= e: > > added set multicast function for changing allmulticast mode within testpm= d. > > Signed-off-by: Dean Marx > --- I still think this patch would benefit from my above comments about modifying the method signatures and using show_port_info_all(), but it looks good to me otherwise.