From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41CE145906; Wed, 4 Sep 2024 23:19:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E579B42D45; Wed, 4 Sep 2024 23:19:03 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 886BC42D35 for ; Wed, 4 Sep 2024 23:19:02 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2053a0bd0a6so970495ad.3 for ; Wed, 04 Sep 2024 14:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725484741; x=1726089541; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1yHbAzXoCjyWlx/4qyd0Yy74MijjQewlJh+nclNqq7A=; b=dORt0Ce81y9F/C+Y5YVZ3QVK3c+jTTqRq23Z5HHiYdUnpJ3+3chTGoQOv9E5vAVLD+ n3R0Z1ceXOB+R9GUR+k5m2WaGr5p/+i1thdWVLKRPmFe1HwdrIviMW+vME2eATjYRtCa 93Bv68+UtwH5+xOy00yRppwmJHyPhYL39Wy9g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725484741; x=1726089541; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1yHbAzXoCjyWlx/4qyd0Yy74MijjQewlJh+nclNqq7A=; b=uJyA4awOTmoaJBcXb7VM5o+YRKX03xcO484P99D5HfgfCwCPpPj0HV5qQdt0BhWjpY v1n8r2AAAFu3U00c1JWMTX7v6foxNRROShZDYTx6iidkCmmZ//zkZGKp9VcSZPE8Je8v gxqMEsvsVADYoHBjNilKF1U+7I1iNBYJj/t+mlrogioxCa5qC5XJ2HRFSTv4QrTWcANx vxADsbbcLSEAd2+A50FGJlNkNWWfmKAbF79qY12k7RY3j7tVZ7lHMPKnq+euGlJcP+jc pVaM5yMN2HWLEtvpmP62I3pXtqqmWQW34Hp8g4s7S9KXh97csfLLgUxQy2RYTpQpRzqC Ahdg== X-Forwarded-Encrypted: i=1; AJvYcCUiCIrvbIIhmpFNJcN9Mxytush/Lp7KRBuWVB+ZcbJxWO9xjQudZRD8f4/1ufrkOWExahQ=@dpdk.org X-Gm-Message-State: AOJu0YxzycvSyq45PnhAFGPMM8M3uEVRyhFEc3eYpynX9q8EDziVC0pd Qurm2/CyuBUcUSgC9n8wJhEaD9Qx24UNRMTq99CS7ow752Xct3LsCGyG8qi2zcFidSxEI7HEyqZ +8uMVp4PLpo6SAQuapxZy0ZSZTeedIxhyvO8OXA== X-Google-Smtp-Source: AGHT+IHyAN6a+L6VnoPJ+hw5jJS3pSKnqtAZ8vRseY2moDDGspHlzK+9tEZJkFJGt7V09o1Cu1WxLrxfJwNS1XUV3Wo= X-Received: by 2002:a17:902:e891:b0:205:7c76:4b2c with SMTP id d9443c01a7336-20699b21bc6mr77355355ad.48.1725484741622; Wed, 04 Sep 2024 14:19:01 -0700 (PDT) MIME-Version: 1.0 References: <20240821162550.1163-1-dmarx@iol.unh.edu> <20240826212250.26993-1-dmarx@iol.unh.edu> <20240826212250.26993-3-dmarx@iol.unh.edu> In-Reply-To: <20240826212250.26993-3-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Wed, 4 Sep 2024 17:18:49 -0400 Message-ID: Subject: Re: [PATCH v3 2/2] dts: checksum offload test suite To: Dean Marx Cc: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Just one comment here but it is a super small doc-string thing that still passes the formatting script and everything, but whenever we add Ruff for checking format in the future, it would get caught so it might be better to just add it now. Otherwise: Reviewed-by: Jeremy Spewock On Mon, Aug 26, 2024 at 5:22=E2=80=AFPM Dean Marx wrote= : > + def setup_hw_offload(self, testpmd: TestPmdShell) -> None: > + """Sets IP, UDP, TCP, and SCTP layers to hardware offload.""" Since this is a public method and it also has an argument, I think that it should follow the Google doc-string format and have an Args: section for it. > + testpmd.port_stop(port=3D0) > + offloads =3D ( > + ChecksumOffloadOptions.ip > + | ChecksumOffloadOptions.udp > + | ChecksumOffloadOptions.tcp > + | ChecksumOffloadOptions.sctp > + ) > + testpmd.csum_set_hw(layer=3Doffloads, port_id=3D0) > + testpmd.port_start(port=3D0) > + >