From: Jeremy Spewock <jspewock@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech,
probb@iol.unh.edu, paul.szczepanek@arm.com,
yoan.picchi@foss.arm.com, bruce.richardson@intel.com,
luca.vizzarro@arm.com, dev@dpdk.org
Subject: Re: [PATCH v5 1/3] dts: add functions to testpmd shell
Date: Wed, 10 Jul 2024 11:36:49 -0400 [thread overview]
Message-ID: <CAAA20UTeVrdyC5x7ufc4=P7FDE36dP0EdPP_PCEaM+2wLtQLLw@mail.gmail.com> (raw)
In-Reply-To: <20240703180820.18723-1-dmarx@iol.unh.edu>
All of the code here looks good to me, if you end up putting in a new
version for adding the comment that I mentioned on the other commit it
might be worth changing the name of this commit again to something
like add queue functions to testpmd, but I'm not sure this is super
critical since you explain them in the body of the commit. Otherwise:
Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
next prev parent reply other threads:[~2024-07-10 15:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 19:46 [PATCH v2 0/3] dts: queue start/stop suite Dean Marx
2024-06-17 19:46 ` [PATCH v2 1/3] dts: initial queue start/stop suite implementation Dean Marx
2024-06-21 21:27 ` Jeremy Spewock
2024-06-17 19:46 ` [PATCH v2 2/3] dts: added promisc/verbose func to testpmd shell Dean Marx
2024-06-21 21:28 ` Jeremy Spewock
2024-06-17 19:46 ` [PATCH v2 3/3] dts: queue suite conf schema Dean Marx
2024-06-21 21:28 ` Jeremy Spewock
2024-06-21 21:27 ` [PATCH v2 0/3] dts: queue start/stop suite Jeremy Spewock
2024-06-26 13:51 ` [PATCH v3 1/3] dts: initial queue start/stop suite implementation Dean Marx
2024-06-26 13:51 ` [PATCH v3 2/3] dts: add functions to testpmd shell Dean Marx
2024-06-26 19:51 ` Jeremy Spewock
2024-06-26 13:51 ` [PATCH v3 3/3] dts: queue suite conf schema Dean Marx
2024-06-26 19:51 ` Jeremy Spewock
2024-06-26 19:50 ` [PATCH v3 1/3] dts: initial queue start/stop suite implementation Jeremy Spewock
2024-06-28 16:19 ` [PATCH v4 1/3] dts: add functions to testpmd shell Dean Marx
2024-06-28 16:19 ` [PATCH v4 2/3] dts: initial queue start/stop suite implementation Dean Marx
2024-07-01 20:17 ` Jeremy Spewock
2024-06-28 16:19 ` [PATCH v4 3/3] dts: queue suite conf schema Dean Marx
2024-07-01 20:17 ` [PATCH v4 1/3] dts: add functions to testpmd shell Jeremy Spewock
2024-07-03 18:08 ` [PATCH v5 " Dean Marx
2024-07-03 18:08 ` [PATCH v5 2/3] dts: initial queue start/stop suite implementation Dean Marx
2024-07-10 15:36 ` Jeremy Spewock
2024-07-03 18:08 ` [PATCH v5 3/3] dts: queue suite conf schema Dean Marx
2024-07-10 15:37 ` Jeremy Spewock
2024-07-10 15:36 ` Jeremy Spewock [this message]
2024-07-10 16:01 ` [PATCH v6 1/3] dts: add functions to testpmd shell Dean Marx
2024-07-10 16:01 ` [PATCH v6 2/3] dts: initial queue start/stop suite implementation Dean Marx
2024-07-11 13:58 ` Jeremy Spewock
2024-07-10 16:01 ` [PATCH v6 3/3] dts: queue suite conf schema Dean Marx
2024-07-11 13:59 ` [PATCH v6 1/3] dts: add functions to testpmd shell Jeremy Spewock
2024-07-17 20:23 ` [PATCH v7 " Dean Marx
2024-07-17 20:23 ` [PATCH v7 2/3] dts: initial queue start/stop suite implementation Dean Marx
2024-07-19 13:34 ` Jeremy Spewock
2024-07-23 17:04 ` Adam Hassick
2024-07-17 20:23 ` [PATCH v7 3/3] dts: queue suite conf schema Dean Marx
2024-07-19 13:34 ` Jeremy Spewock
2024-07-19 13:34 ` [PATCH v7 1/3] dts: add functions to testpmd shell Jeremy Spewock
2024-07-24 18:32 ` [PATCH v8 0/3] dts: refactored queue start/stop suite Dean Marx
2024-07-24 18:32 ` [PATCH v8 1/3] dts: add functions to testpmd shell Dean Marx
2024-07-26 19:19 ` Jeremy Spewock
2024-07-24 18:32 ` [PATCH v8 2/3] dts: initial queue start/stop suite implementation Dean Marx
2024-07-26 19:19 ` Jeremy Spewock
2024-07-24 18:32 ` [PATCH v8 3/3] dts: queue suite conf schema Dean Marx
2024-07-26 19:19 ` Jeremy Spewock
2024-08-07 19:36 ` [PATCH v9 0/2] dts: refactored queue start/stop suite Dean Marx
2024-08-07 19:36 ` [PATCH v9 1/2] dts: add functions to testpmd shell Dean Marx
2024-08-09 15:51 ` Jeremy Spewock
2024-08-07 19:36 ` [PATCH v9 2/2] dts: initial queue start/stop suite implementation Dean Marx
2024-08-09 15:52 ` Jeremy Spewock
2024-10-08 21:48 ` [PATCH v10 0/1] dts: port over queue start/stop suite Dean Marx
2024-10-08 21:48 ` [PATCH v10] " Dean Marx
2024-11-18 19:59 ` [PATCH v11] " Dean Marx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAA20UTeVrdyC5x7ufc4=P7FDE36dP0EdPP_PCEaM+2wLtQLLw@mail.gmail.com' \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).