DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jeremy Spewock <jspewock@iol.unh.edu>
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: paul.szczepanek@arm.com, luca.vizzarro@arm.com,
	juraj.linkes@pantheon.tech, dmarx@iol.unh.edu,
	yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
	 probb@iol.unh.edu, dev@dpdk.org
Subject: Re: [RFC v1 1/1] dts: split enums from primary json schema
Date: Fri, 9 Aug 2024 11:43:57 -0400	[thread overview]
Message-ID: <CAAA20UTnL9xPtSj1ZnDj=n+p+o2TyM-cBX1vgHA0OUY1NycSZA@mail.gmail.com> (raw)
In-Reply-To: <20240807140831.27558-3-npratte@iol.unh.edu>

Hey Nick,

Thanks for the patch. The way you did things all makes sense to me and
I like the idea of pulling out the definitions to make things more
compact in the main schema, the one thought I did have though was that
it isn't immediately obvious in the main schema where these values are
coming from. Because they just reference a $defs key that doesn't
exist in this file, there is no reference to something like "hey, go
look here for the definitions." Unfortunately, because it's JSON, you
also can't just leave a comment, so I guess the best we can do is just
make sure to document it well. I wonder if there is a way though that
you can have the paths for the references reference other files. I'm
sure you would have looked into that already, but that probably would
fix the confusion problem, and it stops you from having to recombine
manually.

<snip>

  reply	other threads:[~2024-08-09 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 14:08 [RFC v1 0/1] dts: separate allowed values from " Nicholas Pratte
2024-08-07 14:08 ` [RFC v1 1/1] dts: split enums from primary " Nicholas Pratte
2024-08-09 15:43   ` Jeremy Spewock [this message]
2024-08-07 15:01 ` [RFC v1 0/1] dts: separate allowed values from " Luca Vizzarro
2024-09-10  9:34   ` Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAA20UTnL9xPtSj1ZnDj=n+p+o2TyM-cBX1vgHA0OUY1NycSZA@mail.gmail.com' \
    --to=jspewock@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=juraj.linkes@pantheon.tech \
    --cc=luca.vizzarro@arm.com \
    --cc=npratte@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).