From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EC734577A; Fri, 9 Aug 2024 17:44:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41F074327F; Fri, 9 Aug 2024 17:44:11 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id B7F384025F for ; Fri, 9 Aug 2024 17:44:09 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2d1c1fb5cafso1547091a91.2 for ; Fri, 09 Aug 2024 08:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1723218249; x=1723823049; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bxAXNzI9eBbScVZjIaKtWABNBD3G/L7KvarQfXB35gE=; b=LiXvs8jtNWh8ihZWjXM2qrCt9XH6eTyPUp3q5/odpPI4wrfPoJ/ULAZYo29zf2V1QQ Fogqq/5Tl7mCZcWjquhDxxfem1l/nTU48mBrHFpp4IllHVD2V5+o3XO2KNGSMItDehYD 8IEJGhTMopzvfhSwlTgE+MME+xCDqmlF7jlXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723218249; x=1723823049; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bxAXNzI9eBbScVZjIaKtWABNBD3G/L7KvarQfXB35gE=; b=CMBJ7Ttn0qQ3awmyROMNhFxulxo0/uAFKXzkqL7K6iHrwkP5tR9t+ewOOa2rE3usWQ hueCsH88Ym+fn+6/TgZV4PflTMooOt/UzX+9BgU9BDP9z7PF3662qZgstIYSWVcOB9HM 54PMnu0nvFNAyDTjxdLnTQheg5xanNeyjabHXoEC53m8Y25DA0gqdtmtyAhaqM2uD9Qk cQX/aIx3NdMBCscbSAWr30yVhXiVgYGHqSb+eW7WsrrwOIsp3rLygawteQlg4Lx7LEBQ WAQzKYtceHc8vUFXmskPiuaBapCjoDSQnorqVG3G0+8vZF7Tu8EaNK2qzQVwSP7XpbeH GalQ== X-Forwarded-Encrypted: i=1; AJvYcCURMB4tm8RPbBYH+fM9UToNc5IPjNVbm4pj+76SVbQW7OICILh08rrFRjiJ04rTZTKqQqU4amWBfamKm0I= X-Gm-Message-State: AOJu0YzSm3WhmUQ1KZhD+/Z0C0ean13iDyUjPy42DctRrGGERvERcyCr CeiHpKgBL8oQ3EGqf15FpM6cjAUw4l78gu3u2RsdNPIy9iCZ2+j0GQ0vnMeBqz+SFTGNMc4XKxW d9P0g+bL8XnV7kOaSBTreA3NN6efkbgACpWZaSQ== X-Google-Smtp-Source: AGHT+IEWW/wEYBakeuvca8hft/VpDl0Hb/RhUkH/SxQl1iH9LXWTxbU8OvTNcEIwncX7i+BPYJjJbB+brn0oTl9Wm1Y= X-Received: by 2002:a17:90b:4f8b:b0:2cf:db0e:89f6 with SMTP id 98e67ed59e1d1-2d1e80a7573mr1810362a91.41.1723218248670; Fri, 09 Aug 2024 08:44:08 -0700 (PDT) MIME-Version: 1.0 References: <20240807140831.27558-2-npratte@iol.unh.edu> <20240807140831.27558-3-npratte@iol.unh.edu> In-Reply-To: <20240807140831.27558-3-npratte@iol.unh.edu> From: Jeremy Spewock Date: Fri, 9 Aug 2024 11:43:57 -0400 Message-ID: Subject: Re: [RFC v1 1/1] dts: split enums from primary json schema To: Nicholas Pratte Cc: paul.szczepanek@arm.com, luca.vizzarro@arm.com, juraj.linkes@pantheon.tech, dmarx@iol.unh.edu, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hey Nick, Thanks for the patch. The way you did things all makes sense to me and I like the idea of pulling out the definitions to make things more compact in the main schema, the one thought I did have though was that it isn't immediately obvious in the main schema where these values are coming from. Because they just reference a $defs key that doesn't exist in this file, there is no reference to something like "hey, go look here for the definitions." Unfortunately, because it's JSON, you also can't just leave a comment, so I guess the best we can do is just make sure to document it well. I wonder if there is a way though that you can have the paths for the references reference other files. I'm sure you would have looked into that already, but that probably would fix the confusion problem, and it stops you from having to recombine manually.