From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 018704578F; Fri, 23 Aug 2024 16:54:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2F2E432FC; Fri, 23 Aug 2024 16:54:09 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id A3D4C432F6 for ; Fri, 23 Aug 2024 16:54:08 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2d5f5d8cc01so1490207a91.0 for ; Fri, 23 Aug 2024 07:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724424848; x=1725029648; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2QyiogzYJh9QJO3iZRybUlQI4XPHUIpmEw6ETJKcA6U=; b=jI3a95kkT1JgEPrOvUeb3IQdWwZ3iLB+3EfeK/hgd2dcNStXuIX034zARKEF1o5shN uEW6ZD3TJspej9y0xwETngtBND8Qof+OTgHz4uqkfxCOV7aYvuyejsK/ruxKvxX1WEQQ iHPm/+FMUjIXFa2Rw673fop3uFAZpju6vQo5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724424848; x=1725029648; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2QyiogzYJh9QJO3iZRybUlQI4XPHUIpmEw6ETJKcA6U=; b=UCCGmp3YsvPyVDK7vH8gL6PgTqW1jcKP2wr1A6+vFYddTk2ZZhwRaeYDouDCLm6JV8 y+KWCHTE3qaopzFMhUSsW7YBoYruDBlStgLRluH+l/syHBSsHAXpZMx5Jox/hzAOuIsC rcFpt4/bk2+fjzD23+wiv8vQvkW5+zDWe4fUDfY8ZGS6fXz5XFHiqtpECYqxvK9GQxzZ +Mfjfos+QRhBlFyOEXEHKoXcK6VEqIh/CpzDEN4eOI9D6h7w/AV33qM9ud70eH+tHNwm TfH+Xe+dUa6io1+ftTKFUlQeeHVuK77Sg7Iu6GSBUyREP6bvoitT8zGQA4IejU8NRJu0 ZF6A== X-Forwarded-Encrypted: i=1; AJvYcCUL2NHId5zv9UlR1agxFV0vZ8neFGA8Bz+YC3oi6jiozZG8c5E1zQnQ1LCotOsN/l6XKTk=@dpdk.org X-Gm-Message-State: AOJu0YxUvye6dRKAwtll38nLbeUiYnil2nwTvZSNKCjEILpaLgza2fn6 bXBOft+IHvd/mxalncWYAvcf2yzcXa46n7m1tNA/zwMNFkb7K+Q+tnLYpVm/y0nq0jHuz/sLH+B ulfCgU7eW5thgBm+ljNeZlM1LMiMWjBx0xFEogw== X-Google-Smtp-Source: AGHT+IHOhofoQ7wScrFQQS6MLELqhsZ1HKlKCvsiSzhEyJOUJizLTNOohsiiIP/CT93x9S8HwexeeiiyYmnkSo5yY1w= X-Received: by 2002:a17:90a:fa49:b0:2d4:902e:ca3f with SMTP id 98e67ed59e1d1-2d644af820emr4407500a91.19.1724424847493; Fri, 23 Aug 2024 07:54:07 -0700 (PDT) MIME-Version: 1.0 References: <20240816142031.15150-1-dmarx@iol.unh.edu> <20240821162550.1163-1-dmarx@iol.unh.edu> In-Reply-To: <20240821162550.1163-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Fri, 23 Aug 2024 10:53:56 -0400 Message-ID: Subject: Re: [PATCH v2 0/2] dts: port over checksum offload suite To: Dean Marx Cc: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hey Dean, Thanks for the series! Looks good to me in general, I just left some comments with a few thoughts I had about some ways to potentially move some stuff around or swap implementations, but the functionality all looks good to me. Let me know what you think! Thanks, Jeremy On Wed, Aug 21, 2024 at 12:25=E2=80=AFPM Dean Marx wrot= e: > > ------- > v2: > * added filter for verbose output using dst mac address > > Dean Marx (2): > dts: add csum HW offload to testpmd shell > dts: checksum offload test suite > > dts/framework/config/conf_yaml_schema.json | 3 +- > dts/framework/remote_session/testpmd_shell.py | 124 ++++++++ > dts/tests/TestSuite_checksum_offload.py | 264 ++++++++++++++++++ > 3 files changed, 390 insertions(+), 1 deletion(-) > create mode 100644 dts/tests/TestSuite_checksum_offload.py > > -- > 2.44.0 >