From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <quzeyao@gmail.com>
Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com
 [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 68DE2FEB
 for <dev@dpdk.org>; Thu,  9 Aug 2018 12:25:12 +0200 (CEST)
Received: by mail-ed1-f66.google.com with SMTP id k15-v6so2628140edr.3
 for <dev@dpdk.org>; Thu, 09 Aug 2018 03:25:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=6sJGo2gzrFrubd6Gr8A4WK2LxOh0A29rn4YdP+KUcmQ=;
 b=QJmJ3QhqoUVOo0Mu7QKDzExTEtuRpcnTesIX+J4CWN3lH7EuMcudyo1i/HgmpW+m7J
 IxIVNxohGSRY3ZeNh7cgfsZH/xGQ5eZTvpkwovF7V2F0eP/9iIlZFAzD/Yzo5tiHmoJK
 87cvNp8kjHsB1oPQQw/kBys6pK6M+JpMdj4uFIx9Hs6MB1BuAceKM4+ayytUPzcq0tl3
 TqJV3h+v1MLMx476G//ZBE1ZfCb4rstj6P87w9d+6phU72v/NAg1Ql9GBzjdCoexXCX6
 tOMPyC5GwPP6Qbaho9QYU3pVRaaaZdxYNxV18B35wo2hBN/YMO4jRBkl84a+daSkbdlw
 c9Nw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=6sJGo2gzrFrubd6Gr8A4WK2LxOh0A29rn4YdP+KUcmQ=;
 b=m7bUL/U1Bj/AyX5qWObWKPrW3Hbcb2IqN8269fdDZ4oONTJ3BKpHcPLQ7ZY53ICzvD
 nHoLxcJjwt8L8kcY1R2RxCJrBIPf2VR48N1q7J25XLH2tqAacgmoLrq69KXAOSDHATTo
 XQdEkRtlQsFJ63nydAaEGneh9MW/E/zkXRJhv//7le8SUtKpOzTyG/4j5CYFkfTWPCHs
 EbxiEJ51OePqGun3qtnUnEGA12mHIvVyKgBG1l298TVtmLPmVlZMnE30jS2K8bsJRkiL
 hhNsb9givo4gHy2FRZOyZfuU+Xxf+XrOWJOdi/nZPdJlq5mgXCJZeLM9Ch6/RsvrvoOI
 C73g==
X-Gm-Message-State: AOUpUlH/bRB96l1AuIjxlS398VAFw0eglNDrkN09cGrVydKi/INPpTk5
 pVyPyApvRwZvh0HcvFt6S6NfGFj43qL8BH9FhW+2zA==
X-Google-Smtp-Source: AA+uWPyLR5CO1YqU4EP5ftH8VQ2/F4NEOpfIWTW4pWd5mG5eeXV5NJ7ojg/OruhB9td0MPDwhVnrsjjzKO0nEbsIpGY=
X-Received: by 2002:a50:b3c8:: with SMTP id t8-v6mr2404021edd.95.1533810312112; 
 Thu, 09 Aug 2018 03:25:12 -0700 (PDT)
MIME-Version: 1.0
References: <1533557167-7390-1-git-send-email-quzeyao@gmail.com>
 <3508b463-304d-8d52-e793-9bfbce1cd18a@intel.com>
In-Reply-To: <3508b463-304d-8d52-e793-9bfbce1cd18a@intel.com>
From: Drocula <quzeyao@gmail.com>
Date: Thu, 9 Aug 2018 18:25:00 +0800
Message-ID: <CAACUTVxWTycbgt5ho7HM=Hszz0EkKz-serLH5pPk9aNMYDnnnw@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2018 10:25:12 -0000

This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.

On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>