From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <quzeyao@gmail.com>
Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com
 [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id BBF6325D9
 for <dev@dpdk.org>; Thu,  9 Aug 2018 12:33:28 +0200 (CEST)
Received: by mail-ed1-f68.google.com with SMTP id b10-v6so2643343eds.4
 for <dev@dpdk.org>; Thu, 09 Aug 2018 03:33:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=qo2h/hfeZsCCJCF7Mc0BWjbhaA9R03YlXusOh8ji3Zc=;
 b=XAMRGIboRXfiPE3mnrLxyHXKH9sR67VWzholc/0j1dEFYh6zDUjD+Q8jS+/8e0Zyv0
 x835C2zYKU06v5J//xsKvnGDvULJWUAzUm9TligEJtlTkRCT9dIaY6c0hnZW5xsqO8AC
 VJ8aAywe4c7istoa28Nnl8HWMCdwd6agiCECQRGXFlnWLQCPNvjxgC/KF2gwAtioE7SX
 xQsnUPrimGy59ElF+vSFhMjoMvC17FomplftfB8seqaFFcdx5G/dJrB1+OwlZODhPild
 cUOczgxF2Jef/lzhoH264NRnvU1vRsm9fMR/fnveeNmmEqf7xOyC+GiFD4jNtlloy8c5
 XrGA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=qo2h/hfeZsCCJCF7Mc0BWjbhaA9R03YlXusOh8ji3Zc=;
 b=StBxHA1yW3mqJrYQ7WKfIJx5IWO+hFU1IpB6+tNFjGe7GRkxIONebMjf/N6HLOYk2n
 BQsdiPDMIE7kFuZT6H/Srgcw1abgqYuP7YZKkH1v8GYvurCjPeb9jlNEMjlPSMVM1PeM
 k33Cz7FpgfvmDOW/AxTszadDAiBAWq3LPDhVEG52Hq5cpvNShU8KghG3eeB6V+UgYT1M
 EgNvTVCcYgnUkx3O7FMRx5HJnXaw4DCF/ozXr28el0tg4U80a3RgAUbY6sB7HXIozns9
 lmPLMztEJpWypiu+p40ZsOIE52e3UedMJJJDpOq2FZG0qynWZpRaD5SG45WK8ashUzeb
 kDSQ==
X-Gm-Message-State: AOUpUlF3g+FRnKwEmb/FYCtLEK/R0puoX8hF4ZminqgZ+Z2Y1jsWJTUX
 c2cm1fD9AFu+7rAUHmlvLV6LLriGgIZ2jwIls7g=
X-Google-Smtp-Source: AA+uWPziOvDrPNypWYW0vhOeiZ0K4D4DAPnlXXiNSewOFzTJMy4dzaKUYubV2L9ZbsiFz/LNvzfDOe/l0hzwhCNgWEU=
X-Received: by 2002:a50:b3c8:: with SMTP id t8-v6mr2439761edd.95.1533810808390; 
 Thu, 09 Aug 2018 03:33:28 -0700 (PDT)
MIME-Version: 1.0
References: <1533557167-7390-1-git-send-email-quzeyao@gmail.com>
 <3508b463-304d-8d52-e793-9bfbce1cd18a@intel.com>
 <CAACUTVxWTycbgt5ho7HM=Hszz0EkKz-serLH5pPk9aNMYDnnnw@mail.gmail.com>
In-Reply-To: <CAACUTVxWTycbgt5ho7HM=Hszz0EkKz-serLH5pPk9aNMYDnnnw@mail.gmail.com>
From: Drocula <quzeyao@gmail.com>
Date: Thu, 9 Aug 2018 18:33:17 +0800
Message-ID: <CAACUTVygbHh4M8NP2d8v_8972hG_Syi2CL7j0tC0GwszA_zs-w@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2018 10:33:28 -0000

Sorry for my mistake,
This patch  fixes compilation errors on Centos 7.5 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.

See commit 37d477b6863e5c06e20be434b559d3a03d89f46a

-- Drocula Lambda

Thanks

On Aug 9, 2018 18:25, "Drocula" <quzeyao@gmail.com> wrote:

This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.

On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>