From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f47.google.com (mail-qg0-f47.google.com [209.85.192.47]) by dpdk.org (Postfix) with ESMTP id B2C242BA4 for ; Wed, 23 Mar 2016 08:19:43 +0100 (CET) Received: by mail-qg0-f47.google.com with SMTP id u110so5219366qge.3 for ; Wed, 23 Mar 2016 00:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OEhrLV6TFcMyMxpe3R/8YoyRkJfefBAKy29mxkKr7Rw=; b=DDiV+kKGqYTtEGb6s4NKks7a5QLZw1FLTM2+CspXk1cmGF1H9YKnVRZbpAer72EIyn xKvF0vOrIqVjeEIMlnsvsuNhR8okVdQp9Ez6toxqJ6XEBS1hQ0WEh/88iDcRJvA0hivf hdRp6dj+nF3eLzmwDDNRVX12MneoXg64LQEW81RUss3VczPuZlMSN/2vLdbJUBgWGNgK BWCZ6oAeR+UcFVKWjRPnzGKJsS/krrD3C1HHgehIqLyl1Iyf8sTk8FuEkA0AG73JRAb0 b0sNBHzahZXe1Xt3K/Ec8V4bT+HOe7AGKgV9GzwsXbBfcDjR1bbWWy9N6UeBWyZ2Sy7P qfmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OEhrLV6TFcMyMxpe3R/8YoyRkJfefBAKy29mxkKr7Rw=; b=RgZgQmpA+5pMXUzRFLGaOLqpbBwI5z0cNRoSY60BP6U5PpKdS2g6n39QPA+iHmRGeF 0FTPqQR4ElGst/4Zz8ok/Gu7Ep4pM1naMGb1g3J6jTfOz7/WHf24Ii6q7/KoBTijFrvw X0pdgNJ6QsPWR/K9Ek67kE94QFUDzGiRMFCvCXNkmwvXKoMTV9GBNhtyxCFhq2cRO8Wp /4oCnpRPvSSwX0DfYlpxgi777smzJXDJ+XqUzNtJqBcKSqIQdQmCYjZ4Az1p0fnJQcL2 Ss/2mVF/rWewwMWCWfSCwTIxtvwugBAMketfdCCAcxzXQOEOrFXDcoQhu8HHs0D57EEQ GG+Q== X-Gm-Message-State: AD7BkJLVDRTTcwHsTXLHDeGcZ7OIb+JKeRXgqKfUoGltGLMJrTh/YN386SSMCWGevLWgXkHGYKnyozWqcsA4dbjP X-Received: by 10.140.109.100 with SMTP id k91mr1435158qgf.54.1458717583128; Wed, 23 Mar 2016 00:19:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.163.85 with HTTP; Wed, 23 Mar 2016 00:19:23 -0700 (PDT) In-Reply-To: References: From: Christian Ehrhardt Date: Wed, 23 Mar 2016 08:19:23 +0100 Message-ID: To: Daniele Di Proietto Cc: "discuss@openvswitch.org" , dev , "ciara.loftus@intel.com" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Issues with openvswitch2.5+dpdk2.2+kvm/virtio-pci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 07:19:44 -0000 On Tue, Mar 22, 2016 at 9:47 PM, Daniele Di Proietto wrote: > Hi Christian, > > thanks for the report. I've managed to reproduce the problem and I > observed two separate issues: > > 1) short version: it appears to be a problem in DPDK 2.2 and it should be > fixed by 9a0615af7746("virtio: fix restart"), now on master. > [...] > It appears that simply backporting 9a0615af7746("virtio: fix restart") > fixes the issue. > Yeah debugging it I came to the double configuration as cause as well yesterday. Eventually I saw that virtqueue->vq_ring structs got reallocated but stayed zeroed out by the second call. I didn't realize there was a fix for it already - thanks so much for pointing it out. I'll give a backport a try and let you know if it worked. > 2) When ovs-vswitchd is started with --monitor, there will be a parent > process (the monitor) that simply restarts the child if it crashes, while > the child does the actual ovs-vswitchd job. > > It appears that the monitor feature is broken with DPDK, because the DPDK > library is wrongly initialized in the parent process. If the child > crashes, all the DPDK memzones are preserved, meaning that new allocations > will likely fail. > > The fix for this is calling rte_eal_init() in the child process, after > parsing other ovs-vswitchd command line options. This is done (among other > things) in Aaron's series currently under review: > > http://openvswitch.org/pipermail/dev/2016-March/067422.html > > I think we need a separate fix for branch-2.5. > Yeah I was on discussing and testing that series already as the series was also related to a socket ownership/permission issue (back in time). http://openvswitch.org/pipermail/dev/2015-December/063567.html I think eventually we need separate fixes for both on the branch-2.5 [...]