From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFCEDA0524; Tue, 1 Jun 2021 09:46:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C70B4410F2; Tue, 1 Jun 2021 09:43:46 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 6B13840041 for ; Tue, 1 Jun 2021 09:43:45 +0200 (CEST) Received: from mail-qv1-f69.google.com ([209.85.219.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lnz3x-0006Qn-53 for dev@dpdk.org; Tue, 01 Jun 2021 07:43:45 +0000 Received: by mail-qv1-f69.google.com with SMTP id n17-20020ad444b10000b02902157677ec50so9568707qvt.12 for ; Tue, 01 Jun 2021 00:43:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=spobXkGa5CyBzV404YkuFZ6XTgyi7YnzyCxeudkBQe4=; b=NzAIsMiuBxanDTxruJOaJ2z2yGD6No6NEcrz5xYASc2WvhU484v7VWYkoyD8Lw/1/3 hqesGX4Tup6C6gdrNh15/JhMxXP4OWdwUYifMgjTNdgo7C9bQirQhrwlcqm40RxP12fu a8bpB/ygy5oPfxuS2fKIq+wczrXkXBp/GHLfJcqL2yfR+pW66AvJMfEEQaxeQ+zn2x0E wwb9yYwKC8kvxjziAY78ffDJpVKiCnWX2i3NWuupGSL2Bdl8ofPneLtWL/Z2RMNsv++C pvpfPIC5HJ6yt4+/TOZCpK1V6xFgCvujIG+UL2XH+9GLmHa2LX8IdZuWzchZxMeV5i0V 7Zbw== X-Gm-Message-State: AOAM533zVvljfW9iyWdhh5qQop6Mh5ZHDQmL8PfEEiolynFStOAuDw72 bF79f+JwwBle4pA5ZkymTTEo4vjKXSk3eeHbpEYd5Z9W5bvY/V8prPIcPhNhEV9e499BQ9Swyhk DsnpcE28ZMupwbqxsS/vQ8kia104tl7mfub46 X-Received: by 2002:a05:620a:a4c:: with SMTP id j12mr20160948qka.33.1622533424284; Tue, 01 Jun 2021 00:43:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcfUBf3DtsSX3jEw09fEaYUsxQdjbQmwVnRd2SSLyxgBDLHEDtX9St4Gw14ZCgJyTgWOwtZIXB0T839yg/FMU= X-Received: by 2002:a05:620a:a4c:: with SMTP id j12mr20160936qka.33.1622533424086; Tue, 01 Jun 2021 00:43:44 -0700 (PDT) MIME-Version: 1.0 References: <20210601054247.1540154-1-christian.ehrhardt@canonical.com> <4162591.McMD3bK3sO@thomas> In-Reply-To: <4162591.McMD3bK3sO@thomas> From: Christian Ehrhardt Date: Tue, 1 Jun 2021 09:43:18 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Nithin Dabilpuram , Anatoly Burakov Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] vfio: fix stdbool usage without include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 1, 2021 at 9:25 AM Thomas Monjalon wrote: > > 01/06/2021 07:42, Christian Ehrhardt: > > This became visible by backporting the following for the 19.11 stable tree: > > c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA" > > > > The usage of type bool in the vfio code would require "#include > > ", but rte_vfio.h has no direct paths to stdbool.h. > > It happens that in eal_vfio_mp_sync.c it comes after "#include > > ". > > > > And rte_log.h since 20.05 includes stdbool since this change: > > 241e67bfe "log: add API to check if a logtype can log in a given level" > > and thereby masks the issue in >20.05. > > > > It should be safe to include stdbool.h from rte_vfio.h itself > > to have bool present exactly when needed for the struct it defines > > using that type. > > A line "Fixes" is missing for the record of the root cause. Thanks Thomas for having a look, it is slightly up for debate what exactly the root cause is here, but I think c13ca4e81cac that introduced using bool without adding a header is the right reference. I'll send a v2 with that added > > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd