From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] thoughts on DPDK after a few days of reading sources
Date: Mon, 15 Feb 2016 11:36:49 +0100 [thread overview]
Message-ID: <CAATJJ0+Qo-6z3F0apGOujcqySpqQJP==gd8urOi1021h6hiEKA@mail.gmail.com> (raw)
In-Reply-To: <2593509.xiuDro8IbH@xps13>
On Thu, Feb 11, 2016 at 8:58 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> Hi,
>
> 2016-02-10 19:05, Seth Arnold:
> > I've taken some notes while reading the sources; I'm sharing them in the
> > hopes that it's useful: on the one hand my fresh eyes may spot things
> that
> > you've overlooked, on the other hand your familiarity with the code means
> > that you're better suited to judge what I've found.
>
> Thanks for taking time and sharing, it's very valuable.
>
> > - shellcheck reports extensive cases of forgotten quotes to prevent word
> > splitting or globbing, potentially unused variables, error-prone printf
> > formatting. The scripts that are going to be used at runtime should be
> > fixed:
> > - ./debian/dpdk-init
> > - ./debian/dpdk.init
>
> These files are not in the tree. Should they?
>
>
You are right, they are not in tree.
These few are parts of the ubuntu packaging and will be fixed by me this
week.
Sooner or later that might (partially?) flow back to the Debian packaging
that is in tree.
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
[...]
next prev parent reply other threads:[~2016-02-15 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 3:05 Seth Arnold
2016-02-11 3:41 ` Matthew Hall
2016-02-11 7:58 ` Thomas Monjalon
2016-02-11 11:58 ` Alejandro Lucero
2016-02-17 9:35 ` Christian Ehrhardt
2016-02-11 16:13 ` Dave Neary
2016-02-11 16:20 ` Thomas Monjalon
2016-02-11 16:29 ` Wiles, Keith
2016-02-15 10:36 ` Christian Ehrhardt [this message]
2016-02-11 22:48 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0+Qo-6z3F0apGOujcqySpqQJP==gd8urOi1021h6hiEKA@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).