From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f180.google.com (mail-qk0-f180.google.com [209.85.220.180]) by dpdk.org (Postfix) with ESMTP id D9435592A for ; Mon, 15 Feb 2016 11:37:09 +0100 (CET) Received: by mail-qk0-f180.google.com with SMTP id s68so53785478qkh.3 for ; Mon, 15 Feb 2016 02:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=CS/pXsp+1JGHOqWzJpQYdljLF92KXtUE4vVKdIRoE0Y=; b=YA5wuZ6OzFThiaUwgshvsu85AYzEo+Q/b0VJ+ML7fMlkDpwzRCkbYfftDa8xv2adN+ SqkOkktTUnjvXZCQ9iIr/hKi3uzCob1hpzxiqPesWBbxosboapYoRaWt4AKxcmX4bawD adtBy//Y8J1eA7Aod7fFYCiqtsR2rrf5GSf0BoMcS3/0Dz7TABxRdEW1FX4tMST5Yfyr lLU8Si3rkzM79sKzDoHmvkkvNbj5FhUp/oXHlCucXTjB6kN3pAJCmOKK2bda2Qn46mOE TU6FoGgPiKuybHze0VtUCSKh3ellk6sA0tv8Ak0GGCOMhIsR+mJESKXqAtr73wTmV0D9 scrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=CS/pXsp+1JGHOqWzJpQYdljLF92KXtUE4vVKdIRoE0Y=; b=lAuuYE9z+fzUSqTgEUgDGttdxVqFVU+/vx/x3x3UYAcp0erGSeMurCz5gwubnY+eLp 1+BHiowgx6qIGvcJWE31ZhVScAowkesfQOVeg6GvavQcRXHXfl3HaIXfsEV4tBY1jwNo ojAkX834P1PDluFtl6PXaQKzEC1LSzGOTCMTTfs6CmGGhlrZvZ6BRrd19r1LctsKl4px McexPXoH/CG8cgbsbEKC6WeIEbyKNswZ7pEHs4cWpa2e8U2mi8nwDcOYvfbbZnIlQ/HR OcB6gflcX/hQC6asaE1ej9C6Rxp7zFxur9v+kB8CMtd4qYyxLKsutYp5Ou6sVwO15OYE jRQg== X-Gm-Message-State: AG10YOSS6jgZUz7PfP7e341t5OKhufo0bLi2G+QyEp/doGxYhwM9tvC3Ab9DQk7ncm0dBp8Dzmp1eaZvgZadLG8Q X-Received: by 10.55.22.95 with SMTP id g92mr19399216qkh.78.1455532629312; Mon, 15 Feb 2016 02:37:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.207.20 with HTTP; Mon, 15 Feb 2016 02:36:49 -0800 (PST) In-Reply-To: <2593509.xiuDro8IbH@xps13> References: <20160211030540.GB25680@hunt> <2593509.xiuDro8IbH@xps13> From: Christian Ehrhardt Date: Mon, 15 Feb 2016 11:36:49 +0100 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] thoughts on DPDK after a few days of reading sources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 10:37:10 -0000 On Thu, Feb 11, 2016 at 8:58 AM, Thomas Monjalon wrote: > Hi, > > 2016-02-10 19:05, Seth Arnold: > > I've taken some notes while reading the sources; I'm sharing them in the > > hopes that it's useful: on the one hand my fresh eyes may spot things > that > > you've overlooked, on the other hand your familiarity with the code means > > that you're better suited to judge what I've found. > > Thanks for taking time and sharing, it's very valuable. > > > - shellcheck reports extensive cases of forgotten quotes to prevent word > > splitting or globbing, potentially unused variables, error-prone printf > > formatting. The scripts that are going to be used at runtime should be > > fixed: > > - ./debian/dpdk-init > > - ./debian/dpdk.init > > These files are not in the tree. Should they? > > You are right, they are not in tree. These few are parts of the ubuntu packaging and will be fixed by me this week. Sooner or later that might (partially?) flow back to the Debian packaging that is in tree. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd [...]