From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F106A0613 for ; Wed, 28 Aug 2019 16:49:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FD4B1BECE; Wed, 28 Aug 2019 16:49:01 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 69A997CBC for ; Wed, 28 Aug 2019 16:49:00 +0200 (CEST) Received: from mail-ua1-f70.google.com ([209.85.222.70]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1i2zFs-0000JU-0s for dev@dpdk.org; Wed, 28 Aug 2019 14:49:00 +0000 Received: by mail-ua1-f70.google.com with SMTP id p19so23866uam.4 for ; Wed, 28 Aug 2019 07:48:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sog8l7zjRxYx/zBvCY0V90T6pf3QzZuoZ63VGl/mmXs=; b=DsM2dG1RD+mcz9xevI+MpIoSAL1Q0UWjmyGblBKi00OhNxJ1kkrlQoSFoBlwB/WAZX LF8y4+Vln11w9wIVt7h39PQhBepLDQpxReHLoG188JQDJcw5f8CsiMrEDs2HsrK49JUs ZjUekKoQi5G9itiM1in5fWYp98x9bi89lImIN6Dtr3JZLgL91OxGe942qJCY3RYLWrWy sN1dLcPnBkfoQgXn8AQKu8SfqdJb2N08yfUFAbyPUqqEXTAQAri+gMXzMl/Q1JSEf9bL 8LXjhVGooIYrsaPcpN0HDZvVrdP5d5vVjJp/liubqtwp1+hLDGUFTqLSsgAfdLMacMSF pPDw== X-Gm-Message-State: APjAAAVEhTSIBjuUr87Bc2ZuhELd+XEY3V5hzi+usnLgRmdHLam3lUbJ q1z2uBSmPmLRm4dNPPVtm6fGFNhOATJgWQVvPOyoqbeCQNPGzt5RmnKFKEnz6UGjGSyJtC5u4e3 +9BnW34lhVqdlqXqvMew/EcQWh5tYuLsbx9Vk X-Received: by 2002:ab0:481:: with SMTP id 1mr2180636uaw.91.1567003739132; Wed, 28 Aug 2019 07:48:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2l+VsDCaU67x7kfHP0hSwDQqkyQtLzQg+y+pcZ+RuEuCbaXYUZBvlETUrTvsWtXJWdR+3x7tVXxgfh+nSQoc= X-Received: by 2002:ab0:481:: with SMTP id 1mr2180614uaw.91.1567003738814; Wed, 28 Aug 2019 07:48:58 -0700 (PDT) MIME-Version: 1.0 References: <20190828122752.27887-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Wed, 28 Aug 2019 16:48:32 +0200 Message-ID: To: Aaron Conole Cc: dev , Kevin Laatz , Luca Boccassi , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 28, 2019 at 3:53 PM Aaron Conole wrote: > > Christian Ehrhardt writes: > > > A while ago telemetry was added in 57ae0ec6 and it also added as-needed > > to config/meson.build. This seems no more needed these days as due to other > > build changes the ordering in buildlogs is: > > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] > > Which means telemetry no more benefits from --no-as-needed anyway. > > > > Overlinking problems get triggered by the meson generated pkgconfig which > > will have: > > [...] -Wl,--no-as-needed > > This will overlink and in addition anything that follows > > as it also doesn't wrap back to --as-needed. So if a projects includes > > dpdk libs + it will also consider with --no-as-needed. > > > > Fixes: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 > > > > Signed-off-by: Christian Ehrhardt > > --- > > Hi Christian, > > I agree this is something to be fixed. It will need additional work, > though: > > https://travis-ci.com/ovsrobot/dpdk/builds/124909245 > Thanks for the Link Aaron, yet I'm puzzled what to do there atm. The kind of error I found in the failing logs were misleading at first: - linker can't find -lvirt / -lpqos / ... well the test env needs to install them, maybe it was added as dependency by accident before? I'd understand (due to the change) if it would complain about missing symbols (no more added due to as-needed, but then for some reason needed) But this is vice versa, it just doesn't find the libs in the build env - error: unrecognized command line option '-Wformat-truncation' I don't see how I'd cause this ... => Maybe this is just an artifact that is even part of the normal/good tests? Comparing former logs - last good test was https://travis-ci.com/ovsrobot/dpdk/builds/124875383 This first seemed more helpful. DPDK:fast-tests / eal_flags_w_opt_autotest FAIL DPDK:fast-tests / func_reentrancy_autotest FAIL DPDK:fast-tests / mbuf_autotest FAIL DPDK:fast-tests / mempool_autotest FAIL DPDK:fast-tests / ring_pmd_autotest FAIL DPDK:fast-tests / sched_autotest FAIL DPDK:fast-tests / table_autotest FAIL [...] Overall about 14/60 of the tests failed with no recognizable pattern why just those and not the others. I only see "Full log written ... on_error", so I can't directly compare how a good run would look in the configure/build stage. Looking just at the bad case there are plenty of messages like - "no available hugepages" - "cannot reserve memory", .. But all those indicate more a flaky test(-env) than an error in the commit, there must be more to it. @Aaron is there a good way to get the rest of the log for a good case to compare? Maybe I'm yet to blind for all the potential side effects of the change?