From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <christian.ehrhardt@canonical.com> Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com [209.85.192.50]) by dpdk.org (Postfix) with ESMTP id 07A76256 for <dev@dpdk.org>; Mon, 13 Jun 2016 12:21:11 +0200 (CEST) Received: by mail-qg0-f50.google.com with SMTP id p34so65508414qgp.1 for <dev@dpdk.org>; Mon, 13 Jun 2016 03:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=01eyKKQevZUcnoWX8mUBCGxf1us50ItBdaSZ4hwUibs=; b=DQ00zNlXaE2u2LHcFUQePLXX2xT6J5BzUamhEHGpu3svgxr0rpSXN3ibfMdS75N5/u nuOy9mOMCnfJmsYutG5jfJLeKzgcFcukaThkMw+rPTnwCM+pJzzEQhHFzitCmhnV6ZLJ D8SHYSZeR2VKf4hh12EpTVqsxA+UAUnGip3c1yTnq+VTB/NkuLhx+7QF/Jb+CfWknBz/ dKJf0Yjm8Rir/TOEXIDkSKpMsjXhhw8YjIUCqIRhu3cTLgiFKyNa/mP9lnjfBgRaninS SvAkncPJ1qNNfpCh9DS/rTYyd3G4YXP1znmqdRJn3DDv4SrhP8I9FnzBhraNFzWynWpf 2xoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=01eyKKQevZUcnoWX8mUBCGxf1us50ItBdaSZ4hwUibs=; b=jy5A5M72ryuq40+h9ooIbnKWnkHZ7w8awKR37vmRP0GkKXfX4aMAHiCDiv1xOFcmtu yAjAWW2uMMm14woqbksHedZN8rccJp760fgX9D+Rlc2vE0AnbLExeB0NaZUyqDYJGmSP O5qEesyg0HqeHrbq7y5dXrGy3DA8GzsF797fd9AZB4Hy4+3hyteaKqJaB+EBZLsTXTLs ybc8ImCbd8qUy1cwTP5zyCszt7pqkQSkvKlq/4ee+3lCrKvhdEbtsr0NqFRMqGbxsV+G oKG+YKdYOJv6bsdCiSapceZefERnNLD4j34hent8Ncg8DyngKsZesOnNGvytHijLPRtB YsOQ== X-Gm-Message-State: ALyK8tKc07x0HwysSOf40ka5qdqUnvvhHBE7p7aRBKrPF5eg8FJUcDYvlTSml59HaI4mOPP4K8myGJ25P1F/uU7l X-Received: by 10.140.101.42 with SMTP id t39mr13122609qge.57.1465813270448; Mon, 13 Jun 2016 03:21:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.162.9 with HTTP; Mon, 13 Jun 2016 03:20:51 -0700 (PDT) In-Reply-To: <4880734.Dg9G2McolW@xps13> References: <CAATJJ0K5PLibRiR3+-ZZSjZozipiKPTGk9wufP48vX0ma_CsKA@mail.gmail.com> <1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com> <4880734.Dg9G2McolW@xps13> From: Christian Ehrhardt <christian.ehrhardt@canonical.com> Date: Mon, 13 Jun 2016 12:20:51 +0200 Message-ID: <CAATJJ0+ta8eUnn4JiB-awmi7ep0dX=GETR=mYzhZFxad7PGyEQ@mail.gmail.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org> Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mk: fix missing DEPDIRS to avoid libarary underlinking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 13 Jun 2016 10:21:11 -0000 On Mon, Jun 13, 2016 at 12:08 PM, Thomas Monjalon <thomas.monjalon@6wind.com > wrote: > 2016-06-13 11:48, Christian Ehrhardt: > > --- a/drivers/net/af_packet/Makefile > > +++ b/drivers/net/af_packet/Makefile > > @@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += > rte_eth_af_packet.c > > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_mbuf > > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_ether > > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_kvargs > > +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_eal > > It looks more logical to have eal as first DEPDIR in these lists. Yeah, thought about alphanumeric order, but eal first should be most appropriate. > > --- a/drivers/net/vhost/Makefile > > +++ b/drivers/net/vhost/Makefile > > @@ -36,6 +36,8 @@ include $(RTE_SDK)/mk/rte.vars.mk > > # > > LIB = librte_pmd_vhost.a > > > > +LDLIBS += -lpthread > > + > > It is not a DEPDIR but an external dependency. It deserves a separate patch. > Yes, sorry for just wrapping it in. Will send a v2 with both changes later. > Do we need it in rte.app.mk? It is an EAL dependency as well. > Not IMHO: EAL depends on it so librte_eal.so depends on it as it should (just reverified by ldd). I don't see a reason that any app created should depend on pthread other than if it actually uses libpthread.