From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable
Date: Wed, 3 Aug 2016 10:11:32 +0200 [thread overview]
Message-ID: <CAATJJ0JJ6zAa3Wq8ejA9YFLLweV_G3F-QnOWuwM_wQxLfrQbmQ@mail.gmail.com> (raw)
In-Reply-To: <1518657.ZZVjD1fj2f@xps13>
sorry, I accidentally dropped dev list in one of my replies, readding.
On Tue, Aug 2, 2016 at 11:29 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> > > > Given that we should drop the .sh file ending as well as the
> executable
> > > > flag - both are not needed to source the file.
> > >
> > > Hmmm, it is still a file containing some shell commands, right?
> > > So why removing the .sh extension?
> > >
> >
> > I wanted to discuss on #dpdk today, but everyone seemed busy today.
> > So I expected the discussion on file extension to come up on the patch
> > submission - which is fine and just as it should be.
> >
> > My reasoning was primarily to discourage people to think to call it.
>
> I think it is the contrary: the executable files for users have no
> extension.
I totally understand that for commands in the path, but that doesn't count
here.
Could we have anybodies opinion as a tie breaker so I can submit a v2
without RFC then?
P.S. I understand there was no objection on changing the file mode - which
might be quite unobvious in the diff?
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
next prev parent reply other threads:[~2016-08-03 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 13:54 Christian Ehrhardt
2016-08-02 15:30 ` Thomas Monjalon
[not found] ` <CAATJJ0L4a2fdmNzMmKvnXGeQJR4ch3ChYg1WPH142wbtvkknzQ@mail.gmail.com>
[not found] ` <1518657.ZZVjD1fj2f@xps13>
2016-08-03 8:11 ` Christian Ehrhardt [this message]
2016-08-03 9:26 ` Bruce Richardson
2016-08-03 9:42 ` Christian Ehrhardt
2016-08-03 13:19 ` Thomas Monjalon
2016-08-03 14:54 ` Christian Ehrhardt
2016-08-03 14:59 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-08-24 16:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0JJ6zAa3Wq8ejA9YFLLweV_G3F-QnOWuwM_wQxLfrQbmQ@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).