From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f174.google.com (mail-qk0-f174.google.com [209.85.220.174]) by dpdk.org (Postfix) with ESMTP id DF9C358CF for ; Mon, 1 Aug 2016 15:13:01 +0200 (CEST) Received: by mail-qk0-f174.google.com with SMTP id v123so11793259qkh.3 for ; Mon, 01 Aug 2016 06:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Dgp1x2OK9MMXUsldb8F0qicEeps69FnXHlBsxKxyIjA=; b=x2DVY7DgSQcTGuwmgckBQMN1MjpTdc7OGxgxOY4I556QOBxM8nse/szvoz+kaTBQUQ 6+Ut5QTdG+YaVE2seo1KdoPfH55yX369HT6YGFnxTlrx6dGO8/F28GrNeHGJT2ZC0J25 qFrJrZHhIRdtphia1LLjllUL5tvPiWJDLRO41K+dIxLBpW5Uh8lQSPGf/fb1uyTsVgAd xxmoXn4YaK6IJ1JTW5uKfbzl2KEodjPydth1MTC1DMOFBc2O5mWO2NM5xnprfn7WMBH/ AMoV0ayCLqgiyccmLwENWwLMm+cctLF7uKwDFaPNrgYluuEpbBSdM2LGxnz6ZhT2UoaD q99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Dgp1x2OK9MMXUsldb8F0qicEeps69FnXHlBsxKxyIjA=; b=RuL50EIOBQYhu6Vy5pueCZ7EQB2Qmim4hM3Mjfc6eHD/odpYQ84JyDlEh4JS21zDXU 3aWS1bNHK95EjjtZJZXSnLOIVWyAit46mK5yS5Xxb+dO37mEdP2lbqJJjJ87MqrYuiCl Q7YFMCiWJIypaRbu9F5m6xweVKqFdGK/hGAhZniw3V9vRaFBCg3RvntAQ2I/JwvN630T xSfqqQ7OHK1JyX7tRulFDx8o6T6UJLgfVDMEvHdXeEGSWX2v8NEXC6NOX9k9t/OiTB1d fvCuAHra4EHjj9WeYZx0APURwB+Y4B6mugZt4ua0GO9AJGSfbh4oSlxKzKrApWwJ0ULg pKmg== X-Gm-Message-State: AEkoouv61nTaK4ZDSQDl96CrFziykMDbPZB1/CS+7DdvLsUBcN7IQU3aM/n0ckeaV2fBPKiqtXp2baWx85S++2Kh X-Received: by 10.55.75.207 with SMTP id y198mr64140313qka.57.1470057181258; Mon, 01 Aug 2016 06:13:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.15.193 with HTTP; Mon, 1 Aug 2016 06:12:40 -0700 (PDT) In-Reply-To: <2509298.JEBDPBJoPR@xps13> References: <1470054511-31217-1-git-send-email-christian.ehrhardt@canonical.com> <2509298.JEBDPBJoPR@xps13> From: Christian Ehrhardt Date: Mon, 1 Aug 2016 15:12:40 +0200 Message-ID: To: Thomas Monjalon Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] examples: fix unusual-interpreter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 13:13:02 -0000 Hi Thomas, I agree on both changes you suggested, but not being the scripts author I wanted to change as few as possible. Also thanks for taking it into consideration even if just for lintian :-) If acceptable to you I'd ask to accept this as-is and consider the patch a head-up for all script owners to change their headers. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon wrote: > 2016-08-01 14:28, Christian Ehrhardt: > > Due to regular lintian checks in Debian packaging it surfaced that these > > two scripts had a space in their #! statement which renders it to be > > human, but not shell readable. > [...] > > -#! /usr/bin/python2 > > +#!/usr/bin/python2 > > I think we can have a space in the shebang (it works with shells I know). > But maybe lintian do not like it (and it is a sufficient reason to accept > this trivial patch). > > However, a better fix would be to run something else than python2, > like /usr/bin/env python. > > Some other python scripts in tools dir may be fixed. >