From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f174.google.com (mail-qk0-f174.google.com [209.85.220.174]) by dpdk.org (Postfix) with ESMTP id 976E72C46 for ; Mon, 21 Mar 2016 15:02:27 +0100 (CET) Received: by mail-qk0-f174.google.com with SMTP id s68so79432718qkh.3 for ; Mon, 21 Mar 2016 07:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mu6jflssO7Kb7cU89NoNw1gptzyrt+l1TK6hGaBPjRI=; b=Sw933Bk+spyHR5UH5TdkixSc4D1I2+sGPS2HraL+Zass9XYEyg3IFT2g9OmqfVe+eB hcxRDwH1/OyWB+ERNOZe2ku98KtOKzHAlHIG9DBvU/+umqVGktyGXGi6ipGCyYKzCgiI Z7fNEhU7p++5S3gDbTzU+aqatKGNJTaiyHTu5vOwFl9i/FBhVd30VQZ6zvcIyp5p2wrY I7cd3AlVHCxOTdqDipafuI8LElb6ytvzdSO2hZ5z3Hj1o3IqFghICZ4cNErg/0BcDAy3 +K2Cst/EgX/Cx46X6bNdjJ60O/HOe3q09bakTNsf7rhjrZa1fjTRLM291mkU3lvcvHnv ioKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mu6jflssO7Kb7cU89NoNw1gptzyrt+l1TK6hGaBPjRI=; b=E3qZogj86E6neNtVNlWm81NLDEVHFF+/y0n8nQOHfrf5I5RGx1oP+gR+0KPGwHLy6D /9XNb35hBNT4/EKDSOWdk6KezmbxHUmDIvrlGz0TzgNoPScH68cR3Tjl3xjtiH5Yc0m0 QyIxPFkQloUgQBCY7HvBtTtmwSn5PoaxlW+irFSZSWp/OUVnMhjfJ3Y7Zzz1paStZsJR dgnE0UA5q2BrcakXpzibiLcEu5WITCgXZwaCJo4tvommjA6XihAIPSw8sgV8IAVCT1T+ lPr0+KwwiM1ZIAreRxNI/xew29z/UGV9tklTyDp/pjJgCZCyoMvFx6sB7XfTo7XaPjk3 KvSQ== X-Gm-Message-State: AD7BkJILPhvouRwcu4hTTk+DBuvwnlJ77uNYLScHosu4TCxr44sLVVyH9g/MecwzKuRgamEPcC/Dy/ripgEoXosw X-Received: by 10.55.80.131 with SMTP id e125mr40486961qkb.62.1458568947058; Mon, 21 Mar 2016 07:02:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.169.6 with HTTP; Mon, 21 Mar 2016 07:02:07 -0700 (PDT) In-Reply-To: <56EFF4BE.3070001@6wind.com> References: <1458137793-25826-1-git-send-email-christian.ehrhardt@canonical.com> <56EFF4BE.3070001@6wind.com> From: Christian Ehrhardt Date: Mon, 21 Mar 2016 15:02:07 +0100 Message-ID: To: Olivier Matz Cc: Bruce Richardson , dev , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/5] lpm allocation fixes - v3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 14:02:27 -0000 Hi Oliver, thanks for the ack - I had these {} fixed in v2, but accidentially dropped when merging our code. v3 was flawed anyway as my submission was not a proper reply-to to the older series. This shall not be Thomas work to do, I'll resubmit a v4 re-adding the {} fix and properly replying to the former v2 as it was intended but failed for v3. I also add your acked-by and I'm eager looking forward seeing the patches pushed then. Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Mar 21, 2016 at 2:18 PM, Olivier Matz wrote: > > > On 03/16/2016 03:16 PM, Christian Ehrhardt wrote: > > Poking a bit on autotest revealed a few shortcomings in the lpm > allocation path. > > Thanks to the feedback to the first revision of the patches here v2. > > Also Oliver Matz spotted similar issues and made me aware - thanks! > > Integrating them revealed even more use after free / leak issues. > > > > *updates in v3* > > - lpm create/free path for v20 and v1604 got the same fixes that were > > already identified for lpm6 before > > > > *updates in v2* > > - lpm/lpm6 patches split > > - following dpdk coding guidelines regarding single line if's > > - adding singed-off and acked-bys gathered so far > > - combine all three related patches in one series > > > > [PATCH 1/5] lpm6: fix use after free of lpm in rte_lpm6_create > > [PATCH 2/5] lpm6: fix missing free of rules_tbl and lpm > > [PATCH 3/5] lpm: fix missing free of lpm > > [PATCH 4/5] lpm: fix use after free of lpm in rte_lpm_create* > > [PATCH 5/5] lpm: fix missing free of rules_tbl and lpm in > > > > diffstat: > > rte_lpm.c | 23 ++++++++++------------- > > rte_lpm6.c | 12 ++++++------ > > 2 files changed, 16 insertions(+), 19 deletions(-) > > > > Series > Acked-by: Olivier Matz > > Just one small comment: there are additional { } in patches > 2/5 and 3/5. > > Thomas, do you think you can remove it while pushing? > > >