From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by dpdk.org (Postfix) with ESMTP id E9F069A87 for ; Fri, 8 Jan 2016 12:03:06 +0100 (CET) Received: by mail-ig0-f171.google.com with SMTP id z14so72854745igp.0 for ; Fri, 08 Jan 2016 03:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=06qwp6kxki8zTF6l34tqSTLHHHpw+98kMthSRo+fY3g=; b=Oy+A6Qfyh+svJm8Zs7a5hk2YH4L2oh+kI47isyVfQH7eU5ZggCXEaeqG7V3JuzNrAu 2hE0xue1EaCoQ6niYDWSKFISxe+E8BJBm7k4XkwIPtfO7Wt85VbnaZALcRtkrft6Rf3o j+PtGhCgCaRxdntgf1RiXTuVQLj1ivjWrqzoaz37wopNfJaqtKUiDhT4nnwfRnPDhJ8x EuwBJyXiZHGGGr3FheybNsOmFWHXwQ9qGzJ0mHZdsnGW/7SfBc0Aju6cQgztRDUXPOSB nOhHSt6k1AvhpYOsKcZdwWhSsKHJNQMStOCRpjaMLXt2g9jNIFyGSe+XQ3ZB7EeOdQ8Q STEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=06qwp6kxki8zTF6l34tqSTLHHHpw+98kMthSRo+fY3g=; b=SbSed+x432PeETWLMKoPHN5gA674dXOB/1xbLgQZzYQGdGsLOeZARyjPvQAGJkQapN uNzn02TDsWQwZGhlZBduPuSI5R+x9rF7NG3orytxQH5JtGl7xUO5J7BMkGVKZSsxsvdP UykKFgCsynZcLV7FKih0mncDBLm/aOMRtCKgya8+lKDuOesa5ZBS6BZFlgN65PSNgbTY AEe7sSn6JNhvF+6E5OO/GcWnf4ub9lKarPGQNRUFCPp3iS6gu9wieazpsSjzFiXTVbgF /K2EYpn/wzGuR29rV/omugM2vgdWcDPR76xl3K5oUiwW4rQkV0fFggN7Wiqz9dPdy2xt YDvw== X-Gm-Message-State: ALoCoQkb7cWwys0S6fknWcW2Z3IKNVuse/rcLxtTkv45phd9bZbISmHJGx3gVQ9c2mXpPVhlNjgfnTKXmJgIgL/k3XS9eldx4TzcpJPPmCNKPb/5y4V4AsQ= X-Received: by 10.50.134.227 with SMTP id pn3mr12241137igb.13.1452250986212; Fri, 08 Jan 2016 03:03:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.158.12 with HTTP; Fri, 8 Jan 2016 03:02:46 -0800 (PST) In-Reply-To: <4157952.R3xvfQ6Lix@xps13> References: <1450789995-23700-1-git-send-email-christian.ehrhardt@canonical.com> <4157952.R3xvfQ6Lix@xps13> From: Christian Ehrhardt Date: Fri, 8 Jan 2016 12:02:46 +0100 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: Fix examples install path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 11:03:07 -0000 Hi Thomas, sorry being away so long due to the Christmas break. May bad assumption of being a typo was based on a coincidence combining a) former packaging in ubuntu had it in fact under /usr/share/doc/dpdk (I agree that just /usr/share/dpdk would be better) b) if you just and only ran a build and install-doc (no other install targets); the install failes just by missing the datadir That lead me to the wrong assumption it might be in /usr/share/doc/dpdk intentionally. But you are right, lets fix b) instead which is just a mkdir -p in the makefile. Alternative patch will follow. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Dec 23, 2015 at 10:37 PM, Thomas Monjalon wrote: > Hi, > > 2015-12-22 14:13, Christian Ehrhardt: > > Depending on non-doc targets being built before and the setting of > DESTDIR > > the examples dir could in some cases not end up in the right target. > > Reason is just a typo variable reference in the copy target. > [...] > > - $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir) > > + $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(docdir) > > No, it was not a typo. > Do you really think the examples code should be in the doc dir > (i.e. /usr/share/doc/dpdk) instead of datadir (i.e. /usr/share/dpdk)? >