From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f176.google.com (mail-ig0-f176.google.com [209.85.213.176]) by dpdk.org (Postfix) with ESMTP id 1D87C95CE for ; Fri, 8 Jan 2016 12:09:02 +0100 (CET) Received: by mail-ig0-f176.google.com with SMTP id t15so49451949igr.0 for ; Fri, 08 Jan 2016 03:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=At+7YCvZ6Vem3msziIX6RJehmoEm9WIwTNzxEvb8pAA=; b=O03avfWmi9xdMVYsISyNCzy6aHEY6agUkI1mw8yKtZhxmtCeX7nshxNpHgIfUYnbjl fKeBoyoC0q4DtdspIdBox8ornVo+uosNQ993PSa9tBU63vhsqHfL+DYg3yjvQGn9jczp yTNObL3NyJRREDLTxx0OokToIdQJsRwymjOqtKqp2T322Y053aTJUQzjNbpM6CTrOG/n a6xPPnlDnN7y7aA91jGG7mNwM3yrUV8xcda6Y1b5PjL7wF8PBOls62SK0r4k76ErCRU0 iHwQHJRhwZVWPHR7Ksqy9jLArfrFnEbog65sTYzcpSHZeQt/PqCPgGSTfLemBMu27MIv eGiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=At+7YCvZ6Vem3msziIX6RJehmoEm9WIwTNzxEvb8pAA=; b=LND2i42yfVXkiGzcq/4jOd7MyYpttxg/NbBx0f7DpBB4hkofKjg8RgcYJidgG2yokj NEBAHC2rtmtVSVkKjNTZV6o+LBLMpu4plhEQhYyrTDZYl2AuKEi5n6+yHGaLq41KIsUH 1CKMKGcWI+G1cC7RIW19TcpPXBjumObhZ3cEdL5HgOX5zbRsVNJSWsBrcr5lUbE5/6x7 4nObQlHRbFeb8r2aHfQWSFxf9iW/3YGh7qdNlCCgnagrS5/Tx3jcvVrQ940Eoezye+Jj xltEmSTeuABIZoljaT7RL7W7wpIWC9V2ljiXwgOK7KBhoTScgUhPIWW3GXIjyyiPj2Dp yxwA== X-Gm-Message-State: ALoCoQk1tlx8PkhSXrdq7BDTPgUBQerZ9g+veki/S4Uw1O5xe7hH+behxx+b/IBOiRFTwaw9mTyAC7Xt7b2T0xuErHkrs8FwnMr9oS0mJphEL7lyjVo9gBU= X-Received: by 10.50.70.38 with SMTP id j6mr21015267igu.13.1452251341454; Fri, 08 Jan 2016 03:09:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.158.12 with HTTP; Fri, 8 Jan 2016 03:08:42 -0800 (PST) In-Reply-To: <1452250981-5286-1-git-send-email-christian.ehrhardt@canonical.com> References: <1452250981-5286-1-git-send-email-christian.ehrhardt@canonical.com> From: Christian Ehrhardt Date: Fri, 8 Jan 2016 12:08:42 +0100 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mk: Fix examples install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 11:09:02 -0000 Forgot to mention, an easy way to test-trigger this e.g. on the dpdk 2.2 tarball. make clean; make config T=3Dx86_64-native-linuxapp-gcc && && make -j && mak= e V=3D1 DESTDIR=3DTest install-doc In this example the install-doc fails with this: [...] Build complete [x86_64-native-linuxapp-gcc] make -f /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk install-doc cp -a /home/ubuntu/dpdk-2.2.0/examples Test/usr/local/share/dpdk cp: cannot create directory =E2=80=98Test/usr/local/share/dpdk=E2=80=99: No= such file or directory /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk:160: recipe for target 'install-doc' failed make[1]: *** [install-doc] Error 1 /home/ubuntu/dpdk-2.2.0/mk/rte.sdkroot.mk:101: recipe for target 'install-doc' failed make: *** [install-doc] Error 2 Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, Jan 8, 2016 at 12:03 PM, Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Depending on non-doc targets being built before and the setting of DESTDI= R > the copy of the examples dir being part of install-doc could in some case= s > fail > with a non existant "$(DESTDIR)$(datadir)" target directory. > Add the conditional rte_mkdir for that to avoid the issue. > > Signed-off-by: Christian Ehrhardt > --- > > [diffstat] > rte.sdkinstall.mk | 1 + > 1 file changed, 1 insertion(+) > > [diff] > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index c159bf7..68e56b6 100644 > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -157,4 +157,5 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),) > $(Q)$(call rte_mkdir, $(DESTDIR)$(docdir)/guides) > $(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides > endif > + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)) > $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir) >