From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Patrik Andersson R <patrik.r.andersson@ericsson.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports
Date: Tue, 19 Jul 2016 15:50:23 +0200 [thread overview]
Message-ID: <CAATJJ0KdXj=6S4OG829yY+T4XTyS3FfLMs=MT6w1F8meQ4ZMEA@mail.gmail.com> (raw)
In-Reply-To: <20160712120847.GE26521@yliu-dev.sh.intel.com>
Hi,
thanks for evaluating.
I'll need a few days until I'm ready for OVS again and until OVS is ready
for DPDK 16.07.
Then I can run an adapted version of my old testcase to be sure.
In the worst cases it will be in 16.11 and I'll backport to 16.07 as
distributed.
I'll let you know then.
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
On Tue, Jul 12, 2016 at 2:08 PM, Yuanhan Liu <yuanhan.liu@linux.intel.com>
wrote:
> On Wed, Jul 06, 2016 at 09:08:12PM +0800, Yuanhan Liu wrote:
> > On Wed, Jul 06, 2016 at 02:24:57PM +0200, Christian Ehrhardt wrote:
> > > Hi,
> > > while checking for dpdk 16.07 what backports are accepted in the
> meantime so I
> > > can drop them I found this particular discussion has been silently
> forgotten by
> > > all of us.
> >
> > Not really. As later I found that my patch was actually wrong (besides
> > the issue you already found). I will revisit this issue thoroughly when
> > get time, hopefully, next week.
>
> Here it is: vhost_destroy() will be invoked when:
>
> - QEMU quits gracefully
> - QEMU terminates unexpectedly
>
> Meaning, there should be no memory leak. I think we are fine here (I
> maybe wrong though, feeling a bit dizzy now :(
>
> --yliu
>
next prev parent reply other threads:[~2016-07-19 13:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 17:18 [dpdk-dev] " Christian Ehrhardt
2016-04-18 17:46 ` Yuanhan Liu
2016-04-18 18:14 ` Yuanhan Liu
2016-04-19 16:33 ` Christian Ehrhardt
2016-04-20 5:04 ` Yuanhan Liu
2016-04-20 6:18 ` Christian Ehrhardt
2016-04-21 5:54 ` Yuanhan Liu
2016-04-21 9:07 ` Christian Ehrhardt
2016-07-06 12:24 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-07-06 12:24 ` [dpdk-dev] [PATCH v2] vhost_user: avoid crash when exeeding file descriptors Christian Ehrhardt
2016-07-12 8:37 ` Yuanhan Liu
2016-07-15 19:46 ` Thomas Monjalon
2016-07-06 12:26 ` [dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports Christian Ehrhardt
2016-07-06 12:30 ` Christian Ehrhardt
2016-07-06 12:37 ` Christian Ehrhardt
2016-07-06 13:08 ` Yuanhan Liu
2016-07-12 12:08 ` Yuanhan Liu
2016-07-19 13:50 ` Christian Ehrhardt [this message]
2016-04-21 11:01 ` [dpdk-dev] " Ilya Maximets
2016-04-21 14:04 ` Christian Ehrhardt
2016-04-21 16:56 ` Yuanhan Liu
2016-04-21 16:54 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0KdXj=6S4OG829yY+T4XTyS3FfLMs=MT6w1F8meQ4ZMEA@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=patrik.r.andersson@ericsson.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).