From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com [209.85.216.182]) by dpdk.org (Postfix) with ESMTP id 96CF52BD7 for ; Tue, 19 Jul 2016 15:50:43 +0200 (CEST) Received: by mail-qt0-f182.google.com with SMTP id 52so9339767qtq.3 for ; Tue, 19 Jul 2016 06:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fP2fgj6XsywKXnCB94TndxmHkldtbekHPPL/6QyN5Pg=; b=axyq0wBOEM2FzKdlnRjGGOtOAMwNFqm9r+KAbF0DdULV5ujYt8Bz+QMVWTYJtTb5jT M4/WRtMBPKUYp6zFETGAxAXgc0kmdGgFXHZpvLzh31P72YiojfuwvIfNHw5oCD08Bj6j jvgjkEvAZYwL4tbRwvgwfS1rMGCo4ch14iM6G2TxgBB/VPQmLM3AQJdQ9aLdtPSDtxeK bnrOEntFzEc/ax0J/1KxbWuhp+lnvk+wbJj0OFyteBEl5THUoxCImwS9hlHsV0WAkjLP xdEt8DPBWzx5wlP1Rc8dEjgv62/bRPR2qlqBjs1jiJqhbd5DkdRpXu78alRt3W4yXOAD +sww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fP2fgj6XsywKXnCB94TndxmHkldtbekHPPL/6QyN5Pg=; b=TyhxnSevkvVC2g9mSweDtnVBhnKn9DGq46JzPxLKkZVKOighRllbHlHtyk62Q7reQB d7Fk2/LtkhWcizJKZEO5SnGKVdeLO8XaBikhC4pp7bCAOdW+Hcq6K7Ufhjx8uKfRCraN hK5B1hn5o3oBbq/iz9NUrgpDhi7tqo7dIxo79FuIbgBQBrp/xhXBLU0m+KneE5hTYrQ6 oGQCRdfeKgG8NizeWuzrQXHqqcdem3Ppkntd0yLaEHu4FsgG9X+4DgCwAM3D2RmW2Wal pV6cgnyPKCusDyGCHMgiklrjDMDecsm7qTg1oblVENCIiCUvBy5de07vmxEXRiz7M6IL ecKw== X-Gm-Message-State: ALyK8tLCP9HNB0v02HWc/zYfIMUKMrSUsBEGntFBkJMT81MGk/jRV8QCv90/aTudvHxJbtbx/tVLgFQkt19npytw X-Received: by 10.200.57.34 with SMTP id s31mr62292440qtb.49.1468936242861; Tue, 19 Jul 2016 06:50:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.23.77 with HTTP; Tue, 19 Jul 2016 06:50:23 -0700 (PDT) In-Reply-To: <20160712120847.GE26521@yliu-dev.sh.intel.com> References: <1467807898-27772-1-git-send-email-christian.ehrhardt@canonical.com> <20160706130812.GP26521@yliu-dev.sh.intel.com> <20160712120847.GE26521@yliu-dev.sh.intel.com> From: Christian Ehrhardt Date: Tue, 19 Jul 2016 15:50:23 +0200 Message-ID: To: Yuanhan Liu Cc: Patrik Andersson R , Thomas Monjalon , dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 13:50:43 -0000 Hi, thanks for evaluating. I'll need a few days until I'm ready for OVS again and until OVS is ready for DPDK 16.07. Then I can run an adapted version of my old testcase to be sure. In the worst cases it will be in 16.11 and I'll backport to 16.07 as distributed. I'll let you know then. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Jul 12, 2016 at 2:08 PM, Yuanhan Liu wrote: > On Wed, Jul 06, 2016 at 09:08:12PM +0800, Yuanhan Liu wrote: > > On Wed, Jul 06, 2016 at 02:24:57PM +0200, Christian Ehrhardt wrote: > > > Hi, > > > while checking for dpdk 16.07 what backports are accepted in the > meantime so I > > > can drop them I found this particular discussion has been silently > forgotten by > > > all of us. > > > > Not really. As later I found that my patch was actually wrong (besides > > the issue you already found). I will revisit this issue thoroughly when > > get time, hopefully, next week. > > Here it is: vhost_destroy() will be invoked when: > > - QEMU quits gracefully > - QEMU terminates unexpectedly > > Meaning, there should be no memory leak. I think we are fine here (I > maybe wrong though, feeling a bit dizzy now :( > > --yliu >