From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f176.google.com (mail-io0-f176.google.com [209.85.223.176]) by dpdk.org (Postfix) with ESMTP id DBECA8D89 for ; Tue, 1 Dec 2015 16:08:34 +0100 (CET) Received: by ioir85 with SMTP id r85so12044579ioi.1 for ; Tue, 01 Dec 2015 07:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=7IDM4+IqZExRTRAMKg3lRu7dw6D8RNXF2asz7HLeEPw=; b=g5GJCQqWxgo/2JbKYVcaxoC3y5Bt0J/6hrXd0rqzGZ+g6xcZPqlu2IiKJsBAwIpax5 0c/wsro4riMmoycPhisa2GhBP1aDqBsWep19d0633M+jx7PXtV4peuBuDUvqO93ayr3y zAFruNMyTcjZX3FnExyX7vuLX5j17HQCe2R4ZRSW2XABNmzLqydKdVPocsimA3YWAVva SQXIhsanafZOpgCKcCtOnjESblLssV2kl06j5rNTCtUPR3I2B8hNmC5+NKBs6P2TlYUA V4FMBUTJFNFxR32nsstfatguXRo1/pQiV+JUgDwxQl5WUwukicD1+//nSxrpOIXRQ/jQ QVGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=7IDM4+IqZExRTRAMKg3lRu7dw6D8RNXF2asz7HLeEPw=; b=IWgXDK8UoVPxIpQLUVjEdED+/JMEYPEFiDBjpz1K/Coej2RaakrY4j7iMH19Tkm+Ui kE/sNo58lIUbgcqOtO3wixXcfiNeStdUVjj2UGJE8bhEJ6AN5xL8n5Z/NvuLom+q4ufp z/dJbk8w11Z/WSC+yHWIp+itVbY+Cuc1vDH+K+3W5CPOhB1tM78n06u4eyz5dKrf0cOR UGC5TLiADs8mMDFN1X9xnWd4AXmZtNdYbVe2/3au7LF3j9n7sprV/C7WlVU8vng/XuZI 5QHpJselIMw7GnytTIGsK4lbtw66z0MgJm3vR9nbB78V63VzMbt4F9aPFxl70mknH5sD wpSA== X-Gm-Message-State: ALoCoQmjIxScYyJ7CKob/nwav9OR3mXbJzHXr+0JY/yZM9Rs5cPHk2+RErdn7OSIcpqZjxsuAnVI X-Received: by 10.107.10.162 with SMTP id 34mr63060747iok.121.1448982514212; Tue, 01 Dec 2015 07:08:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.20.131 with HTTP; Tue, 1 Dec 2015 07:08:14 -0800 (PST) In-Reply-To: <565DAF87.2000405@redhat.com> References: <1448980014-31548-1-git-send-email-christian.ehrhardt@canonical.com> <565DAF87.2000405@redhat.com> From: Christian Ehrhardt Date: Tue, 1 Dec 2015 16:08:14 +0100 Message-ID: To: Panu Matilainen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: bump minimum march in default machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 15:08:35 -0000 Hi, thanks! I didn't have the insight of it being "lightly tested and doesn't provide really significant performance improvement". But probably we then should go for the suggestion of the referred mail of "it should probably be disabled by default on all platforms". I'll submit a patch for that then in a few minutes. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Dec 1, 2015 at 3:32 PM, Panu Matilainen wrote= : > On 12/01/2015 04:26 PM, Christian Ehrhardt wrote: >> >> While playing with building 2.2-rc2 I found that our usual way didn't wo= rk >> anymore. >> We usually configured "make config T=3Dx86_64-native-linuxapp-gcc" but t= hen >> set CONFIG_RTE_MACHINE=3D"default" to get something like the "lowest >> acceptable >> build" but with that wide CPU copatibility. >> >> I found that with DPDK 2.2 this fails with issues like: >> In file included from >> /usr/lib/gcc/x86_64-linux-gnu/5/include/immintrin.h:37:0, >> from dpdk-2.2.0-rc2/lib/librte_sched/rte_sched.c:56: >> dpdk-2.2.0-rc2/lib/librte_sched/rte_sched.c: In function >> =E2=80=98grinder_pipe_exists=E2=80=99: >> /usr/lib/gcc/x86_64-linux-gnu/5/include/smmintrin.h:67:1: error: inlinin= g >> failed in call to always_inline =E2=80=98_mm_testz_si128=E2=80=99: targe= t specific option >> mismatch >> _mm_testz_si128 (__m128i __M, __m128i __V) >> ^ >> This is a hard need on newer SSE4.x features which are not given with >> march=3Dcore2. >> >> So if nehalem (the next march level which has SSE4.x) is the new minimum >> let us >> set this in the default machine config. >> >> Signed-off-by: Christian Ehrhardt >> --- >> >> [diffstat] >> rte.vars.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> [diff] >> diff --git a/mk/machine/default/rte.vars.mk >> b/mk/machine/default/rte.vars.mk >> index 53c6af6..170d880 100644 >> --- a/mk/machine/default/rte.vars.mk >> +++ b/mk/machine/default/rte.vars.mk >> @@ -55,4 +55,4 @@ >> # CPU_LDFLAGS =3D >> # CPU_ASFLAGS =3D >> >> -MACHINE_CFLAGS +=3D -march=3Dcore2 >> +MACHINE_CFLAGS +=3D -march=3Dnehalem >> > > You can just disable CONFIG_RTE_SCHED_VECTOR instead. Also see > http://dpdk.org/ml/archives/dev/2015-November/029067.html > > - Panu -