DPDK patches and discussions
 help / color / mirror / Atom feed
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: David Wilder <dwilder@us.ibm.com>, Luca Boccassi <bluca@debian.org>
Cc: Aaron Conole <aconole@redhat.com>,
	maicolgabriel@hotmail.com,  Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	 Andrew Rybchenko <arybchenko@solarflare.com>, dev <dev@dpdk.org>,
	ruifeng.wang@arm.com,  david.marchand@redhat.com,
	David Christensen <drc@linux.vnet.ibm.com>,
	jerinjacobk@gmail.com, wilder@us.ibm.com
Subject: Re: [dpdk-dev] [PATCH v4 0/4] add travis ci support for ppc64le
Date: Thu, 15 Apr 2021 16:45:51 +0200	[thread overview]
Message-ID: <CAATJJ0LVHTzWDy59Msi3Uq9WoOrD3FTE-h8u2K7AYBZ6TUOHKA@mail.gmail.com> (raw)
In-Reply-To: <20200402171241.13258-1-dwilder@us.ibm.com>

On Thu, Apr 2, 2020 at 7:13 PM David Wilder <dwilder@us.ibm.com> wrote:
>
> This patch series adds Travis gcc compilation jobs and unit testing
> for ppc64le.  Limitations for ppc64le are similar to arm64 (see commit
> 31bb45bcfd).
>
> 1. Only gcc builds are supported on ppc64le.
> 2. Hugepages are not available in the ppc64le Travis environment.
> 3. Memory requirements are larger for ppc64le due to a higher
>    RTE_MAX_LCORE value.
>
> V2: Insures iova-mode is VA when --no-huge is selected.
>     Removed setting of --iova-mode=VA in test-null.sh.
> V3: Refactor ppc64le changes on top of David Marchand's
>     Patch series: "Reorganise Travis jobs"
>     http://mails.dpdk.org/archives/dev/2020-February/158231.html
> V4: Adding unit testing.
>     Updated eal/linux: patch to force PA mode when --huge-page is used.
>     This should be a more straightforward solution than my V3 patch.
>
> A Travis build with theses patches can be found here:
> https://travis-ci.org/github/djlwilder/dpdk/builds/670214578
> David Wilder (4):
>   eal/linux: force iova-mode va with no-huge option
>   devtools: allow test-null.sh to run on ppc64le

This affects our testing and from reviewing the code I think the first
two are safe and good.
In addition it affects mostly no-huge which is almost testing-only.
Therefore for patch #1 and #2:

Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

@Luca - could you give this a try if it applies and fixes our issues please?
That would also answer DMs question about applicability.

>   ci: add travis ci support for native ppc64le
>   ci: enable unit test for ppc64le

I can't speak much about the travis change :-/


>  .travis.yml                | 23 +++++++++++++++++++++++
>  devtools/test-null.sh      |  2 +-
>  lib/librte_eal/linux/eal.c | 24 ++++++++++++------------
>  3 files changed, 36 insertions(+), 13 deletions(-)
>
> --
> 2.25.0
>


--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

  parent reply	other threads:[~2021-04-15 14:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 17:12 David Wilder
2020-04-02 17:12 ` [dpdk-dev] [PATCH v4 1/4] eal/linux: force iova-mode va with no-huge option David Wilder
2020-04-02 17:12 ` [dpdk-dev] [PATCH v4 2/4] devtools: allow test-null.sh to run on ppc64le David Wilder
2020-04-02 17:12 ` [dpdk-dev] [PATCH v4 3/4] ci: add travis ci support for native ppc64le David Wilder
2020-04-02 17:12 ` [dpdk-dev] [PATCH v4 4/4] ci: enable unit test for ppc64le David Wilder
2021-03-25 15:06 ` [dpdk-dev] [PATCH v4 0/4] add travis ci support " David Marchand
2021-04-15 14:45 ` Christian Ehrhardt [this message]
2021-04-19 12:22   ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAATJJ0LVHTzWDy59Msi3Uq9WoOrD3FTE-h8u2K7AYBZ6TUOHKA@mail.gmail.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=aconole@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=dwilder@us.ibm.com \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=maicolgabriel@hotmail.com \
    --cc=ruifeng.wang@arm.com \
    --cc=thomas@monjalon.net \
    --cc=wilder@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).