From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A86CA0C3F; Thu, 15 Apr 2021 16:46:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21A3F1622D4; Thu, 15 Apr 2021 16:46:23 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id C9EF216219E for ; Thu, 15 Apr 2021 16:46:21 +0200 (CEST) Received: from mail-qt1-f199.google.com ([209.85.160.199]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lX3G9-0008Oi-34 for dev@dpdk.org; Thu, 15 Apr 2021 14:46:21 +0000 Received: by mail-qt1-f199.google.com with SMTP id o17-20020ac869910000b02901a7c59f1c14so4181720qtq.13 for ; Thu, 15 Apr 2021 07:46:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=01UemePaokq2BJZl65HjvXoGmDvehWXO8iMHzn+SCUI=; b=sX63KWm691UhnLv2ckTfSM5QRZsSFm+e0P+tNY1umOvf0c3qBAh3LGdtRKDUxaWYzt diNfD1po4n5Tzlx7EYFgwrLTCogszxemg6s8039h23XOC5yK0TdhGkp8AZ6j8Y6WckS8 RsXkjpXvuD3aRiG5GAC4JO89sYaGXDbejm7kgc/rNrf1D42aIIAmCbBiCuJ2j0oqe+bz kyy8iVHJnfOx/xCOdeMK2o1i6f67b5MvGr03rkZqEfqyxLaVHy54UhOumfNI42XZm/Tu si6HraIAK7Z5bc4JzPm6soJbQTuiF7gajVG9ZpaHFBEW62xIe94Qxodza8ihCp05F9Jh ZMUw== X-Gm-Message-State: AOAM530ogjGJ53mXlG7gMMuFY1PrOPW+cQ9YR3KFMeFo25mQmONuaJ/Z BWPo76le/eOBC5iET56liH1Wj1gRJaADD911G4QvloAI9h3p0oHSjJtNokqfZNhrxSHgLfV1sLr my8rRqw5HpD0DhdnhVQxPqEdbOlANuTUNy9NQ X-Received: by 2002:ae9:d61c:: with SMTP id r28mr3758478qkk.462.1618497980088; Thu, 15 Apr 2021 07:46:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuIkgZ1HtPxSSOu2MMatsyRpq7fb8i/8W0NSkr2kWMvQpXVQlTURd7A8iMZP0Mhh6IWyCiScmChsN7tXbiJoI= X-Received: by 2002:ae9:d61c:: with SMTP id r28mr3758446qkk.462.1618497979818; Thu, 15 Apr 2021 07:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20200402171241.13258-1-dwilder@us.ibm.com> In-Reply-To: <20200402171241.13258-1-dwilder@us.ibm.com> From: Christian Ehrhardt Date: Thu, 15 Apr 2021 16:45:51 +0200 Message-ID: To: David Wilder , Luca Boccassi Cc: Aaron Conole , maicolgabriel@hotmail.com, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev , ruifeng.wang@arm.com, david.marchand@redhat.com, David Christensen , jerinjacobk@gmail.com, wilder@us.ibm.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/4] add travis ci support for ppc64le X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 2, 2020 at 7:13 PM David Wilder wrote: > > This patch series adds Travis gcc compilation jobs and unit testing > for ppc64le. Limitations for ppc64le are similar to arm64 (see commit > 31bb45bcfd). > > 1. Only gcc builds are supported on ppc64le. > 2. Hugepages are not available in the ppc64le Travis environment. > 3. Memory requirements are larger for ppc64le due to a higher > RTE_MAX_LCORE value. > > V2: Insures iova-mode is VA when --no-huge is selected. > Removed setting of --iova-mode=VA in test-null.sh. > V3: Refactor ppc64le changes on top of David Marchand's > Patch series: "Reorganise Travis jobs" > http://mails.dpdk.org/archives/dev/2020-February/158231.html > V4: Adding unit testing. > Updated eal/linux: patch to force PA mode when --huge-page is used. > This should be a more straightforward solution than my V3 patch. > > A Travis build with theses patches can be found here: > https://travis-ci.org/github/djlwilder/dpdk/builds/670214578 > David Wilder (4): > eal/linux: force iova-mode va with no-huge option > devtools: allow test-null.sh to run on ppc64le This affects our testing and from reviewing the code I think the first two are safe and good. In addition it affects mostly no-huge which is almost testing-only. Therefore for patch #1 and #2: Reviewed-by: Christian Ehrhardt @Luca - could you give this a try if it applies and fixes our issues please? That would also answer DMs question about applicability. > ci: add travis ci support for native ppc64le > ci: enable unit test for ppc64le I can't speak much about the travis change :-/ > .travis.yml | 23 +++++++++++++++++++++++ > devtools/test-null.sh | 2 +- > lib/librte_eal/linux/eal.c | 24 ++++++++++++------------ > 3 files changed, 36 insertions(+), 13 deletions(-) > > -- > 2.25.0 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd