From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable
Date: Wed, 3 Aug 2016 11:42:35 +0200 [thread overview]
Message-ID: <CAATJJ0Lbn6toSntTMdbx6C2uW3+3Pm1NN03NDHRQmTw4BYV29w@mail.gmail.com> (raw)
In-Reply-To: <20160803092633.GB24816@bricha3-MOBL3>
On Wed, Aug 3, 2016 at 11:26 AM, Bruce Richardson <
bruce.richardson@intel.com> wrote:
> Definitely no objection on the file mode change.
>
> For the dropping of the .sh extension, I don't think it matters much.
> However,
> given that .sh files are generally scripts to be executed, I think
> dropping the
> extension will reduce confusion.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Thank you Bruce
@Thomas - given we are 2:1 now, the patch would stay as-is.
Do you want me to resubmit as-is but without RFC tag or would you accept it
as already submitted?
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
next prev parent reply other threads:[~2016-08-03 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 13:54 Christian Ehrhardt
2016-08-02 15:30 ` Thomas Monjalon
[not found] ` <CAATJJ0L4a2fdmNzMmKvnXGeQJR4ch3ChYg1WPH142wbtvkknzQ@mail.gmail.com>
[not found] ` <1518657.ZZVjD1fj2f@xps13>
2016-08-03 8:11 ` Christian Ehrhardt
2016-08-03 9:26 ` Bruce Richardson
2016-08-03 9:42 ` Christian Ehrhardt [this message]
2016-08-03 13:19 ` Thomas Monjalon
2016-08-03 14:54 ` Christian Ehrhardt
2016-08-03 14:59 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-08-24 16:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0Lbn6toSntTMdbx6C2uW3+3Pm1NN03NDHRQmTw4BYV29w@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).