From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f52.google.com (mail-qg0-f52.google.com [209.85.192.52]) by dpdk.org (Postfix) with ESMTP id 06A975595 for ; Wed, 16 Mar 2016 15:21:13 +0100 (CET) Received: by mail-qg0-f52.google.com with SMTP id a36so12361352qge.0 for ; Wed, 16 Mar 2016 07:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nE6K77v6NTPl9Pq8R62fNZ5wIZkA5L407Y4rXbtpAkI=; b=VjxGA9D4tk+sdn3bWcU1Lq3caxEok6YAHXbJdoNQVjvnkJbmXyvf0y3JrMiCNU2pny sTprl/zGuoF13hceuJtMpWNDj3MLwfmxDaZD98kyLk/ojYc/GaousQD0x3VKkYwRrX6I MtsBkgkSBTO7EleVvo2eiaTt6fJ7pz8I0QNwUaTSYniaLlfc+CcfzDr9bxdGLaR8vkm3 98SK3u8W+aOwJHztIkUiN98VcRjHknPRRa/8HQORn4SySQu6H9QYCW2apUSmhbhgB4Ak KaNmF7RrAdTJQOJpwEJtip6kNAKFzzHq19BmcYIj94MVAyGSFOhsrKKwgqk1YNki0xvx q+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nE6K77v6NTPl9Pq8R62fNZ5wIZkA5L407Y4rXbtpAkI=; b=FOMVvLUae66wnXMuzm4aaOdYYDRSmyHqmXXw5G8ooD+dp8HmOmmllg2+FbKxg82LLJ RvhhYY4Ntb7p+WpHFH3tw20tgd+deHVI8qzMw+DoGitcKet9b/CNY++ikP1ti4wOaiDb XF9rV6Nfe9V1i2feUSaKHaQZS5O2e98Q87kapHhI0LeeQLBntXPXBX/OSgQClexgtN9Y 1X/9CycxzUH6MPVQkTAncqVDJ2SncdOTrcrQL3dbYuKiRBBcLkWzTOn+oqpYN+EA6Ayr 1aIAuVrjq666QCgJ5MDpC04D4Nlfs5T3k4pW6+XoNJ1Viyi3vRoJ4oxGgYsfYXr/DC9X iUkw== X-Gm-Message-State: AD7BkJKuSKBS1vomYT3TE2OTiABChAp2+XKxS+O9lohnJivIpxOlri5iUIFM/C3Pl6B+dTmYjMPRnQLaaRsYNsjV X-Received: by 10.140.89.103 with SMTP id u94mr5594517qgd.3.1458138072397; Wed, 16 Mar 2016 07:21:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.169.6 with HTTP; Wed, 16 Mar 2016 07:20:52 -0700 (PDT) In-Reply-To: References: <1458044751-365-1-git-send-email-olivier.matz@6wind.com> <56E95B6E.3070500@6wind.com> From: Christian Ehrhardt Date: Wed, 16 Mar 2016 15:20:52 +0100 Message-ID: To: Olivier MATZ , Bruce Richardson Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] lpm: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 14:21:13 -0000 Hi, I'm done comparing our two patches and just submitted a v3 of my series based on that. I found even more use after free and leaks than we had before. Patch series has grown to 5 patches now. At least my gmail groups subsequent git send-email posts weirdly, let me know if you are in any trouble reviewing applying them. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Mar 16, 2016 at 2:21 PM, Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Thanks Oliver, the bad thing was that I forgot to CC dpdk-dev last friday. > I just resubmitted correcting that mistake. > > I think it should now just be down to the re-review and apply of Bruce. > > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > > On Wed, Mar 16, 2016 at 2:11 PM, Olivier MATZ > wrote: > >> >> >> On 03/15/2016 01:25 PM, Olivier Matz wrote: >> >>> Internal lpm structures are not properly freed. Seen with the >>> lpm6 autotest. >>> >>> Signed-off-by: Olivier Matz >>> --- >>> lib/librte_lpm/rte_lpm.c | 3 +++ >>> lib/librte_lpm/rte_lpm6.c | 1 + >>> 2 files changed, 4 insertions(+) >>> >>> >> Self-nack, Christian already submitted a series about it: >> >> http://dpdk.org/dev/patchwork/patch/11543/ >> http://dpdk.org/dev/patchwork/patch/11544/ >> http://dpdk.org/dev/patchwork/patch/11545/ >> >> >