From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f193.google.com (mail-ua0-f193.google.com [209.85.217.193]) by dpdk.org (Postfix) with ESMTP id 5C5975F17 for ; Thu, 26 Apr 2018 12:20:04 +0200 (CEST) Received: by mail-ua0-f193.google.com with SMTP id h15so10424077uan.11 for ; Thu, 26 Apr 2018 03:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kPq/sZuuQyfiGekHmGfysdbqf0nUKHcaBoamyXTXKiI=; b=h2T6/JlXr9rAm5F8Ni3a0I/d5YOux2z17nDW9o9qvu5J8VCM3dpe7aDsTlGhJeKhhI oNV1ZYUBTDDAv/0qqXixVeCsSmJGXCljCjwXKAlPeZvoky63dWe/WRtlJOu1NkHhd/rO MOItI+cW34x9I7C/eJWXK9Ar0nSJ3oPHMCon6Kx2yvl0EIsZmUEYqNQj5QwmS9wFeqoY nayWuOiikknGjnAWJ/STRiqzxMlzh09OQ/KCkVcXyw6MBy/JgGH77NIUmPnEbCbe4yu6 V6ZTr7u9gKa9bxt40f67twu3oFP5CyYcDttwCxlNMNT4fv0mABCZrg49F8SIBrUx71nN Yd0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kPq/sZuuQyfiGekHmGfysdbqf0nUKHcaBoamyXTXKiI=; b=o8ZW/7Ew1PdqKYOKCo5t3Tsj+RfJJijGNCwwMZS3347CTsoXJ/T+AzlM5rvw8qKWKM adiETA6rnhzDS5ydAczmxvZtxgFXsP8ualsmV8bOzdzHyYwPKPhkb0uhQcF5xNPkX+BO YlXpmVlcZDHVJSh9kID6drGQazLpYIDFWSifOI0vpn8X6r0weBag3htZAmrS6lnMWwP8 x9aYEqy1mZjYLmj3DXxgVi/FFwqgYQbnG6dgnwIlD74pPiK2aVztshknlq0PGCmzIqc7 4/uHBgM5tRVmVhtwTXvptumPr3eDiOajeymCu+C9Atkc9gQkTpXpObkz+EYep3GQySzl 9PwA== X-Gm-Message-State: ALQs6tAeO6lU0DDgFn1QVCbW1t43wiMMQzmZGHI1yYNyhln1TpgOXPop Niy70ExMzgX8vwN5RzSwjYeXsU1Vh+4Sb2HaJhU= X-Google-Smtp-Source: AIpwx4+dKIuZPPfUexgEaTz3ay7Az6E3cqPQjqnCVHauWhzzKlCcAkJ6QbP11i1I5zxLKrCtg5LMh66BMUAKulFYPUc= X-Received: by 10.176.24.228 with SMTP id d36mr25172564uah.203.1524738004358; Thu, 26 Apr 2018 03:20:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.87.66 with HTTP; Thu, 26 Apr 2018 03:20:03 -0700 (PDT) In-Reply-To: References: <20180223115913.19266-1-shweta.choudaha@gmail.com> <20180223115913.19266-2-shweta.choudaha@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B76070A@shsmsx102.ccr.corp.intel.com> <58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com> <20180404104042.GA17064@bricha3-MOBL.ger.corp.intel.com> From: Shweta Choudaha Date: Thu, 26 Apr 2018 11:20:03 +0100 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , "Lu, Wenzhuo" , "dev@dpdk.org" , "shweta.choudaha@att.com" , "Zhang, Helin" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 10:20:05 -0000 Hi Ferruh/ Helin, Anything else needed for this patch http://dpdk.org/dev/patchwork/patch/37802/ Or can this be now acked - Have addressed all comments so far. Thanks, Shweta On Tue, Apr 10, 2018 at 4:58 PM, Shweta Choudaha wrote: > Thanks for the review. > I have sent an updated patch and will send patch to remove experimental > from API for next release > > Thanks, > Shweta > > On Wed, Apr 4, 2018 at 11:40 AM, Bruce Richardson < > bruce.richardson@intel.com> wrote: > >> On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote: >> > On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote: >> > > Hi Shweta, >> > > >> > > >> > >> -----Original Message----- >> > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha >> > >> Sent: Friday, February 23, 2018 7:59 PM >> > >> To: dev@dpdk.org >> > >> Cc: shweta.choudaha@att.com >> > >> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit >> > >> >> > >> From: Shweta Choudaha >> > >> >> > >> Add ixgbe API to enable SBP bit in FCTRL register to allow receiving >> packets >> > >> that may otherwise be considered length errors by ixgbe and dropped >> > >> >> > >> Signed-off-by: Shweta Choudaha >> > >> Reviewed-by: Chas Williams >> > >> Reviewed-by: Luca Boccassi >> > >> --- >> > > >> > > >> > >> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map >> > >> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map >> > >> @@ -52,3 +52,9 @@ DPDK_17.08 { >> > >> rte_pmd_ixgbe_bypass_wd_timeout_show; >> > >> rte_pmd_ixgbe_bypass_wd_timeout_store; >> > >> } DPDK_17.05; >> > >> + >> > >> +EXPERIMENTAL { >> > >> + global: >> > >> + >> > >> + rte_pmd_ixgbe_upd_fctrl_sbp; >> > >> +} DPDK_17.08; >> > > The patch is fine except we should use 18.05 here. >> > >> > We have a rule to have an API as experimental for one release. >> > >> > Not sure about this rule covering the PMD specific APIs but by default >> it is, we >> > can discuss to have an exception for PMD APIs or not. >> > >> > After one release developer should send patch to remove experimental >> from API >> > >> +1 for following the process. >> I don't see why pmd-specific APIs should be a general exception. Any >> exceptions should be on an individual case-by-case basis IMHO >> > >