From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AF8AA046B for ; Fri, 28 Jun 2019 16:12:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40B1B37B0; Fri, 28 Jun 2019 16:12:14 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 88D4F37A8 for ; Fri, 28 Jun 2019 16:12:12 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id g7so4352218oia.8 for ; Fri, 28 Jun 2019 07:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cc6zP/N9awrq80XtbyPJlTp+I48y7T5hpdanzIB3Kek=; b=nF78WN2GGRuf0ciARPk1BIhZaE6RJZ3UWJKEvfGQVXLjUcQuh14kPJaU5otSGKguCY 24xPA96xFP3m7E4z8GO7AEgEdSsJCRnRfmkIHeaHXCF/QJZJyUlRSmenGlLO9Y5/dzB2 Zgzw8jgwYox9HzKoccgjagXcXaeTX0BM5NloEiHZPH9wGvvjVCkLs6RuJYz7Jb89F9iU /zxv2xwUaQT9eOBekSYWbrhgVHthkq7tk3lEYHGk6EC2ErYavIf85vMsIGDq37JWvPS4 W+QQAsOt2LUcoauhsb/O/hBQnC2O4Zt/dcQu791jnwsaI3E8nH/vDBvjPNKYZB7+XVeB 0uPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cc6zP/N9awrq80XtbyPJlTp+I48y7T5hpdanzIB3Kek=; b=RldDhJPPM+AJZKzJ4vRDMiXBoAAJPLh2qq0XT3RbZxWA93s3QEGHmMQ4yPOk+dezcc UCg90lTzelpLlZUtc1K+WKExJlFvhB7zJeINoCUGUz3KQst+yM1tnmr2HNxlQ464P2k3 yXIyhZ/0kGtsKzj1CuK1dRsEJ0ClS8n+o8ARHA4NHdt6VPmcQ2htBSsBd1Eu7sT7RWJB GbIz0tWNSYxsw+ZKl56T6FTfbjrlYDGk6c/F6GJuS8LFO2VK1hL9PWTW8mXb6kC2iT16 aCk+ls/3uhRW7um0UU+M+Q39NnrJmJDUtX2K/4Vtu9gEE8liS+T+kTBn0pCu9JSxBs3C Vd6Q== X-Gm-Message-State: APjAAAUS2tIDrY2rclDHjsGYHl0OTku9ltqLEQYZvs1EmRonDcFBCYIy QYqKSuTQlL4dgRf0q5R0mZlrUy9GDWrQNtRDfFlBfQ== X-Google-Smtp-Source: APXvYqycJapFHLaAW5hA+u7T4gPKCDLSxMxQ6x88faeP6UKVTeUra4uTD8697K570PcLU/xXaKFQ1RrOuqkw9oH1u/I= X-Received: by 2002:aca:cf51:: with SMTP id f78mr1827656oig.10.1561731131882; Fri, 28 Jun 2019 07:12:11 -0700 (PDT) MIME-Version: 1.0 References: <1560427509-56164-1-git-send-email-cernay@netcope.com> <2de7358f-189e-e687-4868-0f1c6bd72cb1@intel.com> In-Reply-To: <2de7358f-189e-e687-4868-0f1c6bd72cb1@intel.com> From: =?UTF-8?Q?Jan_Reme=C5=A1?= Date: Fri, 28 Jun 2019 16:12:00 +0200 Message-ID: To: Ferruh Yigit Cc: Rastislav Cernay , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] drivers/net/nfb: add timestamp support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 27, 2019 at 5:45 PM Ferruh Yigit wrote: > > On 6/13/2019 1:05 PM, Rastislav Cernay wrote: > > +Timestamping needs to be enabled during compile time, as there is no way > > +to check whether a timestamping unit is runnig during run time. > > Even if this can't be detected on runtime, it should be possible to configure in > runtime with device args so need to compile the PMD again to change the behavior. > > In this patch default behavior is no timestamps support, same can be done with > devargs, without any devargs timestamp support disable, but if user provides a > devarg, like "timestamp=1", feature enabled. > > What do you think, can it be possible to convert runtime configuration? This sounds good. We did not explore the devargs option. We will look into it, and probably rework this patch and send v2. Thanks, Jan