From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <matthias.gatto@outscale.com>
Received: from mail-yw0-f175.google.com (mail-yw0-f175.google.com
 [209.85.161.175]) by dpdk.org (Postfix) with ESMTP id AEF1A2A5E
 for <dev@dpdk.org>; Wed, 22 Feb 2017 11:01:44 +0100 (CET)
Received: by mail-yw0-f175.google.com with SMTP id l19so2782423ywc.2
 for <dev@dpdk.org>; Wed, 22 Feb 2017 02:01:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=outscale-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=uNlwDYqFeGqssGBISOljvJlVqQJbf1jbbJs/TDnaJoI=;
 b=ahNBZy2fvxpdAzF9MI+H57Edmfz4lK35jI4nMUwqJbT+AGDSXfS9z+lnrTeeoL8QUQ
 eB/yP56z1koHWF3CnyvgvFPtcytPUaaeMVkRUG7re7N5qCyVvXuq5bC14A3oLbpDHeXU
 N2wYwALS9AzONs9McyoWPNM7DyohKZ7U18hUDOE9oYVUhmJyWwMlE+jeKd15ie9NMXTM
 8jQsHT5QMSgj6J3ZNbBj0Adds6griAxnuUQy3QdlX4rCnVJhsvmXztGj3xlqvNJiGYWp
 reFnlqGSi7p8YSfLh/ODbBKzT+ydcmjcO+w43zEaySU+Ox+0gmBHYzaOt8vKK9+4eMop
 YdQA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=uNlwDYqFeGqssGBISOljvJlVqQJbf1jbbJs/TDnaJoI=;
 b=T+ZLtuUhM5UuEyqWhIE5MKPJZtNMooU5DZ8SLo5DFDHepfLv85877BM9nsHwfRCArm
 cDcsQ3dDqnnjM8kmxEL7u0tTMjLyhundHU+dJrZjT1IGRuCk1lVdH12947/eYjzujYQt
 9lNPNHswEh6GdXyDOtBPt14R8GY3wQZWRZ+xhOguTI3/mh6juq6/UsqoueKW+AoneVQ+
 FR0HNpdtKc76RFCsT1XU6nnhFBY6QzXLt4eiW2sHLdBZ9Xxal8kcSatpB8xrchiJx14s
 n4CBkkYH1JT5vOVGRWzmwtz3ALxly0dG0lJ/FRsUq4U9DevQYhwB9gCPMhmnAxcZ+2tj
 bdCQ==
X-Gm-Message-State: AMke39knnTSU+gIsQGXFi3cuCnSZNHP4WSoPHWDlyDKAswG1NEDaMCSbgYUIRWxj654y/PA45UYKKMQry+0RWUbi
X-Received: by 10.129.102.10 with SMTP id a10mr4173725ywc.266.1487757704013;
 Wed, 22 Feb 2017 02:01:44 -0800 (PST)
MIME-Version: 1.0
Received: by 10.37.14.3 with HTTP; Wed, 22 Feb 2017 02:01:43 -0800 (PST)
In-Reply-To: <20170222015931.GK18844@yliu-dev.sh.intel.com>
References: <20170221142530.31472-1-matthias.gatto@outscale.com>
 <20170222015931.GK18844@yliu-dev.sh.intel.com>
From: Matthias Gatto <matthias.gatto@outscale.com>
Date: Wed, 22 Feb 2017 11:01:43 +0100
Message-ID: <CAAsw5BcH6H5qZC31uwJj1Y8nVGMNTdzguE5nxFNe6-787FEy6w@mail.gmail.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Content-Type: text/plain; charset=UTF-8
Subject: Re: [dpdk-dev] [PATCH] vhost: try to shrink pfdset when fdset_add
	fails
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Feb 2017 10:01:45 -0000

On Wed, Feb 22, 2017 at 2:59 AM, Yuanhan Liu
<yuanhan.liu@linux.intel.com> wrote:
>
> On Tue, Feb 21, 2017 at 03:25:30PM +0100, Matthias Gatto wrote:
> > fdset_add increment pfdset->num, but fdset_del doesn't decrement pfdset->num,
> > so if we call fdset_add then fdset_del in a loop witout calling
> > fdset_shrink, we can easily exceed MAX_FDS with only a few number of fds
> > used.
>
> I'm assuming you were doing some tests like following?
>
>         while true; do
>                 ovs-vsctl add-port br vhost_n -- ...
>                 ovs-vsctl del-port vhost_n
>         done
>

Something pretty close to this yes.